mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
96 lines
3.1 KiB
TypeScript
96 lines
3.1 KiB
TypeScript
/**
|
|
* Unit tests: agentBridgeHook — source and agent field assignment
|
|
*
|
|
* Verifies that recordRequestStart() sets:
|
|
* - source="custom-host" + agent=undefined when the request host is in
|
|
* inspector_custom_hosts with enabled=1 (R5-8)
|
|
* - source="agent-bridge" + agent=agentId otherwise
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import type { IncomingMessage } from "node:http";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ab-hook-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { resetDbInstance, getDbInstance } = await import("../../src/lib/db/core.ts");
|
|
const { addCustomHost, toggleCustomHost } =
|
|
await import("../../src/lib/db/inspectorCustomHosts.ts");
|
|
const { recordRequestStart } = await import("../../src/mitm/inspector/agentBridgeHook.ts");
|
|
|
|
async function resetStorage() {
|
|
resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
getDbInstance();
|
|
}
|
|
|
|
function makeFakeReq(host: string): IncomingMessage {
|
|
return {
|
|
method: "POST",
|
|
url: "/v1/chat/completions",
|
|
headers: { host, "content-type": "application/json" },
|
|
} as unknown as IncomingMessage;
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("recordRequestStart: custom-host entry → source=custom-host, agent=undefined", async () => {
|
|
addCustomHost("my-app.example.com", "app", "My App");
|
|
|
|
const entry = await recordRequestStart({
|
|
req: makeFakeReq("my-app.example.com"),
|
|
body: Buffer.from("{}"),
|
|
agentId: "codex" as any,
|
|
mappedModel: "gpt-4o",
|
|
});
|
|
|
|
assert.equal(entry.source, "custom-host", "source should be custom-host");
|
|
assert.equal(entry.agent, undefined, "agent should be undefined for custom-host");
|
|
assert.equal(entry.host, "my-app.example.com");
|
|
});
|
|
|
|
test("recordRequestStart: non-custom host → source=agent-bridge, agent=agentId", async () => {
|
|
// Do NOT add the host to inspector_custom_hosts
|
|
const entry = await recordRequestStart({
|
|
req: makeFakeReq("api.openai.com"),
|
|
body: Buffer.from("{}"),
|
|
agentId: "codex" as any,
|
|
mappedModel: "gpt-4o",
|
|
});
|
|
|
|
assert.equal(entry.source, "agent-bridge", "source should be agent-bridge");
|
|
assert.equal(entry.agent, "codex", "agent should be the provided agentId");
|
|
assert.equal(entry.host, "api.openai.com");
|
|
});
|
|
|
|
test("recordRequestStart: disabled custom-host → source=agent-bridge (not matched)", async () => {
|
|
addCustomHost("disabled-app.example.com");
|
|
toggleCustomHost("disabled-app.example.com", false);
|
|
|
|
const entry = await recordRequestStart({
|
|
req: makeFakeReq("disabled-app.example.com"),
|
|
body: Buffer.from("{}"),
|
|
agentId: "codex" as any,
|
|
mappedModel: "gpt-4o",
|
|
});
|
|
|
|
assert.equal(
|
|
entry.source,
|
|
"agent-bridge",
|
|
"disabled custom-host should not be treated as custom-host source"
|
|
);
|
|
assert.equal(entry.agent, "codex");
|
|
});
|