mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
59 lines
2.3 KiB
TypeScript
59 lines
2.3 KiB
TypeScript
/**
|
|
* Regression test for #3589 — Kiro "Import Token" surfaced a bare
|
|
* `Internal server error` 500 that hid the real cause. The failure happens while
|
|
* validating/refreshing the imported refresh token against AWS (invalid_grant /
|
|
* expired token / region mismatch), but the catch returned a generic string, so
|
|
* the UI never told the user what was actually wrong. The import error body now
|
|
* carries the sanitized upstream cause (Rule #12 — no stack, no secrets), falling
|
|
* back to the generic message only when there is nothing to report.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// Hermetic temp DATA_DIR so importing the route's dependency graph is safe.
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-kiro-3589-"));
|
|
process.env.DATA_DIR = tmpDir;
|
|
process.env.JWT_SECRET = process.env.JWT_SECRET || "test-jwt-secret-3589";
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "test-api-key-secret-3589";
|
|
|
|
const { buildKiroImportError } = await import("../../src/app/api/oauth/kiro/import/route.ts");
|
|
|
|
test.after(() => {
|
|
try {
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// best effort
|
|
}
|
|
});
|
|
|
|
test("surfaces the real AWS cause (invalid_grant) instead of a generic 500", () => {
|
|
const msg = buildKiroImportError(new Error("invalid_grant"));
|
|
assert.match(msg, /invalid_grant/);
|
|
assert.notEqual(msg, "Internal server error");
|
|
});
|
|
|
|
test("surfaces a region-mismatch cause", () => {
|
|
const msg = buildKiroImportError(new Error("Region mismatch: token issued for us-east-1"));
|
|
assert.match(msg, /region mismatch/i);
|
|
});
|
|
|
|
test("accepts a non-Error throw value", () => {
|
|
const msg = buildKiroImportError("expired token");
|
|
assert.match(msg, /expired token/);
|
|
});
|
|
|
|
test("never leaks a stack trace in the surfaced message", () => {
|
|
const err = new Error("boom");
|
|
err.stack = "Error: boom\n at /home/user/app/src/lib/oauth/services/kiro.ts:120:11";
|
|
const msg = buildKiroImportError(err);
|
|
assert.doesNotMatch(msg, /at \//);
|
|
});
|
|
|
|
test("falls back to the generic message when there is nothing to report", () => {
|
|
assert.equal(buildKiroImportError(new Error("")), "Internal server error");
|
|
assert.equal(buildKiroImportError(undefined), "Internal server error");
|
|
});
|