Files
OmniRoute/tests/unit/latency-stats-ttft-6875.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

143 lines
4.8 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// #6875 — TTFT / E2E-latency / tokens-per-second aggregation in
// getModelLatencyStats(). Seeds usage_history rows directly through
// saveRequestUsage() and asserts the three new ModelLatencyStatsEntry fields.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-latency-ttft-6875-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
const usageHistory = await import("../../src/lib/usage/usageHistory.ts");
const clearPendingRequests = usageHistory.clearPendingRequests;
async function resetStorage() {
core.resetDbInstance();
apiKeysDb.resetApiKeyState();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
clearPendingRequests();
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(() => {
core.resetDbInstance();
apiKeysDb.resetApiKeyState();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("getModelLatencyStats aggregates avgTtftMs/avgE2ELatencyMs/avgTokensPerSecond over successful rows", async () => {
const now = Date.now();
// latencyMs / ttft / tokensOutput chosen so tokens/sec is a clean number per row:
// 50/(1000/1000)=50, 100/(2000/1000)=50, 300/(4000/1000)=75 -> mean 58.33
const rows = [
{ latencyMs: 1000, ttftMs: 100, tokensOutput: 50 },
{ latencyMs: 2000, ttftMs: 200, tokensOutput: 100 },
{ latencyMs: 4000, ttftMs: 300, tokensOutput: 300 },
];
for (const [index, row] of rows.entries()) {
await usageHistory.saveRequestUsage({
provider: "ttft-provider",
model: "ttft-model",
success: true,
latencyMs: row.latencyMs,
timeToFirstTokenMs: row.ttftMs,
tokens: { output: row.tokensOutput },
timestamp: new Date(now - index * 60 * 1000).toISOString(),
});
}
const stats = await usageHistory.getModelLatencyStats({
windowHours: 1,
minSamples: 2,
maxRows: 50,
});
const entry = stats["ttft-provider/ttft-model"];
assert.ok(entry);
assert.equal(entry.avgTtftMs, 200);
// avgE2ELatencyMs aliases avgLatencyMs semantics (no distinct second latency
// column exists in usage_history beyond latency_ms/ttft_ms).
assert.equal(entry.avgE2ELatencyMs, entry.avgLatencyMs);
assert.equal(entry.avgE2ELatencyMs, 2333);
assert.equal(Math.round(entry.avgTokensPerSecond * 100) / 100, 58.33);
});
test("getModelLatencyStats guards divide-by-zero when latency_ms <= 0 for tokens/sec", async () => {
await usageHistory.saveRequestUsage({
provider: "zero-latency-provider",
model: "zero-latency-model",
success: true,
latencyMs: 0,
timeToFirstTokenMs: 0,
tokens: { output: 999 },
timestamp: new Date().toISOString(),
});
await usageHistory.saveRequestUsage({
provider: "zero-latency-provider",
model: "zero-latency-model",
success: true,
latencyMs: 1000,
timeToFirstTokenMs: 50,
tokens: { output: 100 },
timestamp: new Date(Date.now() - 60 * 1000).toISOString(),
});
const stats = await usageHistory.getModelLatencyStats({
windowHours: 1,
minSamples: 1,
maxRows: 50,
});
const entry = stats["zero-latency-provider/zero-latency-model"];
assert.ok(entry);
assert.ok(Number.isFinite(entry.avgTokensPerSecond));
// Only the latencyMs=1000 row can contribute a valid tokens/sec sample
// (100 tokens / 1s = 100 tok/s); the zero-latency row must be excluded,
// not divide-by-zero into Infinity/NaN.
assert.equal(entry.avgTokensPerSecond, 100);
});
test("getModelLatencyStats TTFT falls back to all-sample TTFTs when successful sample count is below minSamples", async () => {
await usageHistory.saveRequestUsage({
provider: "fallback-ttft-provider",
model: "fallback-ttft-model",
success: true,
latencyMs: 100,
timeToFirstTokenMs: 40,
tokens: { output: 10 },
timestamp: new Date().toISOString(),
});
await usageHistory.saveRequestUsage({
provider: "fallback-ttft-provider",
model: "fallback-ttft-model",
success: false,
latencyMs: 500,
timeToFirstTokenMs: 200,
tokens: { output: 5 },
timestamp: new Date().toISOString(),
});
const stats = await usageHistory.getModelLatencyStats({
windowHours: 1,
minSamples: 2,
});
const entry = stats["fallback-ttft-provider/fallback-ttft-model"];
assert.ok(entry);
// successfulLatencies.length (1) < minSamples (2) -> same fallback-to-all
// behavior avgLatencyMs already has must also apply to avgTtftMs.
assert.equal(entry.avgLatencyMs, 300);
assert.equal(entry.avgTtftMs, 120);
});