Files
OmniRoute/tests/unit/lib/jobs/backupScheduleJob.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

98 lines
3.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { mkdtempSync, writeFileSync, readFileSync, rmSync, existsSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
async function withTmpDataDir(fn: (dataDir: string) => Promise<void>) {
const dataDir = mkdtempSync(join(tmpdir(), "omniroute-backup-job-test-"));
const orig = process.env.DATA_DIR;
process.env.DATA_DIR = dataDir;
try {
await fn(dataDir);
} finally {
if (orig === undefined) delete process.env.DATA_DIR;
else process.env.DATA_DIR = orig;
rmSync(dataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
}
test("runBackupScheduleTick — no schedule file: no-op, no throw", async () => {
await withTmpDataDir(async () => {
const { runBackupScheduleTick } = await import("@/lib/jobs/backupScheduleJob");
const ran = await runBackupScheduleTick(new Date(2026, 6, 25, 3, 0, 0));
assert.equal(ran, false);
});
});
test("runBackupScheduleTick — disabled schedule: no-op", async () => {
await withTmpDataDir(async (dataDir) => {
writeFileSync(
join(dataDir, "backup-schedule.json"),
JSON.stringify({
enabled: false,
cron: "0 3 * * *",
cloud: false,
encrypt: false,
retention: 7,
})
);
const { runBackupScheduleTick } = await import("@/lib/jobs/backupScheduleJob");
const ran = await runBackupScheduleTick(new Date(2026, 6, 25, 3, 0, 0));
assert.equal(ran, false);
});
});
test("runBackupScheduleTick — enabled but current time doesn't match cron: no-op", async () => {
await withTmpDataDir(async (dataDir) => {
writeFileSync(
join(dataDir, "backup-schedule.json"),
JSON.stringify({
enabled: true,
cron: "0 3 * * *",
cloud: false,
encrypt: false,
retention: 7,
})
);
const { runBackupScheduleTick } = await import("@/lib/jobs/backupScheduleJob");
const ran = await runBackupScheduleTick(new Date(2026, 6, 25, 9, 0, 0));
assert.equal(ran, false);
});
});
test("runBackupScheduleTick — enabled + matching time: fires exactly once, updates lastRunAt", async () => {
await withTmpDataDir(async (dataDir) => {
writeFileSync(
join(dataDir, "storage.sqlite"),
Buffer.alloc(4096) // large enough for runBackupCommand's FILES_TO_BACKUP existsSync check
);
writeFileSync(
join(dataDir, "backup-schedule.json"),
JSON.stringify({
enabled: true,
cron: "0 3 * * *",
cloud: false,
encrypt: false,
retention: null,
})
);
const { runBackupScheduleTick } = await import("@/lib/jobs/backupScheduleJob");
const dueAt = new Date(2026, 6, 25, 3, 0, 0);
const firstRun = await runBackupScheduleTick(dueAt);
assert.equal(firstRun, true, "first tick at the matching minute should fire");
const schedule = JSON.parse(readFileSync(join(dataDir, "backup-schedule.json"), "utf8"));
assert.ok(schedule.lastRunAt, "lastRunAt should be recorded");
assert.ok(existsSync(join(dataDir, "backups")), "a backup should have been created");
// Second tick within the SAME matching minute must not re-fire — this is the
// difference between a scheduling library and a naive per-tick cron check:
// without lastRunAt tracking, every tick inside the matching minute would
// fire again (the interval is shorter than 60s).
const secondRun = await runBackupScheduleTick(dueAt);
assert.equal(secondRun, false, "same minute must not fire twice");
});
});