Files
OmniRoute/tests/unit/lib/quota-reset-events.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

208 lines
5.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-quota-reset-events-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../../src/lib/db/core.ts");
const {
recordProviderQuotaResetEventIfChanged,
getProviderQuotaWindowStart,
getProviderQuotaWindowStartIso,
} = await import("../../../src/lib/db/quotaResetEvents.ts");
// Force migrations (incl. 108_provider_quota_reset_events) to run.
core.getDbInstance();
const CONN = "conn-1";
const PROVIDER = "antigravity";
const PREV_RESET = "2026-01-08T00:00:00.000Z";
const CUR_RESET = "2026-01-15T00:00:00.000Z"; // +7d, different day
const OBSERVED = "2026-01-15T00:05:00.000Z";
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("records a weekly window transition and getWindowStart returns the prior window start", () => {
recordProviderQuotaResetEventIfChanged({
provider: PROVIDER,
connectionId: CONN,
windowKey: "weekly",
currentResetAt: CUR_RESET,
currentRemainingPercentage: 100,
previousObservation: { resetAt: PREV_RESET, remainingPercentage: 5 },
observedAt: OBSERVED,
});
// For the new window (resets at CUR_RESET) the observed start is PREV_RESET.
const start = getProviderQuotaWindowStartIso(CONN, CUR_RESET, Date.parse(OBSERVED) + 1000);
assert.equal(start, PREV_RESET);
});
test("getWindowStart returns null for a reset day with no recorded event", () => {
assert.equal(
getProviderQuotaWindowStartIso(CONN, "2026-02-01T00:00:00.000Z", Date.parse(OBSERVED) + 1000),
null
);
});
test("observed same-resetAt quota drop overrides an older recorded weekly window", () => {
const connectionId = "conn-early-reset-snapshot";
const targetResetAt = "2026-07-02T23:00:00.000Z";
const db = core.getDbInstance();
db.prepare(
`
INSERT INTO provider_quota_reset_events
(provider, connection_id, window_key, window_started_at, window_resets_at,
observed_at, previous_remaining_percentage, new_remaining_percentage,
previous_used_percentage, new_used_percentage, raw_data)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
`
).run(
"claude",
connectionId,
"weekly (7d)",
"2026-06-25T23:00:00.000Z",
targetResetAt,
"2026-06-25T23:04:00.000Z",
0,
100,
100,
0,
null
);
const insertSnapshot = db.prepare(`
INSERT INTO quota_snapshots (
provider,
connection_id,
window_key,
remaining_percentage,
is_exhausted,
next_reset_at,
window_duration_ms,
raw_data,
created_at
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)
`);
insertSnapshot.run(
"claude",
connectionId,
"weekly (7d)",
100,
0,
targetResetAt,
null,
null,
"2026-06-25T23:04:00.000Z"
);
insertSnapshot.run(
"claude",
connectionId,
"weekly (7d)",
4,
0,
targetResetAt,
null,
null,
"2026-07-01T00:05:00.000Z"
);
insertSnapshot.run(
"claude",
connectionId,
"weekly (7d)",
100,
0,
targetResetAt,
null,
null,
"2026-07-01T21:41:13.293Z"
);
const start = getProviderQuotaWindowStart(
connectionId,
targetResetAt,
Date.parse("2026-07-02T00:00:00.000Z")
);
assert.deepEqual(start, {
windowStartIso: "2026-07-01T21:41:13.293Z",
source: "observed_snapshot_reset",
});
assert.equal(
getProviderQuotaWindowStartIso(
connectionId,
targetResetAt,
Date.parse("2026-07-02T00:00:00.000Z")
),
"2026-07-01T21:41:13.293Z"
);
});
test("records same-resetAt weekly resets when usage drops back to the reset floor", () => {
const connectionId = "conn-early-reset-record";
const targetResetAt = "2026-07-02T23:00:00.000Z";
const observedAt = "2026-07-01T21:41:13.293Z";
recordProviderQuotaResetEventIfChanged({
provider: "claude",
connectionId,
windowKey: "weekly (7d)",
currentResetAt: targetResetAt,
currentRemainingPercentage: 100,
previousObservation: { resetAt: targetResetAt, remainingPercentage: 4 },
observedAt,
});
assert.equal(
getProviderQuotaWindowStartIso(
connectionId,
targetResetAt,
Date.parse("2026-07-02T00:00:00.000Z")
),
observedAt
);
});
test("does not record when previous and current reset fall on the same day without a reset drop", () => {
recordProviderQuotaResetEventIfChanged({
provider: PROVIDER,
connectionId: "conn-sameday",
windowKey: "weekly",
currentResetAt: "2026-03-10T23:00:00.000Z",
currentRemainingPercentage: 69,
previousObservation: { resetAt: "2026-03-10T01:00:00.000Z", remainingPercentage: 70 },
observedAt: "2026-03-10T23:30:00.000Z",
});
assert.equal(
getProviderQuotaWindowStartIso(
"conn-sameday",
"2026-03-10T23:00:00.000Z",
Date.parse("2026-03-11T00:00:00.000Z")
),
null
);
});
test("does not record for a non-weekly (e.g. daily) window", () => {
recordProviderQuotaResetEventIfChanged({
provider: PROVIDER,
connectionId: "conn-daily",
windowKey: "daily",
currentResetAt: CUR_RESET,
currentRemainingPercentage: 100,
previousObservation: { resetAt: PREV_RESET, remainingPercentage: 5 },
observedAt: OBSERVED,
});
assert.equal(
getProviderQuotaWindowStartIso("conn-daily", CUR_RESET, Date.parse(OBSERVED) + 1000),
null
);
});