mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
121 lines
4.4 KiB
TypeScript
121 lines
4.4 KiB
TypeScript
/**
|
|
* Tests for getCircuitBreakerStore() factory routing:
|
|
* - REDIS_URL set + reachable → RedisCircuitBreakerStore
|
|
* - REDIS_URL set + unreachable → SqliteCircuitBreakerStore (fallback)
|
|
* - REDIS_URL unset → SqliteCircuitBreakerStore
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import net from "node:net";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-warmup-factory-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.NODE_ENV = "test";
|
|
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
|
|
|
|
const core = await import("../../../../src/lib/db/core.ts");
|
|
|
|
async function resetDb() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetDb();
|
|
delete process.env.REDIS_URL;
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("REDIS_URL unset → SqliteCircuitBreakerStore", async () => {
|
|
const { getCircuitBreakerStore, __resetCircuitBreakerFactory } =
|
|
await import("../../../../src/lib/warmupScheduler/circuitBreakerFactory.ts");
|
|
__resetCircuitBreakerFactory();
|
|
delete process.env.REDIS_URL;
|
|
const store = await getCircuitBreakerStore();
|
|
assert.ok(store.constructor.name.includes("Sqlite"), `got ${store.constructor.name}`);
|
|
});
|
|
|
|
/**
|
|
* A Redis that answers the handshake and then dies on the first real command.
|
|
* Enough RESP to get ioredis to `connected`, which is the state the factory
|
|
* caches -- an unreachable port only exercises the connect-time fallback, not
|
|
* the far more likely case of Redis going away after we already cached it.
|
|
*/
|
|
function startFlakyRedis(): Promise<{ port: number; close: () => void }> {
|
|
return new Promise((resolve) => {
|
|
const server = net.createServer((socket) => {
|
|
socket.on("data", (buf) => {
|
|
const cmd = buf.toString().toLowerCase();
|
|
if (cmd.includes("hgetall") || cmd.includes("hset") || cmd.includes("hget")) {
|
|
socket.destroy(); // the outage: connection drops mid-command
|
|
return;
|
|
}
|
|
if (cmd.includes("info")) {
|
|
const body = "redis_version:7.0.0\r\n";
|
|
socket.write(`$${body.length}\r\n${body}\r\n`);
|
|
return;
|
|
}
|
|
socket.write("+PONG\r\n");
|
|
});
|
|
socket.on("error", () => {});
|
|
});
|
|
server.listen(0, "127.0.0.1", () => {
|
|
const { port } = server.address() as { port: number };
|
|
resolve({ port, close: () => server.close() });
|
|
});
|
|
});
|
|
}
|
|
|
|
test("a Redis failure after caching drops the cached store instead of serving it forever", async () => {
|
|
const { getCircuitBreakerStore, __resetCircuitBreakerFactory } =
|
|
await import("../../../../src/lib/warmupScheduler/circuitBreakerFactory.ts");
|
|
const redis = await startFlakyRedis();
|
|
try {
|
|
__resetCircuitBreakerFactory();
|
|
process.env.REDIS_URL = `redis://127.0.0.1:${redis.port}`;
|
|
|
|
const first = await getCircuitBreakerStore();
|
|
assert.ok(
|
|
first.constructor.name.includes("Redis"),
|
|
`handshake should yield a Redis-backed store, got ${first.constructor.name}`
|
|
);
|
|
|
|
// The outage. The call that hits it still fails -- that run is lost.
|
|
await assert.rejects(() => first.get("conn-1"));
|
|
|
|
// The point of the fix: the next call must NOT hand back the dead client.
|
|
process.env.REDIS_URL = "redis://127.0.0.1:1"; // Redis is gone now
|
|
const second = await getCircuitBreakerStore();
|
|
assert.ok(
|
|
second.constructor.name.includes("Sqlite"),
|
|
`expected re-probe to fall back to Sqlite, got ${second.constructor.name}`
|
|
);
|
|
} finally {
|
|
delete process.env.REDIS_URL;
|
|
redis.close();
|
|
__resetCircuitBreakerFactory();
|
|
}
|
|
});
|
|
|
|
test("REDIS_URL set + unreachable → falls back to SqliteCircuitBreakerStore", async () => {
|
|
const { getCircuitBreakerStore, __resetCircuitBreakerFactory } =
|
|
await import("../../../../src/lib/warmupScheduler/circuitBreakerFactory.ts");
|
|
__resetCircuitBreakerFactory();
|
|
process.env.REDIS_URL = "redis://127.0.0.1:1"; // non-listening port → connect timeout
|
|
const store = await getCircuitBreakerStore();
|
|
assert.ok(
|
|
store.constructor.name.includes("Sqlite"),
|
|
`expected Sqlite fallback, got ${store.constructor.name}`
|
|
);
|
|
delete process.env.REDIS_URL;
|
|
});
|