mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 12:22:34 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
85 lines
2.9 KiB
TypeScript
85 lines
2.9 KiB
TypeScript
/**
|
|
* getCircuitBreakerStore() must serialise concurrent probes, so two callers
|
|
* that arrive before the cache is warm do not each build a Redis client.
|
|
*
|
|
* One ioredis case per file, and this is the whole reason: a client left behind
|
|
* by an earlier case in the same process wedges every later connect, so a second
|
|
* one here hangs rather than fails. Measured both ways round -- reordering does
|
|
* not help, only a fresh process does, and `node:test` gives each file one.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import net from "node:net";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-warmup-concurrency-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.NODE_ENV = "test";
|
|
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
|
|
|
|
const core = await import("../../../../src/lib/db/core.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
/**
|
|
* A Redis that behaves. Counts accepted connections so a test can tell one
|
|
* probe from two.
|
|
*/
|
|
function startCountingRedis(): Promise<{
|
|
port: number;
|
|
connections: () => number;
|
|
close: () => void;
|
|
}> {
|
|
return new Promise((resolve) => {
|
|
let n = 0;
|
|
const server = net.createServer((socket) => {
|
|
n += 1;
|
|
socket.on("error", () => {});
|
|
socket.on("data", (buf) => {
|
|
if (buf.toString().toLowerCase().includes("info")) {
|
|
const body = "redis_version:7.0.0\r\n";
|
|
socket.write(`$${body.length}\r\n${body}\r\n`);
|
|
return;
|
|
}
|
|
socket.write("+PONG\r\n");
|
|
});
|
|
});
|
|
server.listen(0, "127.0.0.1", () => {
|
|
const { port } = server.address() as { port: number };
|
|
resolve({ port, connections: () => n, close: () => server.close() });
|
|
});
|
|
});
|
|
}
|
|
|
|
test("concurrent callers share one probe instead of each opening a Redis client", async () => {
|
|
const { getCircuitBreakerStore, __resetCircuitBreakerFactory } =
|
|
await import("../../../../src/lib/warmupScheduler/circuitBreakerFactory.ts");
|
|
const redis = await startCountingRedis();
|
|
try {
|
|
__resetCircuitBreakerFactory();
|
|
process.env.REDIS_URL = `redis://127.0.0.1:${redis.port}`;
|
|
|
|
// Started together, on purpose: neither has awaited, so both see an empty
|
|
// cache. This is the shape a warmup cycle takes when a tick overruns and
|
|
// the next one starts while it is still going.
|
|
const [a, b] = await Promise.all([getCircuitBreakerStore(), getCircuitBreakerStore()]);
|
|
|
|
assert.strictEqual(a, b, "both callers should get the same store instance");
|
|
assert.equal(
|
|
redis.connections(),
|
|
1,
|
|
`a second probe opened a Redis client nobody can close (${redis.connections()} connections)`
|
|
);
|
|
} finally {
|
|
delete process.env.REDIS_URL;
|
|
redis.close();
|
|
__resetCircuitBreakerFactory();
|
|
}
|
|
});
|