Files
OmniRoute/tests/unit/listCapabilities-a2a.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

100 lines
4.2 KiB
TypeScript

/**
* Unit tests for the A2A list-capabilities skill.
*
* Verifies:
* - Return shape matches §3.7 contract
* - Markdown table contains all 45 categorized skill IDs (the 46th catalog
* entry, "ponytail", is category "external" and lives outside the
* api/cli/config canonical lists — #9058)
* - Coverage bounds are within declared totals
* - metadata.source === "agent-skills-catalog"
* - metadata.generatedAt is an ISO datetime string
*/
import assert from "node:assert/strict";
import { test } from "node:test";
import type { A2ATask } from "../../src/lib/a2a/taskManager.js";
import { executeListCapabilities } from "../../src/lib/a2a/skills/listCapabilities.js";
import {
API_SKILL_IDS,
CLI_SKILL_IDS,
CONFIG_SKILL_IDS,
} from "../../src/lib/agentSkills/catalog.js";
// Minimal stub — executeListCapabilities only receives the task arg but does not use it
const stubTask = {} as A2ATask;
test("executeListCapabilities returns shape matching §3.7 contract", async () => {
const result = await executeListCapabilities(stubTask);
// artifacts array with exactly 1 text artifact
assert.ok(Array.isArray(result.artifacts), "artifacts is an array");
assert.equal(result.artifacts.length, 1, "exactly 1 artifact");
assert.equal(result.artifacts[0].type, "text", "artifact type is 'text'");
assert.ok(typeof result.artifacts[0].content === "string", "artifact content is a string");
// metadata shape
const { metadata } = result;
assert.ok(metadata, "metadata exists");
assert.equal(metadata.source, "agent-skills-catalog", "metadata.source matches");
assert.equal(metadata.totalSkills, 46, "metadata.totalSkills === 46");
assert.ok(metadata.coverage, "metadata.coverage exists");
assert.ok(metadata.coverage.api, "metadata.coverage.api exists");
assert.ok(metadata.coverage.cli, "metadata.coverage.cli exists");
assert.equal(metadata.coverage.api.total, 23, "api.total === 23");
assert.equal(metadata.coverage.cli.total, 21, "cli.total === 21");
assert.equal(metadata.coverage.config.total, 1, "config.total === 1");
});
test("executeListCapabilities markdown table contains all categorized skill IDs", async () => {
const result = await executeListCapabilities(stubTask);
const content = result.artifacts[0].content;
// 45 categorized IDs; the 46th catalog entry ("ponytail") is category
// "external" and intentionally absent from these canonical lists (#9058).
const allIds = [...API_SKILL_IDS, ...CLI_SKILL_IDS, ...CONFIG_SKILL_IDS] as string[];
assert.equal(allIds.length, 45, "canonical api/cli/config lists declare 45 skill IDs");
for (const id of allIds) {
assert.ok(content.includes(id), `Markdown table missing skill ID: ${id}`);
}
});
test("metadata.coverage.api.have is within [0, 23]", async () => {
const result = await executeListCapabilities(stubTask);
const { api } = result.metadata.coverage;
assert.ok(api.have >= 0, "api.have >= 0");
assert.ok(api.have <= 23, "api.have <= 23");
});
test("metadata.coverage.cli.have is within [0, 21]", async () => {
const result = await executeListCapabilities(stubTask);
const { cli } = result.metadata.coverage;
assert.ok(cli.have >= 0, "cli.have >= 0");
assert.ok(cli.have <= 21, "cli.have <= 21");
});
test("metadata.coverage.config.have is within [0, 1]", async () => {
const result = await executeListCapabilities(stubTask);
const { config } = result.metadata.coverage;
assert.ok(config.have >= 0, "config.have >= 0");
assert.ok(config.have <= 1, "config.have <= 1");
});
test("metadata.generatedAt is a valid ISO datetime", async () => {
const result = await executeListCapabilities(stubTask);
const { generatedAt } = result.metadata;
assert.ok(typeof generatedAt === "string", "generatedAt is a string");
const parsed = new Date(generatedAt);
assert.ok(!isNaN(parsed.getTime()), `generatedAt is not a valid date: ${generatedAt}`);
assert.ok(generatedAt.includes("T"), "generatedAt contains 'T' (ISO format)");
});
test("list-capabilities is registered in A2A_SKILL_HANDLERS", async () => {
const { A2A_SKILL_HANDLERS } = await import("../../src/lib/a2a/taskExecution.js");
assert.ok(
"list-capabilities" in A2A_SKILL_HANDLERS,
"list-capabilities must be in A2A_SKILL_HANDLERS"
);
});