mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
69 lines
2.0 KiB
TypeScript
69 lines
2.0 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-mgmt-pwd-insecure-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const managementPassword = await import("../../src/lib/auth/managementPassword.ts");
|
|
|
|
function makeLogger() {
|
|
const warnings: string[] = [];
|
|
return {
|
|
warnings,
|
|
log() {},
|
|
warn: (...args: unknown[]) => {
|
|
warnings.push(args.map((a) => String(a)).join(" "));
|
|
},
|
|
};
|
|
}
|
|
|
|
test.afterEach(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("warns when bootstrapping the management password with the CHANGEME default (Seg2)", async () => {
|
|
const logger = makeLogger();
|
|
|
|
const result = await managementPassword.ensurePersistentManagementPasswordHash({
|
|
settings: {},
|
|
initialPassword: "CHANGEME",
|
|
logger,
|
|
});
|
|
|
|
// It still bootstraps (does not hard-reject — would break local dev), but it must warn loudly.
|
|
assert.equal(managementPassword.isBcryptHash(result.hash), true);
|
|
assert.equal(
|
|
logger.warnings.some((line) => line.includes("CHANGEME")),
|
|
true,
|
|
"expected a security warning mentioning the CHANGEME default"
|
|
);
|
|
});
|
|
|
|
test("does not warn when bootstrapping with a strong password", async () => {
|
|
const logger = makeLogger();
|
|
|
|
const result = await managementPassword.ensurePersistentManagementPasswordHash({
|
|
settings: {},
|
|
initialPassword: "a-strong-unique-password",
|
|
logger,
|
|
});
|
|
|
|
assert.equal(managementPassword.isBcryptHash(result.hash), true);
|
|
assert.equal(
|
|
logger.warnings.length,
|
|
0,
|
|
"did not expect any security warning for a strong password"
|
|
);
|
|
});
|