Files
OmniRoute/tests/unit/memory-engine-status.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

188 lines
7.5 KiB
TypeScript

/**
* tests/unit/memory-engine-status.test.ts
*
* Plan 21 F5 — retrieval.ts: engineStatus() function.
*
* Verifies the output shape matches MemoryEngineStatusSchema from
* src/shared/schemas/memory.ts (§3.2 D11).
*
* Cases:
* A) engineStatus() returns correct shape when vec is null (FTS5 only)
* B) keyword section: available=true, backend="FTS5"
* C) embedding section: source=null when no source configured
* D) vectorStore section: backend="none" when vec is null
* E) qdrant section: enabled=false by default, healthy=null
* F) rerank section: enabled=false by default
* G) MemoryEngineStatusSchema validates engineStatus() output
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omr-engine-status-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
process.env.VECTOR_STORE_DISABLE_VEC = "true"; // force vec → null
const core = await import("../../src/lib/db/core.ts");
const { MemoryEngineStatusSchema } = await import("../../src/shared/schemas/memory.ts");
function cleanup() {
core.resetDbInstance();
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.afterEach(() => cleanup());
test.after(() => {
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});
// ── Tests ─────────────────────────────────────────────────────────────────────
test("engineStatus(): output validates against MemoryEngineStatusSchema", async () => {
core.getDbInstance(); // trigger migrations
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
const result = MemoryEngineStatusSchema.safeParse(status);
assert.equal(
result.success,
true,
`engineStatus output failed schema validation: ${JSON.stringify((result as { error?: unknown }).error)}`
);
});
test("engineStatus(): keyword section is always available with FTS5 backend", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
assert.equal(status.keyword.available, true, "keyword.available must always be true");
assert.equal(status.keyword.backend, "FTS5", "keyword.backend must be 'FTS5'");
});
test("engineStatus(): embedding section when no source configured", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
// With default settings (no embeddingProviderModel, staticEnabled=false, transformersEnabled=false)
// → embedding.source should be null (no source available)
assert.equal(status.embedding.available, false, "embedding not available with no source");
assert.equal(status.embedding.source, null, "embedding.source should be null when unconfigured");
assert.equal(typeof status.embedding.reason, "string", "embedding.reason must be a string");
assert.ok(typeof status.embedding.cacheStats === "object", "cacheStats must be an object");
assert.equal(typeof status.embedding.cacheStats.hits, "number");
assert.equal(typeof status.embedding.cacheStats.misses, "number");
assert.equal(typeof status.embedding.cacheStats.size, "number");
});
test("engineStatus(): vectorStore section when VECTOR_STORE_DISABLE_VEC=true", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
// With VECTOR_STORE_DISABLE_VEC=true, getVectorStore() returns null
assert.equal(status.vectorStore.available, false, "vectorStore not available when vec disabled");
assert.equal(status.vectorStore.backend, "none", "vectorStore.backend must be 'none'");
assert.equal(typeof status.vectorStore.rowCount, "number", "rowCount must be a number");
assert.equal(typeof status.vectorStore.needsReindex, "number", "needsReindex must be a number");
assert.equal(typeof status.vectorStore.reason, "string", "reason must be a string");
});
test("engineStatus(): qdrant section when not configured", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
// Default: Qdrant not configured (qdrantEnabled=false in settings)
assert.equal(status.qdrant.enabled, false, "qdrant.enabled should be false by default");
// healthy and latencyMs can be null when not configured
assert.ok(
status.qdrant.healthy === null || typeof status.qdrant.healthy === "boolean",
"qdrant.healthy must be null or boolean"
);
});
test("engineStatus(): rerank section when not configured", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
// Default: rerankEnabled=false
assert.equal(status.rerank.enabled, false, "rerank.enabled should be false by default");
assert.equal(status.rerank.available, false, "rerank.available should be false when disabled");
assert.equal(typeof status.rerank.reason, "string", "rerank.reason must be a string");
});
test("engineStatus(): detail strings are English, not mixed Portuguese (#5596)", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
// Exact English values for the default (no-config, vec-disabled) state the
// reporter saw rendered in Portuguese next to English UI labels.
assert.equal(status.embedding.reason, "auto: no embedding source available");
assert.equal(status.vectorStore.reason, "sqlite-vec not available — using FTS5 only");
assert.equal(status.rerank.reason, "rerank disabled");
// Guard: no leftover Portuguese in any surfaced reason string.
const ptWords = [
"não",
"disponível",
"configurado",
"desabilitado",
"nenhuma",
"desconhecida",
"habilitado",
"degradado",
"selecionado",
];
for (const reason of [status.embedding.reason, status.vectorStore.reason, status.rerank.reason]) {
for (const w of ptWords) {
assert.ok(!reason.includes(w), `reason "${reason}" still contains Portuguese "${w}"`);
}
}
});
test("engineStatus(): no throw when called multiple times", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
await assert.doesNotReject(async () => {
await engineStatus();
await engineStatus();
}, "engineStatus must not throw when called multiple times");
});
test("engineStatus(): cacheStats shape matches schema (hits, misses, size are numbers)", async () => {
core.getDbInstance();
const { engineStatus } = await import("../../src/lib/memory/retrieval.ts");
const status = await engineStatus();
const cs = status.embedding.cacheStats;
assert.equal(typeof cs.hits, "number");
assert.equal(typeof cs.misses, "number");
assert.equal(typeof cs.size, "number");
assert.ok(cs.hits >= 0, "hits must be >= 0");
assert.ok(cs.misses >= 0, "misses must be >= 0");
assert.ok(cs.size >= 0, "size must be >= 0");
});