Files
OmniRoute/tests/unit/memory-settings.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

84 lines
2.7 KiB
TypeScript

import assert from "node:assert/strict";
import { describe, test } from "node:test";
import {
DEFAULT_MEMORY_SETTINGS,
normalizeMemorySettings,
toMemoryRetrievalConfig,
toMemorySettingsUpdates,
} from "../../src/lib/memory/settings.ts";
describe("memory settings helpers", () => {
test("normalizeMemorySettings applies defaults and clamps persisted values", () => {
const settings = normalizeMemorySettings({
memoryEnabled: "yes",
memoryMaxTokens: 20001,
memoryRetentionDays: 0,
memoryStrategy: "unsupported",
skillsEnabled: true,
});
assert.deepEqual(settings, {
enabled: DEFAULT_MEMORY_SETTINGS.enabled,
maxTokens: 16000,
retentionDays: 1,
strategy: DEFAULT_MEMORY_SETTINGS.strategy,
skillsEnabled: true,
// Plan 21 — Memory Engine Redesign extended fields (default values)
embeddingSource: DEFAULT_MEMORY_SETTINGS.embeddingSource,
embeddingProviderModel: DEFAULT_MEMORY_SETTINGS.embeddingProviderModel,
// #10010 — custom remote embedding endpoint fields (default values)
customBaseUrl: DEFAULT_MEMORY_SETTINGS.customBaseUrl,
customModelId: DEFAULT_MEMORY_SETTINGS.customModelId,
transformersEnabled: DEFAULT_MEMORY_SETTINGS.transformersEnabled,
staticEnabled: DEFAULT_MEMORY_SETTINGS.staticEnabled,
rerankEnabled: DEFAULT_MEMORY_SETTINGS.rerankEnabled,
rerankProviderModel: DEFAULT_MEMORY_SETTINGS.rerankProviderModel,
vectorStore: DEFAULT_MEMORY_SETTINGS.vectorStore,
// Phase 1-2: MemoryBackend provider pattern
primaryBackend: DEFAULT_MEMORY_SETTINGS.primaryBackend,
fallbackBackends: DEFAULT_MEMORY_SETTINGS.fallbackBackends,
backendConfigs: DEFAULT_MEMORY_SETTINGS.backendConfigs,
});
});
test("toMemorySettingsUpdates maps UI fields to persisted keys", () => {
assert.deepEqual(
toMemorySettingsUpdates({
enabled: false,
maxTokens: 4096,
retentionDays: 21,
strategy: "hybrid",
skillsEnabled: true,
}),
{
memoryEnabled: false,
memoryMaxTokens: 4096,
memoryRetentionDays: 21,
memoryStrategy: "hybrid",
skillsEnabled: true,
}
);
});
test("toMemoryRetrievalConfig disables injection when memory is off and remaps recent strategy", () => {
assert.deepEqual(
toMemoryRetrievalConfig({
enabled: true,
maxTokens: 0,
retentionDays: 10,
strategy: "recent",
skillsEnabled: false,
}),
{
enabled: false,
maxTokens: 0,
retrievalStrategy: "exact",
autoSummarize: false,
persistAcrossModels: false,
retentionDays: 10,
scope: "apiKey",
}
);
});
});