mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
134 lines
4.9 KiB
TypeScript
134 lines
4.9 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-designer-routing-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const { getModelInfo } = await import("../../src/sse/services/model.ts");
|
|
const { resolveModelOrError } = await import("../../src/sse/handlers/chatHelpers.ts");
|
|
const { resolveImageRouteModel } = await import("../../src/lib/images/imageRouteModel.ts");
|
|
const { RESERVED_PROVIDER_PREFIXES, isReservedProviderPrefix } =
|
|
await import("../../src/shared/constants/reservedProviderPrefixes.ts");
|
|
const { createProviderNodeSchema, updateProviderNodeSchema } =
|
|
await import("../../src/shared/validation/schemas.ts");
|
|
|
|
async function resetStorage(): Promise<void> {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function createCompatibleNode(id: string, prefix: string): Promise<void> {
|
|
await providersDb.createProviderNode({
|
|
id,
|
|
type: "openai-compatible",
|
|
name: `${prefix}-test-node`,
|
|
prefix,
|
|
apiType: "chat",
|
|
baseUrl: "https://compatible.invalid/v1",
|
|
chatPath: "/v1/chat/completions",
|
|
modelsPath: "/v1/models",
|
|
});
|
|
}
|
|
|
|
function assertRetiredError(error: unknown): boolean {
|
|
assert.ok(error instanceof Error);
|
|
assert.equal((error as Error & { status?: number }).status, 410);
|
|
assert.equal(error.message, "Provider has been retired from OmniRoute runtime.");
|
|
return true;
|
|
}
|
|
|
|
test.beforeEach(resetStorage);
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("retired Designer IDs remain reserved after leaving the live provider registry", () => {
|
|
for (const providerId of [
|
|
"microsoft-designer-web",
|
|
"msdesigner",
|
|
" MICROSOFT-DESIGNER-WEB\t",
|
|
"\nMsDesigner ",
|
|
]) {
|
|
assert.equal(isReservedProviderPrefix(providerId), true, providerId);
|
|
}
|
|
assert.equal(RESERVED_PROVIDER_PREFIXES.has("microsoft-designer-web"), true);
|
|
assert.equal(RESERVED_PROVIDER_PREFIXES.has("msdesigner"), true);
|
|
assert.equal(isReservedProviderPrefix("microsoft-designer-web-preview"), false);
|
|
});
|
|
|
|
test("provider-node schemas reject exact retired prefixes but preserve similar IDs", () => {
|
|
for (const prefix of ["microsoft-designer-web", "MSDESIGNER"]) {
|
|
const create = createProviderNodeSchema.safeParse({
|
|
name: "Retired collision",
|
|
prefix,
|
|
apiType: "chat",
|
|
baseUrl: "https://compatible.invalid/v1",
|
|
});
|
|
const update = updateProviderNodeSchema.safeParse({
|
|
name: "Retired collision",
|
|
prefix,
|
|
baseUrl: "https://compatible.invalid/v1",
|
|
});
|
|
assert.equal(create.success, false, prefix);
|
|
assert.equal(update.success, false, prefix);
|
|
}
|
|
|
|
assert.equal(
|
|
createProviderNodeSchema.safeParse({
|
|
name: "Similar control",
|
|
prefix: "microsoft-designer-web-preview",
|
|
apiType: "chat",
|
|
baseUrl: "https://compatible.invalid/v1",
|
|
}).success,
|
|
true
|
|
);
|
|
});
|
|
|
|
test("compatible-node remapping cannot erase a retired Designer prefix", async () => {
|
|
await createCompatibleNode("openai-compatible-chat-designer-retired", "microsoft-designer-web");
|
|
|
|
await assert.rejects(() => getModelInfo("microsoft-designer-web/gpt-4o"), assertRetiredError);
|
|
|
|
const resolved = await resolveModelOrError("microsoft-designer-web/gpt-4o", {
|
|
messages: [{ role: "user", content: "test" }],
|
|
});
|
|
assert.ok(resolved.error instanceof Response);
|
|
assert.equal(resolved.error.status, 410);
|
|
assert.deepEqual(await resolved.error.json(), {
|
|
error: {
|
|
message: "Provider has been retired from OmniRoute runtime.",
|
|
type: "invalid_request_error",
|
|
code: "model_shutdown",
|
|
},
|
|
});
|
|
});
|
|
|
|
test("stripModelPrefix cannot erase the retired Designer alias", async () => {
|
|
await settingsDb.updateSettings({ stripModelPrefix: true });
|
|
|
|
await assert.rejects(() => getModelInfo(" MSDESIGNER /gpt-4o"), assertRetiredError);
|
|
});
|
|
|
|
test("image prefix resolution refuses retired nodes but preserves a similar control", async () => {
|
|
await createCompatibleNode("openai-compatible-images-designer-retired", "msdesigner");
|
|
await createCompatibleNode(
|
|
"openai-compatible-images-designer-preview",
|
|
"microsoft-designer-web-preview"
|
|
);
|
|
|
|
await assert.rejects(() => resolveImageRouteModel("msdesigner/dall-e-3"), assertRetiredError);
|
|
assert.equal(
|
|
await resolveImageRouteModel("microsoft-designer-web-preview/control-image"),
|
|
"openai-compatible-images-designer-preview/control-image"
|
|
);
|
|
});
|