mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
75 lines
2.7 KiB
TypeScript
75 lines
2.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { decideCertMigration } from "../../src/mitm/cert/migration.ts";
|
|
|
|
// #6684: migration gate between the legacy single self-signed leaf and the
|
|
// new persisted root-CA model. A trusted MITM CA that can sign a cert for
|
|
// ANY host is materially more powerful than the old fixed-SAN leaf, so an
|
|
// already-trusted install must never be silently upgraded.
|
|
|
|
function tmpCertDir(): string {
|
|
return fs.mkdtempSync(path.join(os.tmpdir(), "mitm-migration-test-"));
|
|
}
|
|
|
|
function touch(filePath: string): void {
|
|
fs.writeFileSync(filePath, "test");
|
|
}
|
|
|
|
test("decideCertMigration: existing legacy leaf, no CA pair, flag off → stay on legacy leaf", () => {
|
|
const certDir = tmpCertDir();
|
|
try {
|
|
touch(path.join(certDir, "server.crt"));
|
|
touch(path.join(certDir, "server.key"));
|
|
assert.equal(decideCertMigration(certDir, false), "use-legacy-leaf");
|
|
} finally {
|
|
fs.rmSync(certDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("decideCertMigration: no legacy leaf and no CA pair (fresh install) → use root CA", () => {
|
|
const certDir = tmpCertDir();
|
|
try {
|
|
assert.equal(decideCertMigration(certDir, false), "use-root-ca");
|
|
} finally {
|
|
fs.rmSync(certDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("decideCertMigration: legacy leaf present but explicit opt-in flag on → use root CA", () => {
|
|
const certDir = tmpCertDir();
|
|
try {
|
|
touch(path.join(certDir, "server.crt"));
|
|
touch(path.join(certDir, "server.key"));
|
|
assert.equal(decideCertMigration(certDir, true), "use-root-ca");
|
|
} finally {
|
|
fs.rmSync(certDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("decideCertMigration: CA pair already persisted → use root CA even without the flag", () => {
|
|
const certDir = tmpCertDir();
|
|
try {
|
|
touch(path.join(certDir, "server.crt"));
|
|
touch(path.join(certDir, "server.key"));
|
|
touch(path.join(certDir, "ca.crt"));
|
|
touch(path.join(certDir, "ca.key"));
|
|
assert.equal(decideCertMigration(certDir, false), "use-root-ca");
|
|
} finally {
|
|
fs.rmSync(certDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("decideCertMigration: partial legacy pair (only server.crt) is treated as no legacy install", () => {
|
|
const certDir = tmpCertDir();
|
|
try {
|
|
touch(path.join(certDir, "server.crt"));
|
|
assert.equal(decideCertMigration(certDir, false), "use-root-ca");
|
|
} finally {
|
|
fs.rmSync(certDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|