mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
88 lines
3.6 KiB
TypeScript
88 lines
3.6 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
|
|
import { makeManagementSessionRequest } from "../helpers/managementSession.ts";
|
|
import { AUTHZ_HEADER_PEER_LOCALITY } from "../../src/server/authz/headers.ts";
|
|
|
|
const dataDirectory = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-video-runtime-route-"));
|
|
const originalDataDirectory = process.env.DATA_DIR;
|
|
const originalInitialPassword = process.env.INITIAL_PASSWORD;
|
|
const originalJwtSecret = process.env.JWT_SECRET;
|
|
process.env.DATA_DIR = dataDirectory;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const settings = await import("../../src/lib/db/settings.ts");
|
|
const route = await import("../../src/app/api/modality-bridge/video/runtime/route.ts");
|
|
|
|
async function withLocality(request: Request, locality: "loopback" | "lan"): Promise<Request> {
|
|
const headers = new Headers(request.headers);
|
|
headers.set(AUTHZ_HEADER_PEER_LOCALITY, locality);
|
|
return new Request(request, { headers });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(dataDirectory, { force: true, recursive: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(dataDirectory, { recursive: true });
|
|
process.env.INITIAL_PASSWORD = "video-runtime-test-password";
|
|
await settings.updateSettings({ requireLogin: true, password: "" });
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(dataDirectory, { force: true, recursive: true, maxRetries: 5, retryDelay: 100 });
|
|
if (originalDataDirectory === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = originalDataDirectory;
|
|
if (originalInitialPassword === undefined) delete process.env.INITIAL_PASSWORD;
|
|
else process.env.INITIAL_PASSWORD = originalInitialPassword;
|
|
if (originalJwtSecret === undefined) delete process.env.JWT_SECRET;
|
|
else process.env.JWT_SECRET = originalJwtSecret;
|
|
});
|
|
|
|
test("Video Bridge runtime status requires management auth and returns only sanitized fields", async () => {
|
|
const url = "http://localhost/api/modality-bridge/video/runtime";
|
|
const unauthenticated = await route.GET(await withLocality(new Request(url), "loopback"));
|
|
assert.equal(unauthenticated.status, 401);
|
|
|
|
const authenticated = await route.GET(
|
|
await withLocality(await makeManagementSessionRequest(url), "loopback")
|
|
);
|
|
assert.equal(authenticated.status, 200);
|
|
assert.equal(authenticated.headers.get("cache-control"), "no-store");
|
|
const body = (await authenticated.json()) as Record<string, unknown>;
|
|
assert.equal(typeof body.available, "boolean");
|
|
assert.deepEqual(
|
|
Object.keys(body).sort(),
|
|
body.available
|
|
? ["available", "ffmpegVersion", "ffprobeVersion"]
|
|
: ["available", "ffmpegVersion", "ffprobeVersion", "reason"]
|
|
);
|
|
assert.equal(JSON.stringify(body).includes("/private/"), false);
|
|
assert.equal(JSON.stringify(body).includes("stderr"), false);
|
|
});
|
|
|
|
test("Video Bridge runtime rejects private-LAN callers before auth or subprocess probing", async () => {
|
|
const url = "http://localhost/api/modality-bridge/video/runtime";
|
|
let probes = 0;
|
|
const probe = async () => {
|
|
probes += 1;
|
|
return { available: true, ffmpegVersion: "test", ffprobeVersion: "test" };
|
|
};
|
|
|
|
const unauthenticated = await route.handleVideoRuntimeStatus(
|
|
await withLocality(new Request(url), "lan"),
|
|
{ probe }
|
|
);
|
|
const authenticated = await route.handleVideoRuntimeStatus(
|
|
await withLocality(await makeManagementSessionRequest(url), "lan"),
|
|
{ probe }
|
|
);
|
|
|
|
assert.equal(unauthenticated.status, 403);
|
|
assert.equal(authenticated.status, 403);
|
|
assert.equal(probes, 0);
|
|
});
|