mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
232 lines
6.9 KiB
TypeScript
232 lines
6.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-model-combo-db-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const combosDb = await import("../../src/lib/db/combos.ts");
|
|
const mappingsDb = await import("../../src/lib/db/modelComboMappings.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
async function createCombo(name, model, overrides = {}) {
|
|
return combosDb.createCombo({
|
|
name,
|
|
models: [{ provider: "openai", model }],
|
|
strategy: "priority",
|
|
config: { temperature: 0 },
|
|
...overrides,
|
|
});
|
|
}
|
|
|
|
test("model combo mappings CRUD joins combo names and preserves ordering", async () => {
|
|
const comboA = await createCombo("alpha", "gpt-4o");
|
|
const comboB = await createCombo("beta", "claude-sonnet-4");
|
|
|
|
const first = await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-*",
|
|
comboId: comboA.id,
|
|
priority: 20,
|
|
description: "primary",
|
|
});
|
|
const second = await mappingsDb.createModelComboMapping({
|
|
pattern: "claude-*",
|
|
comboId: comboB.id,
|
|
priority: 20,
|
|
enabled: false,
|
|
});
|
|
|
|
const { items: all } = await mappingsDb.getModelComboMappings();
|
|
|
|
assert.equal(all.length, 2);
|
|
assert.equal(all[0].id, first.id);
|
|
assert.equal(all[0].comboName, "alpha");
|
|
assert.equal(all[0].enabled, true);
|
|
assert.equal(all[0].description, "primary");
|
|
assert.equal(all[1].id, second.id);
|
|
assert.equal(all[1].comboName, "beta");
|
|
assert.equal(all[1].enabled, false);
|
|
|
|
const fetched = await mappingsDb.getModelComboMappingById(first.id);
|
|
assert.equal(fetched?.pattern, "gpt-*");
|
|
assert.equal(fetched?.comboName, "alpha");
|
|
assert.equal(fetched?.priority, 20);
|
|
});
|
|
|
|
test("updateModelComboMapping merges fields and returns the refreshed mapping", async () => {
|
|
const comboA = await createCombo("alpha", "gpt-4o");
|
|
const comboB = await createCombo("beta", "claude-sonnet-4");
|
|
|
|
const created = await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-*",
|
|
comboId: comboA.id,
|
|
priority: 1,
|
|
});
|
|
|
|
await new Promise((r) => setTimeout(r, 10));
|
|
|
|
const updated = await mappingsDb.updateModelComboMapping(created.id, {
|
|
pattern: "claude-*",
|
|
comboId: comboB.id,
|
|
priority: 99,
|
|
enabled: false,
|
|
description: "rerouted",
|
|
});
|
|
|
|
assert.ok(updated);
|
|
assert.equal(updated?.id, created.id);
|
|
assert.equal(updated?.pattern, "claude-*");
|
|
assert.equal(updated?.comboId, comboB.id);
|
|
assert.equal(updated?.comboName, "beta");
|
|
assert.equal(updated?.priority, 99);
|
|
assert.equal(updated?.enabled, false);
|
|
assert.equal(updated?.description, "rerouted");
|
|
assert.notEqual(updated?.updatedAt, created.updatedAt);
|
|
});
|
|
|
|
test("updateModelComboMapping returns null for unknown ids", async () => {
|
|
const updated = await mappingsDb.updateModelComboMapping("missing-id", {
|
|
pattern: "gpt-*",
|
|
});
|
|
|
|
assert.equal(updated, null);
|
|
});
|
|
|
|
test("deleteModelComboMapping reports whether a row existed", async () => {
|
|
const combo = await createCombo("alpha", "gpt-4o");
|
|
const created = await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-*",
|
|
comboId: combo.id,
|
|
});
|
|
|
|
assert.equal(await mappingsDb.deleteModelComboMapping(created.id), true);
|
|
assert.equal(await mappingsDb.deleteModelComboMapping(created.id), false);
|
|
assert.equal(await mappingsDb.getModelComboMappingById(created.id), null);
|
|
});
|
|
|
|
test("resolveComboForModel returns the highest-priority enabled combo", async () => {
|
|
const fallbackCombo = await createCombo("fallback", "gpt-4o-mini");
|
|
const priorityCombo = await createCombo("priority", "gpt-4o");
|
|
const disabledCombo = await createCombo("disabled", "gpt-4.1");
|
|
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "*",
|
|
comboId: fallbackCombo.id,
|
|
priority: 1,
|
|
});
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-4*",
|
|
comboId: priorityCombo.id,
|
|
priority: 10,
|
|
});
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-*",
|
|
comboId: disabledCombo.id,
|
|
priority: 100,
|
|
enabled: false,
|
|
});
|
|
|
|
const resolved = await mappingsDb.resolveComboForModel("gpt-4o");
|
|
|
|
assert.ok(resolved);
|
|
assert.equal(resolved.name, "priority");
|
|
assert.deepEqual(resolved.models, [
|
|
{
|
|
id: "priority-model-1-openai-gpt-4o",
|
|
kind: "model",
|
|
providerId: "openai",
|
|
model: "openai/gpt-4o",
|
|
weight: 0,
|
|
},
|
|
]);
|
|
});
|
|
|
|
test("resolveComboForModel skips corrupted combo payloads and keeps scanning", async () => {
|
|
const brokenCombo = await createCombo("broken", "gpt-4o");
|
|
const fallbackCombo = await createCombo("fallback", "gpt-4o-mini");
|
|
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-4*",
|
|
comboId: brokenCombo.id,
|
|
priority: 10,
|
|
});
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-*",
|
|
comboId: fallbackCombo.id,
|
|
priority: 1,
|
|
});
|
|
|
|
const db = core.getDbInstance();
|
|
db.prepare("UPDATE combos SET data = ? WHERE id = ?").run("{not-json", brokenCombo.id);
|
|
|
|
const resolved = await mappingsDb.resolveComboForModel("gpt-4o");
|
|
|
|
assert.ok(resolved);
|
|
assert.equal(resolved.name, "fallback");
|
|
});
|
|
|
|
test("resolveComboForModel skips inactive mapped combos and keeps scanning", async () => {
|
|
const inactiveCombo = await createCombo("inactive", "gpt-4o", { isActive: false });
|
|
const fallbackCombo = await createCombo("fallback", "gpt-4o-mini");
|
|
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-4*",
|
|
comboId: inactiveCombo.id,
|
|
priority: 10,
|
|
});
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-*",
|
|
comboId: fallbackCombo.id,
|
|
priority: 1,
|
|
});
|
|
|
|
const resolved = await mappingsDb.resolveComboForModel("gpt-4o");
|
|
|
|
assert.ok(resolved);
|
|
assert.equal(resolved.name, "fallback");
|
|
});
|
|
|
|
test("resolveComboForModel returns null when only matching combo is inactive", async () => {
|
|
const inactiveCombo = await createCombo("inactive", "gpt-4o", { isActive: false });
|
|
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "gpt-4*",
|
|
comboId: inactiveCombo.id,
|
|
});
|
|
|
|
const resolved = await mappingsDb.resolveComboForModel("gpt-4o");
|
|
|
|
assert.equal(resolved, null);
|
|
});
|
|
|
|
test("resolveComboForModel returns null when nothing matches", async () => {
|
|
const combo = await createCombo("alpha", "gpt-4o");
|
|
|
|
await mappingsDb.createModelComboMapping({
|
|
pattern: "claude-*",
|
|
comboId: combo.id,
|
|
enabled: false,
|
|
});
|
|
|
|
const resolved = await mappingsDb.resolveComboForModel("gpt-4o");
|
|
|
|
assert.equal(resolved, null);
|
|
});
|