Files
OmniRoute/tests/unit/model-context-override-readpath.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

112 lines
4.3 KiB
TypeScript

import { describe, it, beforeEach, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// Feature 5004 — getModelContextLimit reads the override before the static catalog.
const moduleDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-mco-readpath-"));
process.env.DATA_DIR = moduleDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const mco = await import("../../src/lib/db/modelContextOverrides.ts");
const caps = await import("../../src/lib/modelCapabilities.ts");
beforeEach(() => {
coreDb.resetDbInstance();
fs.rmSync(moduleDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(moduleDataDir, { recursive: true });
coreDb.getDbInstance();
});
after(() => {
coreDb.resetDbInstance();
fs.rmSync(moduleDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
describe("getModelContextLimit override precedence (5004)", () => {
it("an override wins over the catalog, and removing it falls back to the catalog", () => {
// Read the override-free catalog value dynamically (non-brittle for any model).
const catalog = caps.getResolvedModelCapabilities({
provider: "openai",
model: "gpt-4o",
}).contextWindow;
const distinct = (catalog ?? 0) + 12345;
mco.setModelContextOverride("openai", "gpt-4o", distinct);
assert.equal(caps.getModelContextLimit("openai", "gpt-4o"), distinct, "override must win");
mco.removeModelContextOverride("openai", "gpt-4o");
assert.equal(
caps.getModelContextLimit("openai", "gpt-4o"),
catalog,
"absence must fall back to the catalog"
);
});
it("an override surfaces a window for a model the catalog does not know", () => {
assert.equal(caps.getModelContextLimit("custom-local", "my-7b-128k"), null);
mco.setModelContextOverride("custom-local", "my-7b-128k", 131072);
assert.equal(caps.getModelContextLimit("custom-local", "my-7b-128k"), 131072);
});
it("resolves exact raw aliases after canonical rows, without effort inheritance", () => {
const provider = "github";
const rawAlias = "claude-opus-4.5";
const canonical = "claude-opus-4-5-20251101";
assert.equal(mco.setModelContextOverride(provider, rawAlias, 333333), true);
assert.equal(
caps.getResolvedModelCapabilities({ provider, model: rawAlias }).contextWindow,
333333,
"an exact raw alias override must be effective"
);
assert.notEqual(
caps.getResolvedModelCapabilities(
{ provider, model: rawAlias },
{ persistedOverrides: false }
).contextWindow,
333333,
"override-free resolution must not read the raw alias row"
);
assert.equal(mco.setModelContextOverride(provider, canonical, 444444), true);
assert.equal(
caps.getResolvedModelCapabilities({ provider, model: rawAlias }).contextWindow,
444444,
"the canonical row must win over the exact raw alias row"
);
assert.notEqual(
caps.getResolvedModelCapabilities({ provider, model: `${rawAlias}-high` }).contextWindow,
444444,
"an exact alias override must not inherit to an effort variant"
);
});
it("default getResolvedModelCapabilities reflects the override; persistedOverrides:false returns the catalog", () => {
mco.setModelContextOverride("openai", "gpt-4o", 999999, "auto:discovery");
// Default resolution is the effective runtime view: the persisted context
// override wins over the catalog.
const effective = caps.getResolvedModelCapabilities({
provider: "openai",
model: "gpt-4o",
}).contextWindow;
assert.equal(effective, 999999, "default resolution must reflect the persisted override");
// The override-free catalog view (used by the reconciler) excludes the override.
const catalog = caps.getResolvedModelCapabilities(
{ provider: "openai", model: "gpt-4o" },
{ persistedOverrides: false }
).contextWindow;
assert.notEqual(catalog, 999999, "persistedOverrides:false must return the catalog value");
// getModelContextLimit always follows the effective override.
assert.equal(
caps.getModelContextLimit("openai", "gpt-4o"),
999999,
"getModelContextLimit reflects the override"
);
});
});