Files
OmniRoute/tests/unit/model-lockout-max-cooldown.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

223 lines
5.9 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omr-lockout-max-cooldown-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-lockout-max-cooldown-secret";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
const auth = await import("../../src/sse/services/auth.ts");
const { handleComboChat } = await import("../../open-sse/services/combo.ts");
const { recordModelLockoutFailure, getModelLockoutInfo, clearAllModelLockouts } =
await import("../../open-sse/services/accountFallback.ts");
function createLog() {
return {
info: () => {},
warn: () => {},
error: () => {},
debug: () => {},
};
}
function errorResponse(status: number, message: string = `Error ${status}`) {
return new Response(JSON.stringify({ error: { message } }), {
status,
headers: { "content-type": "application/json" },
});
}
async function seedConnection(provider: string, overrides: any = {}): Promise<any> {
return providersDb.createProviderConnection({
provider,
authType: "apikey",
name: overrides.name || `${provider}-${Math.random().toString(16).slice(2, 8)}`,
apiKey: overrides.apiKey || `sk-test-${Math.random().toString(16).slice(2, 8)}`,
isActive: true,
testStatus: "active",
rateLimitedUntil: null,
backoffLevel: overrides.backoffLevel || 0,
providerSpecificData: overrides.providerSpecificData || {},
});
}
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
clearAllModelLockouts();
await resetStorage();
});
test.after(async () => {
clearAllModelLockouts();
try {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {}
});
test("recordModelLockoutFailure honors maxCooldownMs option parameter", () => {
const provider = "openai";
const connectionId = "conn-s1";
const model = "gpt-4";
const first = recordModelLockoutFailure(
provider,
connectionId,
model,
"rate_limited",
429,
500,
null,
{
maxCooldownMs: 1500,
}
);
assert.equal(first.cooldownMs, 500);
const originalNow = Date.now;
try {
let fakeNow = Date.now();
Date.now = () => fakeNow;
fakeNow += 600;
const second = recordModelLockoutFailure(
provider,
connectionId,
model,
"rate_limited",
429,
500,
null,
{
maxCooldownMs: 1500,
}
);
assert.equal(second.cooldownMs, 1000);
fakeNow += 1100;
const third = recordModelLockoutFailure(
provider,
connectionId,
model,
"rate_limited",
429,
500,
null,
{
maxCooldownMs: 1500,
}
);
assert.equal(third.cooldownMs, 1500);
} finally {
Date.now = originalNow;
}
});
test("handleComboChat quality failure model lockout honors maxCooldownMs settings", async () => {
const provider = "openai";
const model = "gpt-4";
const customSettings = {
modelLockout: {
enabled: true,
errorCodes: [502],
baseCooldownMs: 3000,
maxCooldownMs: 5000,
maxBackoffSteps: 10,
useExponentialBackoff: true,
},
};
const logs = createLog();
const executeComboWithFailure = async () => {
return handleComboChat({
body: {},
combo: {
name: "test-combo",
strategy: "priority",
models: [`${provider}/${model}`],
config: { maxRetries: 0, retryDelayMs: 0, fallbackDelayMs: 0 },
},
handleSingleModel: async () => {
return errorResponse(502);
},
isModelAvailable: async () => true,
log: logs as any,
settings: customSettings,
allCombos: null,
});
};
const originalNow = Date.now;
try {
let fakeNow = Date.now();
Date.now = () => fakeNow;
await executeComboWithFailure();
let info = getModelLockoutInfo(provider, "", model);
assert.ok(info && info.remainingMs <= 3000);
fakeNow += 3100;
await executeComboWithFailure();
info = getModelLockoutInfo(provider, "", model);
assert.ok(info);
assert.ok(
info!.remainingMs <= 5000,
`Expected remainingMs to be capped at 5000, but got ${info!.remainingMs}`
);
} finally {
Date.now = originalNow;
}
});
test("markAccountUnavailable local 404 lockout honors maxCooldownMs settings", async () => {
const provider = "openai";
const model = "local-gpt-4";
const connection = (await seedConnection(provider, {
providerSpecificData: { baseUrl: "http://127.0.0.1:8080/v1" },
})) as any;
await settingsDb.updateSettings({
modelLockout: {
enabled: true,
errorCodes: [404],
baseCooldownMs: 3000,
maxCooldownMs: 5000,
maxBackoffSteps: 10,
useExponentialBackoff: true,
},
});
const originalNow = Date.now;
try {
let fakeNow = Date.now();
Date.now = () => fakeNow;
await auth.markAccountUnavailable(connection.id as string, 404, "not found", provider, model);
let info = getModelLockoutInfo(provider, connection.id as string, model);
assert.ok(info && info.remainingMs <= 3000);
fakeNow += 3100;
await providersDb.updateProviderConnection(connection.id as string, { rateLimitedUntil: null });
await auth.markAccountUnavailable(connection.id as string, 404, "not found", provider, model);
info = getModelLockoutInfo(provider, connection.id as string, model);
assert.ok(info);
assert.ok(
info!.remainingMs <= 5000,
`Expected remainingMs to be capped at 5000, but got ${info!.remainingMs}`
);
} finally {
Date.now = originalNow;
}
});