mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 05:12:16 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
76 lines
3.0 KiB
TypeScript
76 lines
3.0 KiB
TypeScript
/**
|
|
* #5192 — Blocking the "Auto (Zero-Config)" provider in Security settings must
|
|
* remove the built-in `auto/*` combos from the `/v1/models` listing.
|
|
*
|
|
* The catalog advertises the built-in `auto/*` combos (#4164 / #4235) at the top
|
|
* of `/v1/models`, but that injection loop ignored `settings.blockedProviders`,
|
|
* so checking "Auto (Zero-Config)" in Security → Blocked Providers had no effect:
|
|
* the model picker still showed `auto/*` entries. Blocking the system provider id
|
|
* `auto` (its id and alias are both "auto") must suppress the whole `auto/*` block.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-block-auto-5192-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "block-auto-5192-test-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
const v1ModelsCatalog = await import("../../src/app/api/v1/models/catalog.ts");
|
|
|
|
type ModelsResponseBody = { data: Array<{ id: string }> };
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
apiKeysDb.resetApiKeyState();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function getIds(): Promise<Set<string>> {
|
|
const response = await v1ModelsCatalog.getUnifiedModelsResponse(
|
|
new Request("http://localhost/api/v1/models")
|
|
);
|
|
const body = (await response.json()) as ModelsResponseBody;
|
|
return new Set(body.data.map((item) => item.id));
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
apiKeysDb.resetApiKeyState();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#5192 baseline: built-in auto/* combos are listed when Auto is not blocked", async () => {
|
|
const ids = await getIds();
|
|
assert.ok(ids.has("auto/best-coding"), "auto/best-coding should be listed by default");
|
|
assert.ok(ids.has("auto/coding"), "auto/coding should be listed by default");
|
|
});
|
|
|
|
test("#5192: blocking the Auto (Zero-Config) provider removes all auto/* combos", async () => {
|
|
await settingsDb.updateSettings({ blockedProviders: ["auto"] });
|
|
const ids = await getIds();
|
|
const leaked = [...ids].filter((id) => id === "auto" || id.startsWith("auto/"));
|
|
assert.deepEqual(
|
|
leaked,
|
|
[],
|
|
`no auto/* combos should be listed when Auto is blocked, but got: ${leaked.join(", ")}`
|
|
);
|
|
});
|
|
|
|
test("#5192: blocking via the 'auto' alias is honored too", async () => {
|
|
// id and alias are both "auto"; the Security UI stores whichever the user clicked.
|
|
await settingsDb.updateSettings({ blockedProviders: ["auto"] });
|
|
const ids = await getIds();
|
|
assert.equal(ids.has("auto/smart"), false, "auto/smart must be absent when Auto is blocked");
|
|
});
|