Files
OmniRoute/tests/unit/models-catalog-custom-node-prefix.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

110 lines
3.7 KiB
TypeScript

import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import test from "node:test";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-custom-node-prefix-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const aliasesDb = await import("../../src/lib/db/models/aliases.ts");
const core = await import("../../src/lib/db/core.ts");
const modelsDb = await import("../../src/lib/db/models.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const modelsCatalog = await import("../../src/app/api/v1/models/catalog.ts");
const modelsRoute = await import("../../src/app/api/v1/models/route.ts");
const NODE_ID = "openai-compatible-chat-550e8400-e29b-41d4-a716-446655440000";
const PREFIX = "infrex";
const EXPECTED_IDS = [
`${PREFIX}/synced-model`,
`${PREFIX}/custom-model`,
`${PREFIX}/alias-backed-model`,
];
async function resetStorage(): Promise<void> {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
modelsCatalog.__resetCatalogBuilderRunsForTest();
}
async function seedCustomNode(): Promise<void> {
await providersDb.createProviderNode({
id: NODE_ID,
type: "openai-compatible",
name: "Infrex",
prefix: PREFIX,
baseUrl: "https://proxy.example.com",
chatPath: "/v1/chat/completions",
modelsPath: "/v1/models",
});
const connection = await providersDb.createProviderConnection({
provider: NODE_ID,
authType: "apikey",
name: "infrex-primary",
apiKey: "test-key",
isActive: true,
testStatus: "active",
providerSpecificData: {
baseUrl: "https://proxy.example.com",
chatPath: "/v1/chat/completions",
modelsPath: "/v1/models",
},
});
await modelsDb.replaceSyncedAvailableModelsForConnection(
NODE_ID,
(connection as { id: string }).id,
[{ id: "synced-model", source: "imported", supportedEndpoints: ["chat"] }]
);
await modelsDb.addCustomModel(NODE_ID, "custom-model", "Custom Model");
await aliasesDb.setModelAlias("alias-backed-model", `${NODE_ID}/alias-backed-model`);
}
async function getCatalogIds(mode: "alias" | "canonical" | "dual"): Promise<string[]> {
modelsCatalog.__resetCatalogBuilderRunsForTest();
const response = await modelsRoute.GET(
new Request(`http://localhost/api/v1/models?prefix=${mode}`)
);
assert.equal(response.status, 200);
const body = (await response.json()) as { data: Array<{ id: string }> };
return body.data.map((model) => model.id);
}
function assertCustomNodeModels(ids: string[]): void {
const actualCustomNodeIds = ids.filter((id) => EXPECTED_IDS.includes(id)).sort();
assert.deepEqual(
actualCustomNodeIds,
[...EXPECTED_IDS].sort(),
`expected each custom node source exactly once in ${JSON.stringify(ids)}`
);
assert.equal(
ids.some((id) => id.startsWith(`${NODE_ID}/`)),
false,
"catalog must not expose the internal provider node id"
);
}
test.beforeEach(async () => {
await resetStorage();
await seedCustomNode();
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("alias mode exposes every custom node model under its configured prefix", async () => {
assertCustomNodeModels(await getCatalogIds("alias"));
});
test("canonical mode keeps custom node models under their configured prefix", async () => {
assertCustomNodeModels(await getCatalogIds("canonical"));
});
test("dual mode exposes each custom node model once under its configured prefix", async () => {
assertCustomNodeModels(await getCatalogIds("dual"));
});