mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
123 lines
4.5 KiB
TypeScript
123 lines
4.5 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(
|
|
path.join(os.tmpdir(), "omniroute-model-catalog-static-synced-suppression-")
|
|
);
|
|
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET =
|
|
process.env.API_KEY_SECRET || "model-catalog-static-synced-suppression-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const modelsDb = await import("../../src/lib/db/models.ts");
|
|
const catalog = await import("../../src/app/api/v1/models/catalog.ts");
|
|
const { REGISTRY } = await import("@omniroute/open-sse/config/providerRegistry");
|
|
|
|
const LIVE_MODEL = "google/gemma-4-31b-it";
|
|
|
|
function getStaticModel(provider: string) {
|
|
const model = REGISTRY[provider]?.models?.[0];
|
|
assert.ok(model, `${provider} must define a static registry model for this regression test`);
|
|
return model;
|
|
}
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(path.join(TEST_DATA_DIR, "logs/application"), { recursive: true });
|
|
catalog.__resetCatalogBuilderRunsForTest();
|
|
}
|
|
|
|
async function seedConnection(provider: string, name: string) {
|
|
return providersDb.createProviderConnection({
|
|
provider,
|
|
authType: "apikey",
|
|
name,
|
|
apiKey: "test-api-key",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
});
|
|
}
|
|
|
|
async function getCatalogIds(): Promise<Set<string>> {
|
|
const response = await catalog.getUnifiedModelsResponse(
|
|
new Request("http://localhost/api/v1/models")
|
|
);
|
|
const body = (await response.json()) as { data: Array<{ id: string }> };
|
|
|
|
assert.equal(response.status, 200);
|
|
return new Set(body.data.map((model) => model.id));
|
|
}
|
|
|
|
test.beforeEach(resetStorage);
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("active authoritative live catalog suppresses stale static registry models", async () => {
|
|
const staticNvidiaModel = getStaticModel("nvidia").id;
|
|
const connection = await seedConnection("nvidia", "nvidia-static-synced-suppression");
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection("nvidia", connection.id as string, [
|
|
{ id: LIVE_MODEL, name: "Gemma 4 31B", source: "imported" },
|
|
]);
|
|
|
|
const ids = await getCatalogIds();
|
|
|
|
assert.equal(ids.has(`nvidia/${LIVE_MODEL}`), true);
|
|
assert.equal(ids.has(`nvidia/${staticNvidiaModel}`), false);
|
|
});
|
|
|
|
test("static registry remains fallback when active connection has no live catalog", async () => {
|
|
const staticNvidiaModel = getStaticModel("nvidia").id;
|
|
await seedConnection("nvidia", "nvidia-fallback-static");
|
|
|
|
const ids = await getCatalogIds();
|
|
|
|
assert.equal(ids.has(`nvidia/${staticNvidiaModel}`), true);
|
|
});
|
|
|
|
test("authoritative live catalog suppresses static effort-tier variants on sync", async () => {
|
|
const connection = await seedConnection("glm", "glm-authoritative-effort-suppression");
|
|
const glmStaticModel = REGISTRY.glm?.models?.find(
|
|
(model) =>
|
|
Array.isArray(model.supportedThinkingEfforts) && model.supportedThinkingEfforts.length > 0
|
|
);
|
|
assert.ok(glmStaticModel, "glm must define an effort-tier static model for this regression test");
|
|
const effort = glmStaticModel.supportedThinkingEfforts?.[0];
|
|
assert.ok(effort, "glm static model must declare at least one effort tier");
|
|
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection("glm", connection.id as string, [
|
|
{ id: "glm-5-synced", name: "GLM 5 Synced", source: "imported" },
|
|
]);
|
|
|
|
const ids = await getCatalogIds();
|
|
|
|
assert.equal(ids.has("glm/glm-5-synced"), true);
|
|
assert.equal(ids.has(`glm/${glmStaticModel.id}`), false);
|
|
assert.equal(ids.has(`glm/${glmStaticModel.id}-${effort}`), false);
|
|
});
|
|
|
|
test("partial discovery provider preserves uncovered static models when synced", async () => {
|
|
const connection = await seedConnection("command-code", "command-code-partial-discovery");
|
|
const uncoveredStaticModel = "deepseek/deepseek-v4-flash";
|
|
const coveredSyncedModel = "claude-opus-4-7";
|
|
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection(
|
|
"command-code",
|
|
connection.id as string,
|
|
[{ id: coveredSyncedModel, name: "Claude Opus 4.7", source: "imported" }]
|
|
);
|
|
|
|
const ids = await getCatalogIds();
|
|
|
|
assert.equal(ids.has(`cmd/${coveredSyncedModel}`), true);
|
|
assert.equal(ids.has(`cmd/${uncoveredStaticModel}`), true);
|
|
});
|