mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-09 00:12:15 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
66 lines
2.5 KiB
TypeScript
66 lines
2.5 KiB
TypeScript
// Regression guard: POST /api/models/test must always return a STRING `error`,
|
|
// never an object. The Zod-validation and invalid-JSON paths used to return
|
|
// `{ error: <object> }` (Zod .format() / a details object). The dashboard renders
|
|
// that value directly in a toast, so an object froze the whole page (React #31).
|
|
// The "test a model → screen froze" bug.
|
|
//
|
|
// DB handles released in test.after (CLAUDE.md learning: unreleased SQLite
|
|
// handles hang node:test).
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-models-test-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const route = await import("../../src/app/api/models/test/route.ts");
|
|
|
|
test.before(async () => {
|
|
await settingsDb.updateSettings({ requireLogin: false });
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
function post(body: unknown, rawText?: string) {
|
|
return route.POST(
|
|
new Request("http://localhost:20128/api/models/test", {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/json" },
|
|
body: rawText !== undefined ? rawText : JSON.stringify(body),
|
|
})
|
|
);
|
|
}
|
|
|
|
test("Zod validation failure returns a STRING error (not an object)", async () => {
|
|
// connectionId "" fails z.string().min(1).optional() -> validation error path
|
|
const res = await post({ providerId: "openai", modelId: "gpt-4o", connectionId: "" });
|
|
assert.equal(res.status, 400);
|
|
const body = await res.json();
|
|
assert.equal(typeof body.error, "string", "error must be a string, never an object");
|
|
assert.equal(body.status, "error");
|
|
assert.match(body.error, /Invalid request/i);
|
|
});
|
|
|
|
test("missing required field returns a STRING error", async () => {
|
|
const res = await post({ providerId: "openai" }); // no modelId
|
|
assert.equal(res.status, 400);
|
|
const body = await res.json();
|
|
assert.equal(typeof body.error, "string");
|
|
});
|
|
|
|
test("invalid JSON body returns a STRING error (not an object)", async () => {
|
|
const res = await post(undefined, "{ not json ");
|
|
assert.equal(res.status, 400);
|
|
const body = await res.json();
|
|
assert.equal(typeof body.error, "string");
|
|
assert.match(body.error, /Invalid JSON/i);
|
|
});
|