Files
OmniRoute/tests/unit/noauth-autocombo-allowlist.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

108 lines
4.1 KiB
TypeScript

/**
* Auto-combo no-auth allowlist — the `auto`/`auto-*` candidate pool must only
* pull in no-auth (keyless) providers verified to work without any credential on
* our reference egress. As of this change that allowlist is narrowed to
* `opencode`: on the reference VPS (.15) it answers 200 with zero configuration.
* The other no-auth providers
* (duckduckgo-web, theoldllm, chipotle, aihorde) stay OUT of every auto/* pool
* until re-verified — they remain usable via direct `<alias>/<model>` calls, they
* are just not auto-routed to.
*
* Regression guard: AUTO_COMBO_NOAUTH_ALLOWLIST in
* open-sse/services/autoCombo/virtualFactory.ts drives what belongs here.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-noauth-allowlist-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const virtualFactory = await import("../../open-sse/services/autoCombo/virtualFactory.ts");
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
await resetStorage();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (ORIGINAL_DATA_DIR === undefined) {
delete process.env.DATA_DIR;
} else {
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
}
});
const ALLOWED_NOAUTH_PROVIDERS = ["opencode"];
const EXCLUDED_NOAUTH_PROVIDERS = ["duckduckgo-web", "theoldllm", "chipotle", "aihorde"];
test("fresh install: the allowlisted no-auth providers are present in the auto-combo pool", async () => {
const combo = await virtualFactory.createVirtualAutoCombo(undefined);
for (const providerId of ALLOWED_NOAUTH_PROVIDERS) {
const models = combo.models.filter((m: { providerId: string }) => m.providerId === providerId);
assert.ok(
models.length >= 1,
`allowlisted no-auth provider "${providerId}" must be present in the fresh-install ` +
`auto-combo pool. Pool providers: ${JSON.stringify([...new Set(combo.models.map((m: { providerId: string }) => m.providerId))])}`
);
assert.ok(
models.every((m: { connectionId: string }) => m.connectionId === "noauth"),
`all "${providerId}" models must use the synthetic noauth connection`
);
assert.ok(
combo.autoConfig.candidatePool.includes(providerId),
`"${providerId}" must be in the candidatePool`
);
}
});
test("fresh install: non-allowlisted no-auth providers are EXCLUDED from the auto-combo pool", async () => {
const combo = await virtualFactory.createVirtualAutoCombo(undefined);
for (const providerId of EXCLUDED_NOAUTH_PROVIDERS) {
const present = combo.models.some((m: { providerId: string }) => m.providerId === providerId);
assert.equal(
present,
false,
`no-auth provider "${providerId}" must NOT be auto-routed to (not in allowlist), ` +
`but it appeared in the pool. Pool: ${JSON.stringify(combo.models.map((m: { model: string }) => m.model))}`
);
assert.ok(
!combo.autoConfig.candidatePool.includes(providerId),
`"${providerId}" must not be in the candidatePool`
);
}
});
test("fresh install: EVERY synthetic-noauth candidate belongs to an allowlisted provider (no other keyless provider leaks in)", async () => {
const combo = await virtualFactory.createVirtualAutoCombo(undefined);
const noauthProviders = [
...new Set(
combo.models
.filter((m: { connectionId: string }) => m.connectionId === "noauth")
.map((m: { providerId: string }) => m.providerId)
),
].sort();
assert.deepEqual(
noauthProviders,
[...ALLOWED_NOAUTH_PROVIDERS].sort(),
`only the allowlisted providers may be no-auth (connectionId="noauth") candidates on a ` +
`fresh install, but found: ${JSON.stringify(noauthProviders)}`
);
});