mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 19:32:20 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
80 lines
3.2 KiB
TypeScript
80 lines
3.2 KiB
TypeScript
/**
|
|
* GHSA-mg76-rhpx-gvw3 / GHSA-gxv4-955v-v6cm — OAuth import / auto-import routes
|
|
* create or read provider credentials. They were guarded only by isAuthenticated(),
|
|
* which (because /api/oauth/ is PUBLIC-classified) accepts ANY valid client API key.
|
|
* They must now require MANAGEMENT scope.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-oauth-import-manage-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "oauth-import-manage-secret";
|
|
process.env.OMNIROUTE_DISABLE_REDIS_AUTH_CACHE = "1";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const codexImportToken = await import("../../src/app/api/oauth/codex/import-token/route.ts");
|
|
const cursorAutoImport = await import("../../src/app/api/oauth/cursor/auto-import/route.ts");
|
|
|
|
test.before(async () => {
|
|
process.env.JWT_SECRET = "oauth-import-manage-jwt";
|
|
process.env.INITIAL_PASSWORD = "oauth-import-manage-pass";
|
|
await settingsDb.updateSettings({ requireLogin: true });
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
delete process.env.JWT_SECRET;
|
|
delete process.env.INITIAL_PASSWORD;
|
|
});
|
|
|
|
function post(route: { POST: (r: Request) => Promise<Response> }, key?: string) {
|
|
return route.POST(
|
|
new Request("http://localhost/api/oauth/codex/import-token", {
|
|
method: "POST",
|
|
headers: {
|
|
"content-type": "application/json",
|
|
...(key ? { authorization: `Bearer ${key}` } : {}),
|
|
},
|
|
body: JSON.stringify({ accessToken: "x", name: "poc" }),
|
|
})
|
|
);
|
|
}
|
|
|
|
function get(route: { GET: (r: Request) => Promise<Response> }, key?: string) {
|
|
return route.GET(
|
|
new Request("http://localhost/api/oauth/cursor/auto-import", {
|
|
headers: key ? { authorization: `Bearer ${key}` } : {},
|
|
})
|
|
);
|
|
}
|
|
|
|
test("codex/import-token: non-manage key → 403, no key → 401, manage key passes the auth gate (GHSA-mg76)", async () => {
|
|
const nonManage = await apiKeysDb.createApiKey("client", "machine-client", []);
|
|
const manage = await apiKeysDb.createApiKey("admin", "machine-admin", ["manage"]);
|
|
|
|
assert.equal(
|
|
(await post(codexImportToken, nonManage.key)).status,
|
|
403,
|
|
"non-manage key rejected"
|
|
);
|
|
assert.equal((await post(codexImportToken)).status, 401, "no credential rejected");
|
|
|
|
const withManage = await post(codexImportToken, manage.key);
|
|
assert.notEqual(withManage.status, 401, "manage key must clear the auth gate");
|
|
assert.notEqual(withManage.status, 403, "manage key must clear the auth gate");
|
|
});
|
|
|
|
test("cursor/auto-import: a non-manage key cannot read the host's Cursor token (GHSA-gxv4)", async () => {
|
|
const nonManage = await apiKeysDb.createApiKey("client2", "machine-client2", []);
|
|
assert.equal((await get(cursorAutoImport, nonManage.key)).status, 403, "non-manage key rejected");
|
|
assert.equal((await get(cursorAutoImport)).status, 401, "no credential rejected");
|
|
});
|