Files
OmniRoute/tests/unit/param-filters-db.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

256 lines
10 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// Set DATA_DIR BEFORE any DB modules are imported so core.ts uses the temp dir.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-pf-db-"));
process.env.DATA_DIR = TEST_DATA_DIR;
// Dynamic imports — these modules initialize SQLite on load, so DATA_DIR must be
// set first.
const core = await import("../../src/lib/db/core.ts");
const {
setParamFilterConfig,
getParamFilterConfig,
deleteParamFilterConfig,
loadParamFilterConfigs,
addParamToBlocklist,
isAutoLearnGloballyEnabled,
setGlobalAutoLearnEnabled,
} = await import("../../src/lib/db/paramFilters.ts");
const { stripUnsupportedParams } = await import("../../open-sse/translator/paramSupport.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
// ---------------------------------------------------------------------------
// setParamFilterConfig / getParamFilterConfig
// ---------------------------------------------------------------------------
test("setParamFilterConfig stores and getParamFilterConfig retrieves a config", () => {
const config = {
block: ["thinking", "reasoning_budget"],
allow: [],
autoLearn: true,
};
setParamFilterConfig("test-provider", config);
const retrieved = getParamFilterConfig("test-provider");
assert.notEqual(retrieved, null);
assert.deepEqual(retrieved!.block, ["thinking", "reasoning_budget"]);
assert.deepEqual(retrieved!.allow, []);
assert.equal(retrieved!.autoLearn, true);
});
test("getParamFilterConfig returns null for unconfigured provider", () => {
assert.equal(getParamFilterConfig("nonexistent"), null);
});
test("getParamFilterConfig returns null for empty provider", () => {
assert.equal(getParamFilterConfig(""), null);
});
test("setParamFilterConfig with model overrides stores correctly", () => {
const config = {
block: ["thinking"],
allow: [],
models: {
"deepseek-r1": { block: ["max_tokens"] },
"deepseek-r2": { block: ["temperature"], allow: ["reasoning"] },
},
autoLearn: false,
};
setParamFilterConfig("nvidia", config);
const retrieved = getParamFilterConfig("nvidia");
assert.notEqual(retrieved, null);
assert.deepEqual(retrieved!.models?.["deepseek-r1"]?.block, ["max_tokens"]);
assert.deepEqual(retrieved!.models?.["deepseek-r2"]?.block, ["temperature"]);
assert.deepEqual(retrieved!.models?.["deepseek-r2"]?.allow, ["reasoning"]);
});
// ---------------------------------------------------------------------------
// deleteParamFilterConfig
// ---------------------------------------------------------------------------
test("deleteParamFilterConfig removes config and getParamFilterConfig returns null", () => {
setParamFilterConfig("ephemeral", { block: ["param1"], allow: [], autoLearn: false });
assert.notEqual(getParamFilterConfig("ephemeral"), null);
deleteParamFilterConfig("ephemeral");
assert.equal(getParamFilterConfig("ephemeral"), null);
});
test("deleteParamFilterConfig is a no-op for unconfigured provider", () => {
deleteParamFilterConfig("nothing-here");
});
// ---------------------------------------------------------------------------
// loadParamFilterConfigs
// ---------------------------------------------------------------------------
test("loadParamFilterConfigs returns all configured providers", () => {
setParamFilterConfig("provider-a", { block: ["a"], allow: [], autoLearn: false });
setParamFilterConfig("provider-b", { block: ["b"], allow: [], autoLearn: true });
const all = loadParamFilterConfigs();
assert.equal(all.has("provider-a"), true);
assert.equal(all.has("provider-b"), true);
assert.equal(all.get("provider-a")!.block[0], "a");
assert.equal(all.get("provider-b")!.autoLearn, true);
});
// ---------------------------------------------------------------------------
// addParamToBlocklist
// ---------------------------------------------------------------------------
test("addParamToBlocklist adds param to provider-level block list", () => {
setParamFilterConfig("test", { block: ["thinking"], allow: [], autoLearn: false });
addParamToBlocklist("test", "reasoning_budget");
const config = getParamFilterConfig("test");
assert.deepEqual(config!.block, ["thinking", "reasoning_budget"]);
});
test("addParamToBlocklist is idempotent — does not add duplicate", () => {
setParamFilterConfig("test-dup", { block: ["thinking"], allow: [], autoLearn: false });
addParamToBlocklist("test-dup", "thinking");
addParamToBlocklist("test-dup", "thinking");
const config = getParamFilterConfig("test-dup");
assert.deepEqual(config!.block, ["thinking"]);
});
test("addParamToBlocklist creates config if none exists", () => {
addParamToBlocklist("fresh-provider", "thinking");
const config = getParamFilterConfig("fresh-provider");
assert.notEqual(config, null);
assert.deepEqual(config!.block, ["thinking"]);
assert.equal(config!.autoLearn, false);
});
test("addParamToBlocklist with model param adds to model-level block list", () => {
setParamFilterConfig("test-model", { block: [], allow: [], autoLearn: false });
addParamToBlocklist("test-model", "temperature", "deepseek-r1");
const config = getParamFilterConfig("test-model");
assert.deepEqual(config!.models?.["deepseek-r1"]?.block, ["temperature"]);
});
// ---------------------------------------------------------------------------
// Global auto-learn flag
// ---------------------------------------------------------------------------
test("isAutoLearnGloballyEnabled returns false by default", () => {
assert.equal(isAutoLearnGloballyEnabled(), false);
});
test("setGlobalAutoLearnEnabled(true) enables global auto-learn", () => {
setGlobalAutoLearnEnabled(true);
assert.equal(isAutoLearnGloballyEnabled(), true);
});
test("setGlobalAutoLearnEnabled(false) disables global auto-learn", () => {
setGlobalAutoLearnEnabled(true);
assert.equal(isAutoLearnGloballyEnabled(), true);
setGlobalAutoLearnEnabled(false);
assert.equal(isAutoLearnGloballyEnabled(), false);
});
test("setGlobalAutoLearnEnabled does not affect per-provider configs", () => {
setParamFilterConfig("test-global-safe", { block: ["thinking"], allow: [], autoLearn: false });
setGlobalAutoLearnEnabled(true);
const config = getParamFilterConfig("test-global-safe");
assert.deepEqual(config!.block, ["thinking"]);
assert.equal(config!.autoLearn, false);
// Global is independent
assert.equal(isAutoLearnGloballyEnabled(), true);
});
// ---------------------------------------------------------------------------
// Full pipeline: DB config → stripUnsupportedParams
// ---------------------------------------------------------------------------
test("stripUnsupportedParams strips config-driven provider-level denylist", () => {
setParamFilterConfig("nvidia", {
block: ["thinking", "reasoning_budget"],
allow: [],
autoLearn: false,
});
loadParamFilterConfigs();
const body = { model: "deepseek-r1", thinking: "enabled", max_tokens: 100 };
const result = stripUnsupportedParams("nvidia", "deepseek-r1", body);
assert.equal((result as Record<string, unknown>).thinking, undefined);
assert.equal((result as Record<string, unknown>).reasoning_budget, undefined);
assert.equal((result as Record<string, unknown>).max_tokens, 100);
});
test("stripUnsupportedParams strips config-driven model-level denylist (stricter)", () => {
setParamFilterConfig("nvidia", {
block: ["thinking"],
allow: [],
models: { "deepseek-r1": { block: ["max_tokens"] } },
autoLearn: false,
});
loadParamFilterConfigs();
const body = { model: "deepseek-r1", thinking: "enabled", max_tokens: 100, temperature: 0.7 };
const result = stripUnsupportedParams("nvidia", "deepseek-r1", body);
assert.equal((result as Record<string, unknown>).thinking, undefined);
assert.equal((result as Record<string, unknown>).max_tokens, undefined);
assert.equal((result as Record<string, unknown>).temperature, 0.7);
});
test("stripUnsupportedParams allowlist restores a denied param from original body", () => {
setParamFilterConfig("nvidia", {
block: ["thinking", "reasoning_budget"],
allow: ["thinking"],
autoLearn: false,
});
loadParamFilterConfigs();
const body = { model: "deepseek-r1", thinking: "enabled", max_tokens: 100 };
const result = stripUnsupportedParams("nvidia", "deepseek-r1", body);
assert.equal((result as Record<string, unknown>).thinking, "enabled");
assert.equal((result as Record<string, unknown>).reasoning_budget, undefined);
assert.equal((result as Record<string, unknown>).max_tokens, 100);
});
test("stripUnsupportedParams allowlist does not introduce params not in original body", () => {
setParamFilterConfig("nvidia", {
block: [],
allow: ["nonexistent_param"],
autoLearn: false,
});
loadParamFilterConfigs();
const body = { model: "deepseek-r1", thinking: "enabled" };
const result = stripUnsupportedParams("nvidia", "deepseek-r1", body);
assert.equal((result as Record<string, unknown>).nonexistent_param, undefined);
});
test("stripUnsupportedParams model-level denylist overrides provider-level allowlist", () => {
setParamFilterConfig("nvidia", {
block: ["thinking"],
allow: ["thinking"],
models: { "deepseek-r1": { block: ["thinking"] } },
autoLearn: false,
});
loadParamFilterConfigs();
// Provider allowlist re-adds thinking, but model-level denylist strips it again
const body = { model: "deepseek-r1", thinking: "enabled", max_tokens: 100 };
const result = stripUnsupportedParams("nvidia", "deepseek-r1", body);
assert.equal(
(result as Record<string, unknown>).thinking,
undefined,
"model denylist should win over provider allowlist"
);
assert.equal((result as Record<string, unknown>).max_tokens, 100);
});
test("stripUnsupportedParams no-op when no DB config exists (default behavior)", () => {
const body = { model: "deepseek-r1", thinking: "enabled", max_tokens: 100 };
const result = stripUnsupportedParams("unknown", "deepseek-r1", body);
assert.equal((result as Record<string, unknown>).thinking, "enabled");
assert.equal((result as Record<string, unknown>).max_tokens, 100);
});