mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
71 lines
2.9 KiB
TypeScript
71 lines
2.9 KiB
TypeScript
/**
|
|
* Issue #2986 — Payload Rules not persisting across server restart.
|
|
*
|
|
* Rules are written to the DB (key_value `settings.payloadRules`) and mirrored
|
|
* into an in-memory `runtimeOverride`. After a restart, if `runtimeOverride` is
|
|
* null (the boot hook didn't run in this module instance, or a separate bundle
|
|
* instance), `getPayloadRulesConfig` used to fall back to the (usually empty)
|
|
* file config and return no rules.
|
|
*
|
|
* Fix: when there is no in-memory override, read the DB-persisted rules — the
|
|
* source of truth — before the file. This test simulates a restart by clearing
|
|
* the in-memory override and asserting the persisted rules still come back.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-payload-rules-restart-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const payloadRulesService = await import("../../open-sse/services/payloadRules.ts");
|
|
|
|
test.after(() => {
|
|
payloadRulesService.resetPayloadRulesConfigForTests();
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#2986 payload rules survive a restart (DB fallback when override is cleared)", async () => {
|
|
// Persist a rule to the DB (as the Settings UI does via updateSettings).
|
|
await settingsDb.updateSettings({
|
|
payloadRules: {
|
|
default: [{ models: [{ name: "gpt-*" }], params: { temperature: 0.2 } }],
|
|
override: [],
|
|
filter: [],
|
|
},
|
|
});
|
|
|
|
// Simulate a server restart: the in-memory override does not exist in a fresh
|
|
// process / module instance.
|
|
payloadRulesService.resetPayloadRulesConfigForTests();
|
|
|
|
const config = (await payloadRulesService.getPayloadRulesConfig({ forceRefresh: true })) as {
|
|
default?: unknown[];
|
|
};
|
|
assert.ok(Array.isArray(config.default), "config.default must be an array");
|
|
assert.equal(
|
|
config.default!.length,
|
|
1,
|
|
"the persisted rule must be returned after restart (read from the DB, not the empty file)"
|
|
);
|
|
});
|
|
|
|
test("#2986 explicitly-empty persisted rules return an empty config (no over-broadening)", async () => {
|
|
// The user can save an empty configuration; the DB fallback must reflect that
|
|
// (not fabricate rules). updateSettings invalidates the settings cache.
|
|
await settingsDb.updateSettings({
|
|
payloadRules: { default: [], override: [], filter: [] },
|
|
});
|
|
payloadRulesService.resetPayloadRulesConfigForTests();
|
|
|
|
const config = (await payloadRulesService.getPayloadRulesConfig({ forceRefresh: true })) as {
|
|
default?: unknown[];
|
|
};
|
|
assert.deepEqual(config.default, [], "empty DB rules → empty default (neutral config)");
|
|
});
|