Files
OmniRoute/tests/unit/perplexity-web-streaming-tools-5927.test.ts
Diego Rodrigues de Sa e Souza 7d57d9f4a1 fix(providers): retire common ChatGPT Web provider (#11754)
Rebased onto the current release/v3.8.51 tip as part of a combined provider-retirement/provenance merge batch (Designer Web, Felo Web, Runtime, GPL-derived removal, Qwen Web already landed). Large conflict set (this is the biggest PR in the batch — the common ChatGPT Web provider touches chat, images, count-tokens, session leases, and combos). Conflicts resolved:

- `open-sse/config/providers/registry/chatgpt-web/*`, `open-sse/executors/chatgpt-web*`, `open-sse/handlers/imageGeneration/providers/chatgptWeb.ts`, and their tests: kept deleted, matching the PR's stated scope.
- `open-sse/config/providers/registry/minimax/web/index.ts`, `open-sse/handlers/imageGeneration/providers/geminiWeb.ts`, `open-sse/executors/gemini-web.ts`'s stale image-mode branch: base-drift collisions against already-merged sibling retirements (#11691, #11708) — kept deleted / dropped the dead code, since this PR's own branch forked before those merged.
- `src/shared/constants/reservedProviderPrefixes.ts`, `open-sse/executors/index.ts`, `executorProxy.ts`, `virtualFactory.ts`, `autoStrategy.ts`, `src/lib/db/providers.ts`, `src/sse/handlers/chat.ts`: combined the Designer + Runtime (Felo/Qwen) + common-ChatGPT-Web retirement guard calls at each shared chokepoint — compute-once-then-OR pattern, consistent with prior combinations in this batch.
- `src/sse/services/model.ts` / `src/sse/handlers/chatHelpers.ts`: adopted this PR's new `getModelInfoOrRetirementResponse()` central wrapper (a real improvement over ad-hoc try/catch), and extended it to also catch the Designer + Runtime retirement errors it didn't originally cover, so the consolidation doesn't regress the other two mechanisms.
- `src/app/api/v1/images/edits/route.ts`: this PR moved the retirement check earlier (before `enforceApiKeyPolicy`) but left the old later call+catch block in place from base drift — removed the now-redundant duplicate `resolveImageRouteModel()` call and merged the Designer catch into the earlier one.
- `open-sse/config/imageRegistry.ts`, `tests/snapshots/executors/executor-map.json` (`keyCount` recomputed to 133), `tests/snapshots/provider/translate-path.json`: same "both sides inserted a different retired provider at the same slot" pattern — resolved by dropping both.
- `tests/unit/chatcore-executor-proxy.test.ts`, `provider-node-reserved-prefix.test.ts`, `combo-auto-candidate-expansion.test.ts`, `messages-count-tokens-route.test.ts`, `virtual-auto-combo.test.ts`: split into independent per-mechanism test blocks (established pattern); `virtual-auto-combo.test.ts`'s old "includes cookie web-session providers" positive-inclusion test (which used chatgpt-web as its example) was retired along with the provider and replaced by this PR's negative-exclusion test for the same slot.
- `docs/architecture/ARCHITECTURE.md`, `CODEBASE_DOCUMENTATION.md` (+ 4 i18n mirrors), `README.md`, `FREE-TIERS-GUIDE.md`, `docs/diagrams/free-tier-budget.svg`, `docs/screenshots/free-tier-budget-card.svg`, `docs/reference/PROVIDER_REFERENCE.md`: recomputed every stale count from the real merged state — 104 executors (`countFiles` gate logic), 351 providers (regenerated via `gen:provider-reference`), 152/351 `hasFree` entries, 445/438/7 free-tier catalog rows, 13 ToS-avoid providers, budget-card regenerated via its real generator script. One doc conflict (`oauth/` module list) needed picking HEAD's side specifically — theirs still listed the already-removed `raycast` module instead of the real `openference`.
- `config/quality/test-masking-allowlist.json`: additive merge of the PR's 17 `_deletedWithReplacement` entries alongside the batch's existing ones (one real duplicate-key mistake in my first pass, caught and fixed via a `object_pairs_hook` duplicate-key check before finalizing).

Also fixed two real, unrelated-to-my-merge issues surfaced by the focused suite:
- `tests/unit/resolve-web-provider-host.test.ts`: the PR's own test had a typo — it asserted `perplexity-web`'s resolved host as `"perplexity.ai"`, but the provider's registered `website` is `"https://www.perplexity.ai"` and the resolver returns the URL's `host` verbatim (no www-stripping), so the correct value is `"www.perplexity.ai"` (consistent with the same test's own `url` assertion).
- `tests/unit/hard-session-lease-bypass-inventory.test.ts`: this golden call-site inventory was already stale on the pristine post-#11713 tip (confirmed via a throwaway probe worktree) — `src/lib/db/providers.ts`'s 3 connection-fallback sites and a third `src/app/api/providers/route.ts` site were never added to the golden list by the earlier-merged #11698/#11720 PRs. Updated it to the real current inventory (dated inline comments explain each delta and which PR introduced it), plus this PR's own legitimate deltas (image-edits duplicate-call removal, `ChatGptWebExecutor.execute()` site removed).

Focused suite green (433/433 across executor-proxy, reserved-prefix, hard-session-lease-bypass-inventory, resolve-web-provider-host, retirement/runtime-block/source-retirement/management-retirement/image-handler-retirement, migration-168, combo-auto-candidate-expansion, virtual-auto-combo, executor-map-golden and siblings), plus `typecheck:core`, `check-file-size`, and `check-changelog-integrity` clean. Thanks for the thorough provenance-hold retirement work — appreciated.
2026-08-28 06:52:46 -03:00

166 lines
5.6 KiB
TypeScript

// Tool-call emulation for the Perplexity Web executor in STREAMING mode (#5927).
//
// perplexity-web.ts converts <tool>{...}</tool> text into real OpenAI tool_calls
// only for non-streaming requests (the `hasTools && !stream` gate). Streaming
// requests — the default for agentic coding clients — got the raw <tool> text
// as plain delta.content and never emitted a tool_calls SSE delta, so clients
// could not execute tools. These tests pin the shared web-tool response contract.
import test from "node:test";
import assert from "node:assert/strict";
const { PerplexityWebExecutor } = await import("../../open-sse/executors/perplexity-web.ts");
const { __setTlsFetchOverrideForTesting } =
await import("../../open-sse/services/perplexityTlsClient.ts");
// ─── Helper: Build a mock SSE stream from Perplexity events ─────────────────
function mockPplxStream(events: unknown[]) {
const encoder = new TextEncoder();
const chunks: string[] = [];
for (const evt of events) {
chunks.push(`event: message\r\ndata: ${JSON.stringify(evt)}\r\n\r\n`);
}
chunks.push("event: end_of_stream\r\n\r\n");
const body = chunks.join("");
return new ReadableStream({
start(controller) {
controller.enqueue(encoder.encode(body));
controller.close();
},
});
}
function installMockFetch(streamEvents: unknown[]) {
__setTlsFetchOverrideForTesting(async () => {
return {
status: 200,
headers: new Headers({ "Content-Type": "text/event-stream" }),
text: null,
body: mockPplxStream(streamEvents),
};
});
return () => __setTlsFetchOverrideForTesting(null);
}
const WEATHER_TOOL = {
type: "function",
function: {
name: "write_file",
description: "Write a file to disk",
parameters: {
type: "object",
properties: { path: { type: "string" }, content: { type: "string" } },
required: ["path", "content"],
},
},
};
const TOOL_CALL_TEXT =
'<tool>{"name":"write_file","arguments":{"path":"a.ts","content":"x"}}</tool>';
function toolEvents(text: string) {
return [
{
backend_uuid: "tool-uuid-1",
blocks: [
{
intended_usage: "markdown",
markdown_block: { chunks: [text], progress: "DONE" },
},
],
status: "COMPLETED",
},
];
}
test("Tools stream: <tool> text becomes delta.tool_calls + finish_reason tool_calls, NOT raw <tool> content (#5927)", async () => {
const restore = installMockFetch(toolEvents(TOOL_CALL_TEXT));
try {
const executor = new PerplexityWebExecutor();
const result = await executor.execute({
model: "pplx-auto",
body: {
messages: [{ role: "user", content: "write a file" }],
tools: [WEATHER_TOOL],
stream: true,
},
stream: true,
credentials: { apiKey: "test-cookie" },
signal: AbortSignal.timeout(10000),
log: null,
} as any);
assert.equal(result.response.status, 200);
assert.equal(result.response.headers.get("Content-Type"), "text/event-stream");
const text = await result.response.text();
const chunks = text
.split("\n")
.filter((l) => l.startsWith("data: ") && !l.includes("[DONE]"))
.map((l) => JSON.parse(l.slice(6)));
// Must NOT leak raw <tool> text as plain content.
assert.ok(
chunks.every((c) => {
const content = c.choices?.[0]?.delta?.content;
return typeof content !== "string" || !content.includes("<tool>");
}),
"no chunk contains raw <tool> text in delta.content"
);
const toolChunk = chunks.find((c) => c.choices[0].delta && c.choices[0].delta.tool_calls);
assert.ok(toolChunk, "a chunk carries delta.tool_calls");
assert.equal(toolChunk.choices[0].finish_reason, "tool_calls");
const tc = toolChunk.choices[0].delta.tool_calls;
assert.ok(Array.isArray(tc) && tc.length === 1);
assert.equal(tc[0].type, "function");
assert.equal(tc[0].function.name, "write_file");
assert.equal(typeof tc[0].function.arguments, "string", "arguments is a JSON string");
assert.deepEqual(JSON.parse(tc[0].function.arguments), { path: "a.ts", content: "x" });
const lastLine = text.trim().split("\n").filter(Boolean).pop();
assert.equal(lastLine, "data: [DONE]");
} finally {
restore();
}
});
test("Tools regression: streaming request with NO tools still streams plain content unchanged (#5927)", async () => {
const restore = installMockFetch(toolEvents("Just plain text, no tools."));
try {
const executor = new PerplexityWebExecutor();
const result = await executor.execute({
model: "pplx-auto",
body: { messages: [{ role: "user", content: "hi" }], stream: true },
stream: true,
credentials: { apiKey: "test-cookie" },
signal: AbortSignal.timeout(10000),
log: null,
} as any);
assert.equal(result.response.status, 200);
const text = await result.response.text();
const chunks = text
.split("\n")
.filter((l) => l.startsWith("data: ") && !l.includes("[DONE]"))
.map((l) => JSON.parse(l.slice(6)));
let assembled = "";
for (const c of chunks) {
const content = c.choices?.[0]?.delta?.content;
if (content) assembled += content;
}
assert.equal(assembled, "Just plain text, no tools.");
assert.ok(
chunks.every((c) => !(c.choices[0].delta && c.choices[0].delta.tool_calls)),
"no tool_calls emitted without a tools array"
);
const finishChunk = chunks.find((c) => c.choices[0].finish_reason);
assert.equal(finishChunk.choices[0].finish_reason, "stop");
} finally {
restore();
}
});