mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
81 lines
3.2 KiB
TypeScript
81 lines
3.2 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// #6372: internal probes (combo-test, cloud-sync verify) must NOT naively grab
|
|
// getApiKeys()[0] — that first row is usually a restricted self:usage key, so
|
|
// the probe hits "Model X is not allowed for this API key" even when the combo
|
|
// path is healthy. pickApiKeyForInternalUse prefers a management-scoped key.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omr-pick-internal-key-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = "test-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
|
|
function reset() {
|
|
core.resetDbInstance();
|
|
apiKeysDb.resetApiKeyState();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(() => reset());
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#6372: returns null when there are no keys", async () => {
|
|
assert.equal(await apiKeysDb.pickApiKeyForInternalUse("combo-health-check"), null);
|
|
});
|
|
|
|
test("internal probes never auto-select a hard-lease key", async () => {
|
|
await apiKeysDb.createApiKey("managed-key", "machine-a", ["manage", "lease:exclusive"], {
|
|
allowedConnections: ["00000000-0000-4000-8000-000000000001"],
|
|
});
|
|
|
|
assert.equal(await apiKeysDb.pickApiKeyForInternalUse("combo-health-check"), null);
|
|
assert.equal(await apiKeysDb.pickApiKeyForInternalUse("internal-probe"), null);
|
|
});
|
|
|
|
test("#6372: prefers a management-scoped key over a plain self:usage key", async () => {
|
|
// Insert the plain (restricted-intent) key FIRST so getApiKeys()[0] would be
|
|
// the wrong one under the old naive selection.
|
|
await apiKeysDb.createApiKey("usage-key", "machine-a", ["self:usage"]);
|
|
const mgr = await apiKeysDb.createApiKey("manage-key", "machine-a", ["manage"]);
|
|
|
|
const picked = await apiKeysDb.pickApiKeyForInternalUse("combo-health-check");
|
|
assert.equal(picked, mgr.key, "should pick the management-scoped key, not the first row");
|
|
});
|
|
|
|
test("#6372: a restricted-empty key does not outrank a real allow-all key", async () => {
|
|
const restricted = await apiKeysDb.createApiKey("restricted-empty", "machine-a", ["self:usage"]);
|
|
await apiKeysDb.updateApiKeyPermissions(restricted.id, {
|
|
modelAccessMode: "restricted",
|
|
allowedModels: [],
|
|
});
|
|
const allowAll = await apiKeysDb.createApiKey("allow-all", "machine-a", ["self:usage"]);
|
|
|
|
const picked = await apiKeysDb.pickApiKeyForInternalUse("internal-probe");
|
|
assert.equal(picked, allowAll.key);
|
|
});
|
|
|
|
test("#6372: falls back to an active key when none is management-scoped or allow-all", async () => {
|
|
const only = await apiKeysDb.createApiKey("restricted-empty", "machine-a", ["self:usage"]);
|
|
await apiKeysDb.updateApiKeyPermissions(only.id, {
|
|
modelAccessMode: "restricted",
|
|
allowedModels: [],
|
|
});
|
|
|
|
const picked = await apiKeysDb.pickApiKeyForInternalUse("internal-probe");
|
|
assert.equal(
|
|
picked,
|
|
only.key,
|
|
"last-resort fallback stays best-effort and does not bypass policy"
|
|
);
|
|
});
|