mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 11:22:15 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
194 lines
6.9 KiB
TypeScript
194 lines
6.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import type { GuardrailContext } from "@/lib/guardrails/base";
|
|
|
|
// Isolate DB state to avoid polluting production database
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-pii-"));
|
|
process.env.DATA_DIR = tmpDir;
|
|
|
|
test("PIIMaskerGuardrail respects feature flag DB overrides", async (t) => {
|
|
await t.test(
|
|
"when PII_REDACTION_ENABLED is false in env but true in DB, request PII is redacted",
|
|
async () => {
|
|
delete process.env.PII_REDACTION_ENABLED;
|
|
const { setFeatureFlagOverride } = await import("@/lib/db/featureFlags");
|
|
setFeatureFlagOverride("PII_REDACTION_ENABLED", "true");
|
|
|
|
const { PIIMaskerGuardrail } = await import("@/lib/guardrails/piiMasker");
|
|
const guardrail = new PIIMaskerGuardrail();
|
|
const payload = {
|
|
model: "gpt-4o",
|
|
messages: [{ role: "user", content: "My SSN is 123-45-6789" }],
|
|
};
|
|
const dummyContext: GuardrailContext = {
|
|
model: "gpt-4o",
|
|
provider: "openai",
|
|
endpoint: "/v1/chat/completions",
|
|
};
|
|
const res = await guardrail.preCall(payload, dummyContext);
|
|
assert.strictEqual(Boolean(res.modifiedPayload), true);
|
|
const messages = (res.modifiedPayload as { messages?: Array<{ content?: string }> })
|
|
?.messages;
|
|
assert.strictEqual(messages?.[0]?.content, "My SSN is [SSN_REDACTED]");
|
|
|
|
setFeatureFlagOverride("PII_REDACTION_ENABLED", "false");
|
|
const resDisabled = await guardrail.preCall(payload, dummyContext);
|
|
assert.strictEqual(Boolean(resDisabled.modifiedPayload), false);
|
|
}
|
|
);
|
|
});
|
|
|
|
test("sanitizePII checks resolveFeatureFlag, not process.env", async (t) => {
|
|
const originalEnv = process.env.PII_RESPONSE_SANITIZATION;
|
|
|
|
await t.test("when env is true but DB is override false, it resolves to disabled", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "true";
|
|
|
|
const { setFeatureFlagOverride, getFeatureFlagOverride } =
|
|
await import("@/lib/db/featureFlags");
|
|
setFeatureFlagOverride("PII_RESPONSE_SANITIZATION", "false");
|
|
|
|
console.log("Subtest 1 - Override in DB:", getFeatureFlagOverride("PII_RESPONSE_SANITIZATION"));
|
|
|
|
const { sanitizePIIChunk } = await import("@/lib/piiSanitizer");
|
|
const { isFeatureFlagEnabled } = await import("@/shared/utils/featureFlags");
|
|
console.log(
|
|
"Subtest 1 - isFeatureFlagEnabled:",
|
|
isFeatureFlagEnabled("PII_RESPONSE_SANITIZATION")
|
|
);
|
|
|
|
const input = "my email is test@example.com";
|
|
const result = sanitizePIIChunk(input, true);
|
|
assert.equal(result, input);
|
|
});
|
|
|
|
await t.test("when env is false but DB is override true, it resolves to enabled", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "false";
|
|
|
|
const { setFeatureFlagOverride, getFeatureFlagOverride } =
|
|
await import("@/lib/db/featureFlags");
|
|
setFeatureFlagOverride("PII_RESPONSE_SANITIZATION", "true");
|
|
|
|
console.log("Subtest 2 - Override in DB:", getFeatureFlagOverride("PII_RESPONSE_SANITIZATION"));
|
|
|
|
const { sanitizePIIChunk } = await import("@/lib/piiSanitizer");
|
|
const { isFeatureFlagEnabled } = await import("@/shared/utils/featureFlags");
|
|
console.log(
|
|
"Subtest 2 - isFeatureFlagEnabled:",
|
|
isFeatureFlagEnabled("PII_RESPONSE_SANITIZATION")
|
|
);
|
|
|
|
const input = "my email is test@example.com";
|
|
const result = sanitizePIIChunk(input, true);
|
|
assert.ok(result.includes("[EMAIL_REDACTED]"));
|
|
});
|
|
|
|
if (originalEnv !== undefined) {
|
|
process.env.PII_RESPONSE_SANITIZATION = originalEnv;
|
|
} else {
|
|
delete process.env.PII_RESPONSE_SANITIZATION;
|
|
}
|
|
});
|
|
|
|
test.after(async () => {
|
|
const coreDb = await import("@/lib/db/core");
|
|
coreDb.resetDbInstance();
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("getMode returns redact for invalid flag values", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "true";
|
|
process.env.PII_RESPONSE_SANITIZATION_MODE = "garbage";
|
|
|
|
const { sanitizePIIChunk } = await import("@/lib/piiSanitizer");
|
|
const input = "my email is test@example.com";
|
|
const result = sanitizePIIChunk(input, true);
|
|
|
|
assert.ok(
|
|
result.includes("[EMAIL_REDACTED]"),
|
|
"invalid mode should fall back to redact, not silently pass PII through"
|
|
);
|
|
|
|
delete process.env.PII_RESPONSE_SANITIZATION_MODE;
|
|
});
|
|
|
|
test("sanitizePII detects and redacts SSN", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "true";
|
|
delete process.env.PII_RESPONSE_SANITIZATION_MODE;
|
|
|
|
const { sanitizePII } = await import("@/lib/piiSanitizer");
|
|
const input = "My SSN is 123-45-6789";
|
|
const result = sanitizePII(input);
|
|
|
|
assert.ok(result.text.includes("[SSN_REDACTED]"), "SSN should be redacted");
|
|
assert.ok(!result.text.includes("123-45-6789"), "raw SSN should not remain");
|
|
|
|
delete process.env.PII_RESPONSE_SANITIZATION;
|
|
});
|
|
|
|
test("sanitizePII detects and redacts credit card", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "true";
|
|
delete process.env.PII_RESPONSE_SANITIZATION_MODE;
|
|
|
|
const { sanitizePII } = await import("@/lib/piiSanitizer");
|
|
const input = "Card: 4111111111111111";
|
|
const result = sanitizePII(input);
|
|
|
|
assert.ok(result.text.includes("[CC_REDACTED]"), "Credit card should be redacted");
|
|
|
|
delete process.env.PII_RESPONSE_SANITIZATION;
|
|
});
|
|
|
|
test("sanitizePII detects AWS access key", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "true";
|
|
delete process.env.PII_RESPONSE_SANITIZATION_MODE;
|
|
|
|
const { sanitizePII } = await import("@/lib/piiSanitizer");
|
|
const input = "Key: AKIAEXAMPLE123456789";
|
|
const result = sanitizePII(input);
|
|
|
|
assert.ok(result.text.includes("[AWS_KEY_REDACTED]"), "AWS access key should be redacted");
|
|
|
|
delete process.env.PII_RESPONSE_SANITIZATION;
|
|
});
|
|
|
|
test("sanitizePIIResponse handles Claude format", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "true";
|
|
delete process.env.PII_RESPONSE_SANITIZATION_MODE;
|
|
|
|
const { sanitizePIIResponse } = await import("@/lib/piiSanitizer");
|
|
const payload = {
|
|
type: "message",
|
|
content: [{ type: "text", text: "SSN: 123-45-6789" }],
|
|
};
|
|
const result = sanitizePIIResponse(payload) as typeof payload;
|
|
|
|
assert.ok(result.content[0].text.includes("[SSN_REDACTED]"));
|
|
|
|
delete process.env.PII_RESPONSE_SANITIZATION;
|
|
});
|
|
|
|
test("sanitizePIIResponse handles Gemini format", async () => {
|
|
process.env.PII_RESPONSE_SANITIZATION = "true";
|
|
delete process.env.PII_RESPONSE_SANITIZATION_MODE;
|
|
|
|
const { sanitizePIIResponse } = await import("@/lib/piiSanitizer");
|
|
const payload = {
|
|
candidates: [
|
|
{
|
|
content: {
|
|
parts: [{ text: "Contact: test@example.com" }],
|
|
},
|
|
},
|
|
],
|
|
};
|
|
const result = sanitizePIIResponse(payload) as typeof payload;
|
|
|
|
assert.ok(result.candidates[0].content.parts[0].text.includes("[EMAIL_REDACTED]"));
|
|
|
|
delete process.env.PII_RESPONSE_SANITIZATION;
|
|
});
|