Files
OmniRoute/tests/unit/playground-simulate-route-persisted-combo.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

136 lines
4.4 KiB
TypeScript

import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import test from "node:test";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-playground-simulate-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const { POST } = await import("../../src/app/api/playground/simulate-route/route.ts");
let persistedComboId: string;
test.beforeEach(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
await providersDb.createProviderConnection({
provider: "cc",
authType: "no-auth",
name: "Claude Code",
});
await providersDb.createProviderConnection({
provider: "anthropic",
authType: "no-auth",
name: "Anthropic",
});
const combo = await combosDb.createCombo({
name: "persisted combo",
strategy: "priority",
models: [
{ kind: "model", model: "cc/claude-opus-5", fallbackOnlyOnQuotaExhaustion: true },
{ kind: "model", providerId: "anthropic", model: "anthropic/claude-opus-5" },
{ kind: "combo-ref", comboName: "nested combo" },
],
});
persistedComboId = combo.id;
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
function request(body: unknown): Request {
return new Request("http://localhost/api/playground/simulate-route", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify(body),
});
}
test("simulates persisted combo model steps in order", async () => {
const response = await POST(request({ comboId: persistedComboId, promptTokens: 500 }));
const body = await response.json();
assert.equal(response.status, 200);
assert.deepEqual(
body.targets.map(({ provider, model, rank }: Record<string, unknown>) => ({
provider,
model,
rank,
})),
[
{ provider: "cc", model: "claude-opus-5", rank: 1 },
{ provider: "anthropic", model: "claude-opus-5", rank: 2 },
]
);
assert.deepEqual(
body.targets.map(({ status }: Record<string, unknown>) => status),
["available", "available"]
);
// #11822 follow-up: combo-ref steps now get a specific warning naming the
// referenced combo instead of folding into the generic "unsupported step"
// count (that count is reserved for genuinely unrecognized step shapes).
assert.ok(body.warnings.some((warning: string) => warning.includes('combo "nested combo"')));
assert.ok(body.warnings.every((warning: string) => !warning.includes("not configured")));
});
test("surfaces a provider-wildcard step as an unresolved target with a specific warning", async () => {
const combo = await combosDb.createCombo({
name: "combo with wildcard",
strategy: "priority",
models: [
{ kind: "model", model: "cc/claude-opus-5" },
{ kind: "provider-wildcard", providerId: "groq", modelPattern: "llama-*" },
],
});
const response = await POST(request({ comboId: combo.id, promptTokens: 500 }));
const body = await response.json();
assert.equal(response.status, 200);
assert.deepEqual(
body.targets.map(({ provider, model }: Record<string, unknown>) => ({ provider, model })),
[
{ provider: "cc", model: "claude-opus-5" },
{ provider: "groq", model: "llama-*" },
]
);
assert.ok(
body.warnings.some(
(warning: string) => warning.includes("groq/llama-*") && warning.includes("wildcard")
)
);
});
test("returns 404 for a missing persisted combo", async () => {
const response = await POST(request({ comboId: "missing" }));
assert.equal(response.status, 404);
assert.deepEqual(await response.json(), { error: "Combo not found" });
});
test("preserves inline combo simulation", async () => {
const response = await POST(
request({
combo: {
name: "inline combo",
strategy: "priority",
targets: [{ provider: "cc", model: "claude-opus-5" }],
},
})
);
const body = await response.json();
assert.equal(response.status, 200);
assert.deepEqual(
body.targets.map(({ provider, model }: Record<string, unknown>) => ({ provider, model })),
[{ provider: "cc", model: "claude-opus-5" }]
);
});