mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
74 lines
3.0 KiB
TypeScript
74 lines
3.0 KiB
TypeScript
// #8082: the built-in `poe` provider (passthroughModels:true, no baseUrl field
|
|
// exposed in the UI) is routed through the generic OpenAI-style model-discovery
|
|
// branch, which resolves its base URL ONLY from
|
|
// `connection.providerSpecificData.baseUrl` OR `getRegistryEntry("poe")?.baseUrl`.
|
|
// There was no REGISTRY entry for "poe", so discovery always failed with
|
|
// {"error":"No base URL configured for provider"} even though the actual
|
|
// inference/validation path (src/lib/providers/validation/audioMiscProviders.ts)
|
|
// has always had a hardcoded "https://api.poe.com/v1" fallback and worked fine.
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-poe-models-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const providerModelsRoute = await import("../../src/app/api/providers/[id]/models/route.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
|
|
async function resetStorage() {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("provider models route resolves the built-in Poe registry base URL instead of failing with 'No base URL configured for provider' (#8082)", async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: "poe",
|
|
authType: "apikey",
|
|
name: "poe-8082",
|
|
apiKey: "poe-test-key",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
// Mirrors the built-in provider's UI: no baseUrl field is exposed for Poe,
|
|
// so providerSpecificData never carries one.
|
|
providerSpecificData: {},
|
|
});
|
|
|
|
const seenRequests: Array<{ url: string; authorization: string | null }> = [];
|
|
globalThis.fetch = async (url, init) => {
|
|
const headers = new Headers(init?.headers as HeadersInit | undefined);
|
|
seenRequests.push({ url: String(url), authorization: headers.get("authorization") });
|
|
return Response.json({ data: [{ id: "gpt-5.2", name: "GPT-5.2" }] });
|
|
};
|
|
|
|
const response = await providerModelsRoute.GET(
|
|
new Request(`http://localhost/api/providers/${connection.id}/models?refresh=true`),
|
|
{ params: { id: connection.id } }
|
|
);
|
|
const body = (await response.json()) as { error?: string };
|
|
|
|
assert.notEqual(body.error, "No base URL configured for provider");
|
|
assert.equal(response.status, 200);
|
|
assert.ok(
|
|
seenRequests.some((req) => req.url.startsWith("https://api.poe.com/v1")),
|
|
`expected a request against the Poe registry base URL, got: ${JSON.stringify(seenRequests)}`
|
|
);
|
|
});
|