Files
OmniRoute/tests/unit/provider-probe-target.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

148 lines
5.8 KiB
TypeScript

/**
* Guards for the per-provider probe target resolution (#8411 follow-up to #10420).
*
* `resolveEligibleProviderUrl` is checked against real `providerRegistry` entries rather than
* a mock: `groq` for the eligible case (plain `baseUrl`, `/chat/completions` → `/models`) and
* `antigravity` for the ineligible case — it has an entry, but only `baseUrls[]` (a custom
* `urlBuilder`), no singular `baseUrl` to read.
*
* `resolveProviderProbeTarget` is checked against a real database (`assignProxyToScope`),
* mirroring `tests/unit/db-health-driver.test.ts`'s pattern of comparing against ground truth
* rather than a mocked DB.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-provider-probe-target-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "provider-probe-target-secret";
const core = await import("../../src/lib/db/core.ts");
const proxiesDb = await import("../../src/lib/db/proxies.ts");
const probeTarget = await import("../../src/lib/proxyHealth/providerProbeTarget.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
function seedProxy(name: string) {
return proxiesDb.createProxy({
name,
type: "http",
host: "127.0.0.1",
port: 1, // never dialed by these tests — target resolution only
});
}
// ─── isProbeSafeBaseUrl: the guard, tested directly, no registry involved ──
test("https without a query string is safe", () => {
assert.equal(probeTarget.isProbeSafeBaseUrl("https://api.example.com/v1"), true);
});
test("plain http is rejected — no registry entry uses it, no reason to widen the surface", () => {
assert.equal(probeTarget.isProbeSafeBaseUrl("http://api.example.com/v1"), false);
});
test("non-http(s) schemes are rejected", () => {
for (const url of ["ws://api.example.com", "wss://api.example.com", "ftp://x", "devin://x"]) {
assert.equal(probeTarget.isProbeSafeBaseUrl(url), false, url);
}
});
test("a query string on the base is rejected", () => {
assert.equal(probeTarget.isProbeSafeBaseUrl("https://api.example.com/v1?beta=true"), false);
});
test("empty or non-string input is rejected", () => {
assert.equal(probeTarget.isProbeSafeBaseUrl(""), false);
});
// ─── resolveEligibleProviderUrl: pure, against real registry entries ──
test("groq resolves through its real registry baseUrl, /chat/completions swapped for /models", () => {
assert.equal(
probeTarget.resolveEligibleProviderUrl("groq"),
"https://api.groq.com/openai/v1/models"
);
});
test("antigravity is ineligible: its registry entry has baseUrls[], no singular baseUrl", () => {
assert.equal(probeTarget.resolveEligibleProviderUrl("antigravity"), null);
});
test("a provider id with no registry entry at all is ineligible", () => {
assert.equal(probeTarget.resolveEligibleProviderUrl("no-such-provider-8411"), null);
});
// ─── isProviderTargetEnabled: the kill switch ──────────────────────────
test("the switch defaults to enabled", () => {
assert.equal(probeTarget.isProviderTargetEnabled({}), true);
});
test('only the literal string "false" disables it', () => {
assert.equal(
probeTarget.isProviderTargetEnabled({ PROXY_HEALTH_USE_PROVIDER_TARGET: "false" }),
false
);
for (const raw of ["0", "no", "False", "", undefined]) {
assert.equal(
probeTarget.isProviderTargetEnabled({ PROXY_HEALTH_USE_PROVIDER_TARGET: raw }),
true,
`expected enabled for ${JSON.stringify(raw)}`
);
}
});
// ─── resolveProviderProbeTarget: wiring against a real database ───────
test("a proxy with no assignment resolves to null", async () => {
const proxy = await seedProxy("Unassigned Proxy");
assert.equal(await probeTarget.resolveProviderProbeTarget(proxy!.id), null);
});
test("a proxy assigned to an eligible provider resolves to its models URL", async () => {
const proxy = await seedProxy("Groq-Assigned Proxy");
await proxiesDb.assignProxyToScope("provider", "groq", proxy!.id);
assert.equal(
await probeTarget.resolveProviderProbeTarget(proxy!.id),
"https://api.groq.com/openai/v1/models"
);
});
test("a proxy assigned to an ineligible provider (antigravity) falls back to null", async () => {
const proxy = await seedProxy("Antigravity-Assigned Proxy");
await proxiesDb.assignProxyToScope("provider", "antigravity", proxy!.id);
assert.equal(await probeTarget.resolveProviderProbeTarget(proxy!.id), null);
});
test("the switch off skips resolution even for an eligible assignment", async () => {
const proxy = await seedProxy("Switch-Off Proxy");
await proxiesDb.assignProxyToScope("provider", "groq", proxy!.id);
assert.equal(
await probeTarget.resolveProviderProbeTarget(proxy!.id, {
PROXY_HEALTH_USE_PROVIDER_TARGET: "false",
}),
null
);
});
test("a global-scope assignment (no provider) is ignored, not mistaken for eligible", async () => {
const proxy = await seedProxy("Global-Assigned Proxy");
await proxiesDb.assignProxyToScope("global", null, proxy!.id);
assert.equal(await probeTarget.resolveProviderProbeTarget(proxy!.id), null);
});
test("multiple assignments: the first eligible provider wins, ineligible ones are skipped", async () => {
const proxy = await seedProxy("Multi-Assigned Proxy");
await proxiesDb.assignProxyToScope("provider", "antigravity", proxy!.id);
await proxiesDb.assignProxyToScope("provider", "groq", proxy!.id);
const target = await probeTarget.resolveProviderProbeTarget(proxy!.id);
assert.equal(target, "https://api.groq.com/openai/v1/models");
});