mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 14:22:14 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
20 lines
1.0 KiB
TypeScript
20 lines
1.0 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { getUnsupportedParams } from "../../open-sse/config/providerRegistry.ts";
|
|
|
|
// Regression guard for `TypeError: entry.models is not iterable`.
|
|
//
|
|
// A registry entry can legitimately have no static model catalogue — e.g. a
|
|
// proxy provider whose `models` is `undefined`. The byModelId map builder
|
|
// already tolerates this (`if (entry.models && entry.models.length > 0)`),
|
|
// but `getUnsupportedParams` had two unguarded accesses:
|
|
// - `ensureUnsupportedParamsPopulated()` iterated `entry.models` for EVERY entry,
|
|
// - the per-provider lookup did `entry?.models.find(...)`.
|
|
// Either one threw on the first call once a model-less entry existed, which made
|
|
// `handleChatCore` report "All models failed" for unrelated requests.
|
|
|
|
test("getUnsupportedParams does not throw when a registry entry has no models", () => {
|
|
// This call triggers ensureUnsupportedParamsPopulated() which walks ALL entries.
|
|
assert.doesNotThrow(() => getUnsupportedParams("openai", "gpt-4o"));
|
|
});
|