Files
OmniRoute/tests/unit/provider-scoped-models-route.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

239 lines
7.2 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-provider-models-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const serviceModelsDb = await import("../../src/lib/db/serviceModels.ts");
const providerModelsRoute =
await import("../../src/app/api/v1/providers/[provider]/models/route.ts");
interface SeedConnectionOverrides {
authType?: string;
name?: string;
apiKey?: string | null;
accessToken?: string | null;
isActive?: boolean;
testStatus?: string;
providerSpecificData?: Record<string, unknown>;
}
type ProviderModelsResponse = {
data: Array<Record<string, unknown>>;
object?: string;
error?: {
message?: string;
code?: string;
type?: string;
};
};
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
async function seedConnection(provider: string, overrides: SeedConnectionOverrides = {}) {
return providersDb.createProviderConnection({
provider,
authType: overrides.authType || "apikey",
name: overrides.name || `${provider}-${Math.random().toString(16).slice(2, 8)}`,
apiKey: overrides.apiKey || "sk-test",
accessToken: overrides.accessToken,
isActive: overrides.isActive ?? true,
testStatus: overrides.testStatus || "active",
providerSpecificData: overrides.providerSpecificData || {},
});
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("provider models route returns only selected provider models with unprefixed ids", async () => {
await seedConnection("openai", { name: "openai-main" });
await seedConnection("claude", {
authType: "oauth",
name: "claude-main",
apiKey: null,
accessToken: "claude-access",
});
await combosDb.createCombo({
name: "team-router",
strategy: "priority",
models: ["openai/gpt-4o"],
});
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/openai/models"),
{
params: Promise.resolve({ provider: "openai" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.length > 0);
assert.equal(
ids.some((id: string) => id.includes("/")),
false
);
assert.equal(
body.data.some((model) => String(model.owned_by) !== "openai"),
false
);
assert.equal(ids.includes("team-router"), false);
});
test("provider models route accepts provider alias in path", async () => {
await seedConnection("claude", {
authType: "oauth",
name: "claude-main",
apiKey: null,
accessToken: "claude-access",
});
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/cc/models"),
{
params: Promise.resolve({ provider: "cc" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.includes("claude-sonnet-4-6"));
assert.equal(
ids.some((id: string) => id.startsWith("cc/") || id.startsWith("claude/")),
false
);
});
test("provider models route supports service provider 9router", async () => {
serviceModelsDb.saveServiceModels("9router", [
{ id: "gpt-4o-mini", name: "Local9R Test", available: true },
]);
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/9router/models"),
{
params: Promise.resolve({ provider: "9router" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.includes("gpt-4o-mini"));
assert.equal(
ids.some((id: string) => id.includes("/")),
false
);
});
test("provider models route supports service provider cliproxyapi", async () => {
serviceModelsDb.saveServiceModels("cliproxyapi", [
{ id: "llama-3", name: "Clip Test", available: true },
]);
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/cliproxyapi/models"),
{
params: Promise.resolve({ provider: "cliproxyapi" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.includes("llama-3"));
assert.equal(
ids.some((id: string) => id.includes("/")),
false
);
});
test("provider models route returns 400 for unknown provider", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/nope/models"),
{
params: Promise.resolve({ provider: "nope" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
assert.equal(response.status, 400);
assert.equal(body.error.code, "invalid_provider");
});
test("provider models route resolves local provider by canonical ID (ollama-local)", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/ollama-local/models"),
{
params: Promise.resolve({ provider: "ollama-local" }),
}
);
// Must NOT return 400 invalid_provider — should resolve via catalog fallback
assert.notEqual(response.status, 400, "ollama-local must not return 400");
const body = (await response.json()) as ProviderModelsResponse;
assert.notEqual(
body.error?.code,
"invalid_provider",
"ollama-local must not be rejected as unknown provider"
);
});
test("provider models route resolves local provider by alias (ollama)", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/ollama/models"),
{
params: Promise.resolve({ provider: "ollama" }),
}
);
assert.notEqual(response.status, 400, "ollama (alias) must not return 400");
const body = (await response.json()) as ProviderModelsResponse;
assert.notEqual(
body.error?.code,
"invalid_provider",
"ollama (alias) must not be rejected as unknown provider"
);
});
test("provider models route resolves another local provider by ID (lm-studio)", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/lm-studio/models"),
{
params: Promise.resolve({ provider: "lm-studio" }),
}
);
assert.notEqual(response.status, 400, "lm-studio must not return 400");
const body = (await response.json()) as ProviderModelsResponse;
assert.notEqual(
body.error?.code,
"invalid_provider",
"lm-studio must not be rejected as unknown provider"
);
});