Files
OmniRoute/tests/unit/provider-validation-web-cookie-auth007.test.ts
Diego Rodrigues de Sa e Souza 7d57d9f4a1 fix(providers): retire common ChatGPT Web provider (#11754)
Rebased onto the current release/v3.8.51 tip as part of a combined provider-retirement/provenance merge batch (Designer Web, Felo Web, Runtime, GPL-derived removal, Qwen Web already landed). Large conflict set (this is the biggest PR in the batch — the common ChatGPT Web provider touches chat, images, count-tokens, session leases, and combos). Conflicts resolved:

- `open-sse/config/providers/registry/chatgpt-web/*`, `open-sse/executors/chatgpt-web*`, `open-sse/handlers/imageGeneration/providers/chatgptWeb.ts`, and their tests: kept deleted, matching the PR's stated scope.
- `open-sse/config/providers/registry/minimax/web/index.ts`, `open-sse/handlers/imageGeneration/providers/geminiWeb.ts`, `open-sse/executors/gemini-web.ts`'s stale image-mode branch: base-drift collisions against already-merged sibling retirements (#11691, #11708) — kept deleted / dropped the dead code, since this PR's own branch forked before those merged.
- `src/shared/constants/reservedProviderPrefixes.ts`, `open-sse/executors/index.ts`, `executorProxy.ts`, `virtualFactory.ts`, `autoStrategy.ts`, `src/lib/db/providers.ts`, `src/sse/handlers/chat.ts`: combined the Designer + Runtime (Felo/Qwen) + common-ChatGPT-Web retirement guard calls at each shared chokepoint — compute-once-then-OR pattern, consistent with prior combinations in this batch.
- `src/sse/services/model.ts` / `src/sse/handlers/chatHelpers.ts`: adopted this PR's new `getModelInfoOrRetirementResponse()` central wrapper (a real improvement over ad-hoc try/catch), and extended it to also catch the Designer + Runtime retirement errors it didn't originally cover, so the consolidation doesn't regress the other two mechanisms.
- `src/app/api/v1/images/edits/route.ts`: this PR moved the retirement check earlier (before `enforceApiKeyPolicy`) but left the old later call+catch block in place from base drift — removed the now-redundant duplicate `resolveImageRouteModel()` call and merged the Designer catch into the earlier one.
- `open-sse/config/imageRegistry.ts`, `tests/snapshots/executors/executor-map.json` (`keyCount` recomputed to 133), `tests/snapshots/provider/translate-path.json`: same "both sides inserted a different retired provider at the same slot" pattern — resolved by dropping both.
- `tests/unit/chatcore-executor-proxy.test.ts`, `provider-node-reserved-prefix.test.ts`, `combo-auto-candidate-expansion.test.ts`, `messages-count-tokens-route.test.ts`, `virtual-auto-combo.test.ts`: split into independent per-mechanism test blocks (established pattern); `virtual-auto-combo.test.ts`'s old "includes cookie web-session providers" positive-inclusion test (which used chatgpt-web as its example) was retired along with the provider and replaced by this PR's negative-exclusion test for the same slot.
- `docs/architecture/ARCHITECTURE.md`, `CODEBASE_DOCUMENTATION.md` (+ 4 i18n mirrors), `README.md`, `FREE-TIERS-GUIDE.md`, `docs/diagrams/free-tier-budget.svg`, `docs/screenshots/free-tier-budget-card.svg`, `docs/reference/PROVIDER_REFERENCE.md`: recomputed every stale count from the real merged state — 104 executors (`countFiles` gate logic), 351 providers (regenerated via `gen:provider-reference`), 152/351 `hasFree` entries, 445/438/7 free-tier catalog rows, 13 ToS-avoid providers, budget-card regenerated via its real generator script. One doc conflict (`oauth/` module list) needed picking HEAD's side specifically — theirs still listed the already-removed `raycast` module instead of the real `openference`.
- `config/quality/test-masking-allowlist.json`: additive merge of the PR's 17 `_deletedWithReplacement` entries alongside the batch's existing ones (one real duplicate-key mistake in my first pass, caught and fixed via a `object_pairs_hook` duplicate-key check before finalizing).

Also fixed two real, unrelated-to-my-merge issues surfaced by the focused suite:
- `tests/unit/resolve-web-provider-host.test.ts`: the PR's own test had a typo — it asserted `perplexity-web`'s resolved host as `"perplexity.ai"`, but the provider's registered `website` is `"https://www.perplexity.ai"` and the resolver returns the URL's `host` verbatim (no www-stripping), so the correct value is `"www.perplexity.ai"` (consistent with the same test's own `url` assertion).
- `tests/unit/hard-session-lease-bypass-inventory.test.ts`: this golden call-site inventory was already stale on the pristine post-#11713 tip (confirmed via a throwaway probe worktree) — `src/lib/db/providers.ts`'s 3 connection-fallback sites and a third `src/app/api/providers/route.ts` site were never added to the golden list by the earlier-merged #11698/#11720 PRs. Updated it to the real current inventory (dated inline comments explain each delta and which PR introduced it), plus this PR's own legitimate deltas (image-edits duplicate-call removal, `ChatGptWebExecutor.execute()` site removed).

Focused suite green (433/433 across executor-proxy, reserved-prefix, hard-session-lease-bypass-inventory, resolve-web-provider-host, retirement/runtime-block/source-retirement/management-retirement/image-handler-retirement, migration-168, combo-auto-candidate-expansion, virtual-auto-combo, executor-map-golden and siblings), plus `typecheck:core`, `check-file-size`, and `check-changelog-integrity` clean. Thanks for the thorough provenance-hold retirement work — appreciated.
2026-08-28 06:52:46 -03:00

109 lines
4.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
// The validator probes the provider's /models endpoint via validationRead → safeOutboundFetch
// → fetchWithTimeout, which reads `globalThis.fetch` dynamically at CALL time (#7058 — routed
// through the proxy-aware patched fetch instead of a bypassing directHttpsRequest). Importing
// validation.ts pulls in the proxy-patch module, which installs its own `globalThis.fetch`
// exactly once at import time — so the mock must be (re)installed AFTER the import, not before,
// or the patch silently clobbers it. A mutable `nextResponse` lets each test vary the probe
// result, and `fetchCalls` proves the mocked probe ran rather than the live network.
let nextResponse: { status: number; body: string } = { status: 200, body: "{}" };
let fetchCalls = 0;
const { validateWebCookieProvider } = await import("../../src/lib/providers/validation.ts");
globalThis.fetch = (async () => {
fetchCalls++;
return new Response(nextResponse.body, {
status: nextResponse.status,
headers: { "content-type": "application/json" },
});
}) as typeof fetch;
function mockFetch(status: number, body: string) {
nextResponse = { status, body };
fetchCalls = 0;
}
test("should_return_AUTH_007_when_models_endpoint_returns_401", async () => {
mockFetch(401, JSON.stringify({ error: "unauthorized" }));
const result = await validateWebCookieProvider({
provider: "huggingchat",
apiKey: "expired_cookie=session=abc123",
providerSpecificData: {},
});
assert.equal(fetchCalls, 1, "the /models probe must be the mocked fetch, not the live network");
assert.equal(result.valid, false);
assert.equal(result.errorCode, "AUTH_007");
assert.equal(result.error, "SESSION_EXPIRED");
});
test("should_return_AUTH_007_when_models_endpoint_returns_403", async () => {
mockFetch(403, JSON.stringify({ error: "forbidden" }));
const result = await validateWebCookieProvider({
provider: "huggingchat",
apiKey: "expired_cookie=session=abc123",
providerSpecificData: {},
});
assert.equal(fetchCalls, 1, "the /models probe must be the mocked fetch, not the live network");
assert.equal(result.valid, false);
assert.equal(result.errorCode, "AUTH_007");
assert.equal(result.error, "SESSION_EXPIRED");
});
test("should_return_unsupported_when_models_endpoint_returns_200_for_a_conversation_baseUrl", async () => {
// #7857: huggingchat's registry baseUrl is a conversation endpoint,
// not a real API root, so
// "${baseUrl}/models" is a path that never existed upstream. A 200 from that
// nonsense path (e.g. a login-page SPA shell) is not a meaningful auth signal and
// is indistinguishable from a genuinely valid session — it must be reported as
// unsupported, not silently accepted as valid.
mockFetch(200, JSON.stringify({ ok: true, data: [] }));
const result = await validateWebCookieProvider({
provider: "huggingchat",
apiKey: "valid_cookie=session=abc123",
providerSpecificData: {},
});
assert.equal(fetchCalls, 1, "the /models probe must be the mocked fetch, not the live network");
assert.equal(result.valid, false);
assert.equal(result.unsupported, true);
});
test("should_return_unsupported_when_provider_not_in_registry", async () => {
mockFetch(200, "{}");
const result = await validateWebCookieProvider({
provider: "nonexistent-provider",
apiKey: "some_cookie",
providerSpecificData: {},
});
// Unknown provider short-circuits before any network probe.
assert.equal(fetchCalls, 0);
assert.equal(result.valid, false);
assert.equal(result.unsupported, true);
});
test("should_return_error_when_cookie_is_empty", async () => {
mockFetch(200, "{}");
const result = await validateWebCookieProvider({
provider: "huggingchat",
apiKey: "",
providerSpecificData: {},
});
// Empty cookie short-circuits before any network probe.
assert.equal(fetchCalls, 0);
assert.equal(result.valid, false);
assert.equal(result.unsupported, false);
assert.match(result.error, /cookie/i);
});