Files
OmniRoute/tests/unit/providers-route-codex-account-pool.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

218 lines
7.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { makeManagementSessionRequest } from "../helpers/managementSession.ts";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-codex-provider-route-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.ALLOW_API_KEY_REVEAL = "false";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const quotaCache = await import("../../src/domain/quotaCache.ts");
const auth = await import("../../src/sse/services/auth.ts");
const providersRoute = await import("../../src/app/api/providers/route.ts");
test.after(() => {
quotaCache.__clearForTests();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("GET keeps one parent row and projects raw Codex state without exposing credentials", async () => {
const cooldown = new Date(Date.now() + 60_000).toISOString();
const codex = await providersDb.createProviderConnection({
provider: "codex",
authType: "oauth",
name: "Codex parent",
apiKey: "codex-api-secret",
accessToken: "codex-access-secret",
refreshToken: "codex-refresh-secret",
idToken: "codex-id-secret",
providerSpecificData: {
consoleApiKey: "nested-secret",
accessToken: "nested-access-secret",
codexScopeRateLimitedUntil: { spark: cooldown },
codexQuotaStateByScope: {
spark: {
usage5h: 100,
limit5h: 100,
resetAt5h: cooldown,
observedAt: "2026-01-01T00:00:00.000Z",
},
},
codexExhaustedWindowByScope: { spark: "5h" },
},
});
const openai = await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "OpenAI parent",
apiKey: "openai-api-secret",
});
const response = await providersRoute.GET(
await makeManagementSessionRequest("http://localhost/api/providers")
);
const body = (await response.json()) as {
connections: Array<Record<string, unknown>>;
total: number;
};
assert.equal(response.status, 200);
assert.equal(body.total, 2);
assert.equal(body.connections.length, 2);
assert.deepEqual(
new Set(body.connections.map((connection) => connection.id)),
new Set([codex.id, openai.id])
);
const codexRow = body.connections.find((connection) => connection.id === codex.id);
const openaiRow = body.connections.find((connection) => connection.id === openai.id);
assert.ok(codexRow);
assert.ok(openaiRow);
assert.equal("codexAccountPool" in openaiRow, false);
const pool = codexRow.codexAccountPool as {
parentConnectionId: string;
aggregate: { status: string; limitedChildCount: number };
children: Array<Record<string, unknown>>;
};
assert.equal(pool.parentConnectionId, codex.id);
assert.equal(pool.children.length, 2);
assert.deepEqual(
pool.children.map((child) => child.key),
[
{ parentConnectionId: codex.id, scope: "codex" },
{ parentConnectionId: codex.id, scope: "spark" },
]
);
const spark = pool.children[1] as {
unavailable: boolean;
cooldown: { active: boolean; rateLimitedUntil: string | null };
quota: { exhaustedWindow: string | null };
};
assert.equal(spark.unavailable, true);
assert.equal(spark.cooldown.active, true);
assert.equal(spark.cooldown.rateLimitedUntil, cooldown);
assert.equal(spark.quota.exhaustedWindow, "5h");
assert.equal("connectionId" in pool.children[0], false);
const serialized = JSON.stringify(body);
for (const secret of [
"codex-api-secret",
"codex-access-secret",
"codex-refresh-secret",
"codex-id-secret",
"nested-secret",
"nested-access-secret",
"openai-api-secret",
]) {
assert.equal(serialized.includes(secret), false, `response leaked ${secret}`);
}
const safeProviderData = codexRow.providerSpecificData as Record<string, unknown>;
assert.equal("consoleApiKey" in safeProviderData, false);
});
test("GET projects the same scoped Codex quota observations used by routing", async () => {
const resetAt5h = new Date(Date.now() + 5 * 60 * 60 * 1000).toISOString();
const resetAt7d = new Date(Date.now() + 7 * 24 * 60 * 60 * 1000).toISOString();
const codex = await providersDb.createProviderConnection({
provider: "codex",
authType: "oauth",
name: "Codex cache-only quota",
quotaVisible: true,
providerSpecificData: {
limitPolicy: {
enabled: true,
thresholdPercent: 99,
windows: ["session", "weekly"],
},
},
});
quotaCache.setQuotaCache(codex.id, "codex", {
session: { remainingPercentage: 50, resetAt: resetAt5h },
weekly: { remainingPercentage: 50, resetAt: resetAt7d },
});
quotaCache.setQuotaCache(codex.id, "codex", {
session: { remainingPercentage: 0, resetAt: resetAt5h },
weekly: { remainingPercentage: 75, resetAt: resetAt7d },
gpt_5_3_codex_spark_session: { remainingPercentage: 60, resetAt: resetAt5h },
gpt_5_3_codex_spark_weekly: { remainingPercentage: 40, resetAt: resetAt7d },
});
const routing = auth.evaluateQuotaLimitPolicy(
"codex",
{
id: codex.id,
providerSpecificData: codex.providerSpecificData ?? {},
} as never,
"gpt-5.5-codex"
);
assert.equal(routing.blocked, true);
assert.deepEqual(routing.reasons, ["session usage 100%"]);
const response = await providersRoute.GET(
await makeManagementSessionRequest("http://localhost/api/providers?provider=codex")
);
const body = (await response.json()) as {
connections: Array<{
id: string;
codexAccountPool: {
children: Array<{
key: { scope: "codex" | "spark" };
quota: {
observedAt: string | null;
windows: Record<
"5h" | "7d",
{
usage: number | null;
limit: number | null;
resetAt: string | null;
usedPercentage: number | null;
} | null
>;
};
}>;
};
}>;
};
const pool = body.connections.find((connection) => connection.id === codex.id)?.codexAccountPool;
assert.ok(pool);
const general = pool.children.find((child) => child.key.scope === "codex");
const spark = pool.children.find((child) => child.key.scope === "spark");
assert.ok(general);
assert.ok(spark);
assert.deepEqual(general.quota.windows["5h"], {
usage: null,
limit: null,
resetAt: resetAt5h,
usedPercentage: 100,
});
assert.deepEqual(general.quota.windows["7d"], {
usage: null,
limit: null,
resetAt: resetAt7d,
usedPercentage: 25,
});
assert.deepEqual(spark.quota.windows["5h"], {
usage: null,
limit: null,
resetAt: resetAt5h,
usedPercentage: 40,
});
assert.deepEqual(spark.quota.windows["7d"], {
usage: null,
limit: null,
resetAt: resetAt7d,
usedPercentage: 60,
});
assert.ok(general.quota.observedAt);
assert.equal(general.quota.observedAt, spark.quota.observedAt);
});