mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-09 16:32:12 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
67 lines
2.9 KiB
TypeScript
67 lines
2.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
// Regression test for the providers-route PATCH gap: the OpenAPI spec and the
|
|
// CLI (`omniroute providers rotate`, generated api-commands) both use
|
|
// PATCH /api/providers/[id], but the route only implemented PUT — PATCH
|
|
// requests 405'd and `providers rotate --new-key` silently failed while
|
|
// reporting success. See PR fix: the route now exports a PATCH handler that
|
|
// delegates to PUT (both apply the same partial-update schema).
|
|
|
|
async function loadRoute() {
|
|
return await import(new URL("../../src/app/api/providers/[id]/route.ts", import.meta.url));
|
|
}
|
|
|
|
test("providers [id] route exports a PATCH handler (CLI rotate 405 regression)", async () => {
|
|
const route = await loadRoute();
|
|
assert.equal(
|
|
typeof route.PATCH,
|
|
"function",
|
|
"PATCH handler must exist — CLI rotate sends PATCH per the OpenAPI spec"
|
|
);
|
|
});
|
|
|
|
test("PATCH handler delegates to PUT (same partial-update semantics)", async () => {
|
|
const route = await loadRoute();
|
|
// The PATCH export delegates to PUT; both share the same update logic and
|
|
// are distinct function references (wrapper). A fixed status expectation is
|
|
// environment-dependent: management auth is enforced on dev (PUT returns 401
|
|
// without a credential) but NOT in the CI unit-test env, where the flow
|
|
// falls through to "Connection not found" (404) for an unknown id. So assert
|
|
// on delegation equivalence instead: PATCH must never 405 (the regression)
|
|
// and must return the exact same status as PUT for the same input.
|
|
const ctx = { params: Promise.resolve({ id: "test-id" }) };
|
|
// Fresh Request per invocation: PUT reads the body via request.json(),
|
|
// which consumes the body stream — reusing one Request for both calls would
|
|
// give the second call an empty body (400 validation) vs the first (404
|
|
// not-found), a false mismatch. Identical inputs must produce identical
|
|
// statuses.
|
|
const patchRequest = new Request("http://localhost/api/providers/test-id", {
|
|
method: "PATCH",
|
|
body: JSON.stringify({ name: "x" }),
|
|
});
|
|
const putRequest = new Request("http://localhost/api/providers/test-id", {
|
|
method: "PUT",
|
|
body: JSON.stringify({ name: "x" }),
|
|
});
|
|
const patchResult = await route.PATCH(patchRequest, ctx);
|
|
const putResult = await route.PUT(putRequest, ctx);
|
|
assert.ok(patchResult, "PATCH should return a response, not 405");
|
|
assert.notEqual(
|
|
patchResult.status,
|
|
405,
|
|
"PATCH must be routed — before the fix Next.js returned 405 Method Not Allowed"
|
|
);
|
|
assert.equal(
|
|
patchResult.status,
|
|
putResult.status,
|
|
"PATCH must delegate to PUT's handler (identical status for the same input)"
|
|
);
|
|
});
|
|
|
|
test("providers [id] route still exports PUT and DELETE handlers", async () => {
|
|
const route = await loadRoute();
|
|
assert.equal(typeof route.PUT, "function");
|
|
assert.equal(typeof route.DELETE, "function");
|
|
});
|