Files
OmniRoute/tests/unit/proxy-assigned-unavailable-6246.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

160 lines
5.2 KiB
TypeScript

/**
* TDD — #6246 IP leak (part 1, fail-closed).
*
* When a proxy is ASSIGNED to a connection (account/provider/global scope) but is
* dead/inactive, `resolveProxyForConnection` returns a direct result (no alive
* proxy resolved). The chat path used to egress DIRECTLY in that case, leaking
* the operator's real IP. The fix is a fail-closed guard: if the only reason a
* connection resolves to direct is that its ASSIGNED proxy is dead, block instead
* of leaking. Explicit "proxy off" toggles are a deliberate direct choice and must
* NOT be treated as a leak.
*
* This test exercises the pure DB predicate `hasBlockingProxyAssignment`, which
* encodes exactly that decision (honoring the global + connection proxy toggles).
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-proxy-6246-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-secret";
const core = await import("../../src/lib/db/core.ts");
const proxiesDb = await import("../../src/lib/db/proxies.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
function setGlobalProxyEnabled(enabled: boolean) {
const db = core.getDbInstance();
db.prepare(
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('settings', 'proxyEnabled', ?)"
).run(JSON.stringify(enabled));
}
async function makeConnection(): Promise<string> {
const conn = await providersDb.createProviderConnection({
provider: "openai",
authType: "apiKey",
name: `Conn ${Date.now()} ${Math.random()}`,
apiKey: "sk-test",
});
return (conn as { id: string }).id;
}
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("BLOCKS: an account proxy assigned but marked inactive (the IP-leak case)", async () => {
await resetStorage();
const connId = await makeConnection();
const proxy = await proxiesDb.createProxy({
name: "Dead paid proxy",
type: "http",
host: "127.0.0.1",
port: 9001,
});
await proxiesDb.updateProxy(proxy!.id, { status: "inactive" });
await proxiesDb.assignProxyToScope("account", connId, proxy!.id);
assert.equal(
proxiesDb.hasBlockingProxyAssignment(connId),
true,
"a dead assigned proxy must block, not fall back to a direct egress"
);
});
test("ALLOWS DIRECT: a connection with no proxy assignment at all", async () => {
await resetStorage();
const connId = await makeConnection();
assert.equal(
proxiesDb.hasBlockingProxyAssignment(connId),
false,
"no assignment = user never configured a proxy = direct is legitimate"
);
});
test("NOT BLOCKING: an assigned proxy that is still ALIVE", async () => {
await resetStorage();
const connId = await makeConnection();
const proxy = await proxiesDb.createProxy({
name: "Live proxy",
type: "http",
host: "127.0.0.1",
port: 9002,
});
await proxiesDb.assignProxyToScope("account", connId, proxy!.id);
assert.equal(
proxiesDb.hasBlockingProxyAssignment(connId),
false,
"an alive assigned proxy resolves normally; nothing to block"
);
});
test("EXPLICIT DIRECT: global proxyEnabled=false is a deliberate choice, not a leak", async () => {
await resetStorage();
const connId = await makeConnection();
const proxy = await proxiesDb.createProxy({
name: "Dead proxy",
type: "http",
host: "127.0.0.1",
port: 9003,
});
await proxiesDb.updateProxy(proxy!.id, { status: "inactive" });
await proxiesDb.assignProxyToScope("account", connId, proxy!.id);
setGlobalProxyEnabled(false);
assert.equal(
proxiesDb.hasBlockingProxyAssignment(connId),
false,
"operator turned proxying off globally — direct is intended, do not block"
);
});
test("BLOCKS: a dead GLOBAL proxy assignment blocks any connection", async () => {
await resetStorage();
const connId = await makeConnection();
const proxy = await proxiesDb.createProxy({
name: "Dead global proxy",
type: "http",
host: "127.0.0.1",
port: 9004,
});
await proxiesDb.updateProxy(proxy!.id, { status: "error" });
await proxiesDb.assignProxyToScope("global", null, proxy!.id);
assert.equal(
proxiesDb.hasBlockingProxyAssignment(connId),
true,
"a dead global proxy assignment must block, not leak direct"
);
});
test("BLOCKS: a dead no-auth provider proxy assignment", async () => {
await resetStorage();
const proxy = await proxiesDb.createProxy({
name: "Dead no-auth proxy",
type: "http",
host: "127.0.0.1",
port: 9005,
});
await proxiesDb.updateProxy(proxy!.id, { status: "inactive" });
await proxiesDb.assignProxyToScope("provider", "opencode", proxy!.id);
assert.equal(
proxiesDb.hasBlockingProxyAssignment("noauth", "opencode"),
true,
"a dead no-auth provider proxy must block instead of allowing direct egress"
);
});