Files
OmniRoute/tests/unit/proxy-batch-routes-5918.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

102 lines
3.8 KiB
TypeScript

/**
* Route coverage for #5918 proxy management endpoints:
* POST /api/settings/proxies/batch-delete
* POST /api/settings/proxies/auto-test
*
* DB-backed and network-free: batch-delete is exercised end-to-end against a
* temp SQLite DB; auto-test is exercised only on its no-proxy early-return path
* (which returns before any outbound probe), so no real network is touched.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-proxy-batch-5918-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-secret";
delete process.env.INITIAL_PASSWORD; // auth not required in this test env
const core = await import("../../src/lib/db/core.ts");
const proxiesDb = await import("../../src/lib/db/proxies.ts");
const { POST: batchDeletePost } =
await import("../../src/app/api/settings/proxies/batch-delete/route.ts");
const { POST: autoTestPost } =
await import("../../src/app/api/settings/proxies/auto-test/route.ts");
function jsonRequest(body: unknown): Request {
return new Request("http://localhost/api/settings/proxies/batch-delete", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify(body),
});
}
async function resetStorage() {
delete process.env.INITIAL_PASSWORD;
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("batch-delete removes multiple existing proxies in one request", async () => {
await resetStorage();
const a = await proxiesDb.createProxy({ name: "A", type: "http", host: "127.0.0.1", port: 8080 });
const b = await proxiesDb.createProxy({ name: "B", type: "http", host: "127.0.0.1", port: 8081 });
assert.ok(a?.id && b?.id);
const res = await batchDeletePost(jsonRequest({ ids: [a.id, b.id] }));
assert.equal(res.status, 200);
const body = await res.json();
assert.equal(body.deleted, 2);
assert.equal(body.failed, 0);
// Both are actually gone from the store.
const { items: remaining } = await proxiesDb.listProxies({ includeSecrets: false });
assert.equal(remaining.filter((p) => p.id === a.id || p.id === b.id).length, 0);
});
test("batch-delete reports non-existent ids as failed without throwing", async () => {
await resetStorage();
const res = await batchDeletePost(jsonRequest({ ids: ["does-not-exist"] }));
assert.equal(res.status, 200);
const body = await res.json();
assert.equal(body.deleted, 0);
assert.equal(body.failed, 1);
});
test("batch-delete rejects an empty ids array with 400 (validation, pre-DB)", async () => {
await resetStorage();
const res = await batchDeletePost(jsonRequest({ ids: [] }));
assert.equal(res.status, 400);
});
test("batch-delete rejects invalid JSON with 400", async () => {
await resetStorage();
const bad = new Request("http://localhost/x", {
method: "POST",
headers: { "content-type": "application/json" },
body: "{ not json",
});
const res = await batchDeletePost(bad);
assert.equal(res.status, 400);
});
test("auto-test returns an empty result set when there are no proxies (no network probe)", async () => {
await resetStorage();
const req = new Request("http://localhost/api/settings/proxies/auto-test", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({}),
});
const res = await autoTestPost(req);
assert.equal(res.status, 200);
const body = await res.json();
assert.deepEqual(body.results, []);
});