mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-20 05:42:19 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
46 lines
1.7 KiB
TypeScript
46 lines
1.7 KiB
TypeScript
/**
|
|
* Regression guard (PR #7046 / perf-api-pagination fallout): src/lib/db/proxies.ts
|
|
* `listProxies()` was changed to return `{ items, total }` for pagination, but
|
|
* open-sse/utils/proxyFallback.ts's getProxyCandidates() still did
|
|
* `const allProxies = await listProxies({ includeSecrets: true }); for (const p of
|
|
* allProxies) ...` — iterating the {items,total} envelope throws "is not
|
|
* iterable", which the surrounding try/catch silently swallows ("Table may not
|
|
* exist yet"). Net effect: every user-configured proxy silently vanishes from
|
|
* the fallback candidate list with no error surfaced anywhere.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-proxy-fallback-cand-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const proxiesDb = await import("../../src/lib/db/proxies.ts");
|
|
const { getProxyCandidates } = await import("../../open-sse/utils/proxyFallback.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("getProxyCandidates() surfaces user-configured proxies against the real listProxies() {items,total} shape", async () => {
|
|
await proxiesDb.createProxy({
|
|
name: "Candidate Proxy",
|
|
type: "http",
|
|
host: "203.0.113.50",
|
|
port: 8080,
|
|
username: "user-a",
|
|
password: "pass-a",
|
|
});
|
|
|
|
const candidates = await getProxyCandidates();
|
|
|
|
assert.ok(
|
|
candidates.some((url) => url.includes("203.0.113.50:8080")),
|
|
`expected a candidate for the seeded proxy, got: ${JSON.stringify(candidates)}`
|
|
);
|
|
});
|