mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 04:12:17 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
90 lines
3.4 KiB
TypeScript
90 lines
3.4 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// Persistence to SQLite only runs when shouldPersistToDisk is true
|
|
// (local mode: !isCloud && !isBuildPhase). Setting DATA_DIR to a fresh temp
|
|
// dir keeps the test in local mode; the assertions below would otherwise fail
|
|
// with no explanatory guard.
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-proxy-egress-ip-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const proxyLogger = await import("../../src/lib/proxyLogger.ts");
|
|
|
|
// Fresh DB + fresh in-memory buffer per test (mirrors
|
|
// proxy-logger-client-ip.test.ts). clearProxyLogs() runs BEFORE closeDbInstance()
|
|
// so it never reopens a closed DB.
|
|
function resetStorage() {
|
|
proxyLogger.clearProxyLogs();
|
|
core.closeDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(() => {
|
|
resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
core.closeDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("fresh install exposes egress_ip and the reconciler is idempotent", async () => {
|
|
const { ensureProxyLogsColumns, hasColumn } = await import("../../src/lib/db/schemaColumns.ts");
|
|
const db = core.getDbInstance();
|
|
assert.equal(hasColumn(db, "proxy_logs", "egress_ip"), true, "column exists after migration");
|
|
assert.doesNotThrow(() => ensureProxyLogsColumns(db));
|
|
assert.doesNotThrow(() => ensureProxyLogsColumns(db));
|
|
});
|
|
|
|
test("logProxyEvent persists egressIp into proxy_logs.egress_ip", () => {
|
|
proxyLogger.logProxyEvent({
|
|
status: "success",
|
|
provider: "codex",
|
|
targetUrl: "codex/gpt-5.5",
|
|
egressIp: "203.0.113.9",
|
|
});
|
|
proxyLogger.flushProxyLogsSync(); // persist the enqueued batch before the synchronous read
|
|
const db = core.getDbInstance();
|
|
const row = db.prepare("SELECT egress_ip FROM proxy_logs ORDER BY rowid DESC LIMIT 1").get() as {
|
|
egress_ip: string | null;
|
|
};
|
|
assert.equal(row.egress_ip, "203.0.113.9");
|
|
});
|
|
|
|
test("egress_ip survives a DB close/reopen cycle (on-disk)", () => {
|
|
proxyLogger.logProxyEvent({
|
|
status: "success",
|
|
provider: "openai",
|
|
egressIp: "198.51.100.7",
|
|
});
|
|
proxyLogger.flushProxyLogsSync(); // persist to disk BEFORE the close/reopen cycle
|
|
core.closeDbInstance();
|
|
const db = core.getDbInstance();
|
|
const row = db.prepare("SELECT egress_ip FROM proxy_logs ORDER BY rowid DESC LIMIT 1").get() as {
|
|
egress_ip: string | null;
|
|
};
|
|
assert.equal(row.egress_ip, "198.51.100.7");
|
|
});
|
|
|
|
test("egress_ip is NULL when not provided (never synthesized)", () => {
|
|
proxyLogger.logProxyEvent({ status: "success", provider: "claude" });
|
|
proxyLogger.flushProxyLogsSync(); // persist the enqueued batch before the synchronous read
|
|
const db = core.getDbInstance();
|
|
const row = db.prepare("SELECT egress_ip FROM proxy_logs ORDER BY rowid DESC LIMIT 1").get() as {
|
|
egress_ip: string | null;
|
|
};
|
|
assert.equal(row.egress_ip, null);
|
|
});
|
|
|
|
test("getProxyLogs search matches the egress IP", () => {
|
|
proxyLogger.logProxyEvent({ status: "success", provider: "codex", egressIp: "203.0.113.55" });
|
|
const [log] = proxyLogger.getProxyLogs({ search: "203.0.113.55" });
|
|
assert.ok(log, "expected a matching log");
|
|
assert.equal(log.egressIp, "203.0.113.55");
|
|
});
|