mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
78 lines
3.2 KiB
TypeScript
78 lines
3.2 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-puter-removed-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { REGISTRY } = await import("../../open-sse/config/providerRegistry.ts");
|
|
const { APIKEY_PROVIDERS } = await import("../../src/shared/constants/providers.ts");
|
|
const { FREE_MODEL_BUDGETS } = await import("../../open-sse/config/freeModelCatalog.data.ts");
|
|
const { hasSpecializedExecutor } = await import("../../open-sse/executors/index.ts");
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
|
|
// Regression guard: the Puter provider (id `puter`, alias `pu`,
|
|
// https://puter.com) was removed at the request of Puter's owner
|
|
// (Nariman Jelveh). It must stay out of every provider catalog, the
|
|
// executor map, and the free model catalog, and migration 152 must clean
|
|
// up any locally stored Puter configuration.
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("puter provider is removed from the chat registry (id and alias)", () => {
|
|
assert.equal(REGISTRY["puter"], undefined);
|
|
assert.equal(REGISTRY["pu"], undefined);
|
|
});
|
|
|
|
test("puter provider is removed from the API-key provider presets", () => {
|
|
assert.equal((APIKEY_PROVIDERS as Record<string, unknown>)["puter"], undefined);
|
|
});
|
|
|
|
test("puter has no entries in the free model catalog", () => {
|
|
const offenders = FREE_MODEL_BUDGETS.filter((b) => b.provider === "puter");
|
|
assert.deepEqual(offenders, []);
|
|
});
|
|
|
|
test("puter executor is removed from the executor map (id and alias)", () => {
|
|
assert.equal(hasSpecializedExecutor("puter"), false);
|
|
assert.equal(hasSpecializedExecutor("pu"), false);
|
|
});
|
|
|
|
test("migration 152 deletes stored puter configuration and is idempotent", () => {
|
|
const db = core.getDbInstance();
|
|
|
|
const applied = db
|
|
.prepare("SELECT version FROM _omniroute_migrations WHERE version = 152")
|
|
.get() as { version: number } | undefined;
|
|
assert.ok(applied, "migration 152 must be recorded as applied");
|
|
|
|
// Simulate a pre-removal install that still has Puter configuration, then
|
|
// re-apply the migration SQL and assert every row is cleaned up.
|
|
db.prepare(
|
|
"INSERT INTO provider_connections (id, provider, auth_type, name, is_active, created_at, updated_at) VALUES (?, ?, ?, ?, 1, datetime('now'), datetime('now'))"
|
|
).run("puter-conn-test", "puter", "apikey", "puter-main");
|
|
db.prepare(
|
|
"INSERT INTO key_value (namespace, key, value) VALUES ('customModels', 'puter', '[]')"
|
|
).run();
|
|
|
|
const sql = fs.readFileSync(
|
|
path.join(process.cwd(), "src/lib/db/migrations/152_remove_puter_provider.sql"),
|
|
"utf8"
|
|
);
|
|
db.exec(sql);
|
|
db.exec(sql); // idempotent — a second run must not throw
|
|
|
|
const conn = db.prepare("SELECT id FROM provider_connections WHERE provider = 'puter'").get();
|
|
assert.equal(conn, undefined, "puter provider_connections rows must be deleted");
|
|
|
|
const custom = db
|
|
.prepare("SELECT key FROM key_value WHERE namespace = 'customModels' AND key = 'puter'")
|
|
.get();
|
|
assert.equal(custom, undefined, "puter custom models must be deleted");
|
|
});
|