Files
OmniRoute/tests/unit/quota-cache-hydrate-5015.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

94 lines
3.2 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
/**
* PR #5015 — hydrate the in-memory quota cache from persisted snapshots.
*
* After a restart the in-memory quota cache is empty, so a connection that was
* known-exhausted before the restart looked healthy again until it was queried
* organically and re-fetched. `isAccountQuotaExhausted` now lazily hydrates the
* cache from `quota_snapshots` on the first miss, so persisted exhaustion is
* honoured immediately.
*
* Regression guard: without the hydration path, a fresh cache returns `false`
* (no entry) even though a persisted exhausted snapshot exists — this test
* would fail on the pre-#5015 tip.
*/
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-quota-hydrate-5015-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const coreDb = await import("../../src/lib/db/core.ts");
const quotaSnapshotsDb = await import("../../src/lib/db/quotaSnapshots.ts");
const quotaCache = await import("../../src/domain/quotaCache.ts");
test.after(() => {
coreDb.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("#5015 isAccountQuotaExhausted hydrates exhausted state from a persisted snapshot", () => {
const connectionId = "conn-hydrate-5015";
// Persist an exhausted snapshot with no reset time (so it does not auto-advance)
// and a fresh created_at (so it does not expire via EXHAUSTED_TTL).
quotaSnapshotsDb.saveQuotaSnapshot({
provider: "openai",
connection_id: connectionId,
window_key: "weekly",
remaining_percentage: 0,
is_exhausted: 1,
next_reset_at: null,
window_duration_ms: null,
raw_data: JSON.stringify({ source: "test" }),
});
// The in-memory cache is empty for this connection (simulating a fresh boot).
// The getter must hydrate from the persisted snapshot and report exhaustion.
assert.equal(
quotaCache.isAccountQuotaExhausted(connectionId),
true,
"exhausted state persisted in quota_snapshots must hydrate the empty cache"
);
});
test("#5015 a connection with no snapshot is not reported exhausted", () => {
assert.equal(
quotaCache.isAccountQuotaExhausted("conn-unknown-5015"),
false,
"no snapshot → no hydration → not exhausted"
);
});
test("mixed persisted Z.AI quota windows keep chat requests eligible", () => {
const connectionId = "conn-zai-mixed-windows";
quotaSnapshotsDb.saveQuotaSnapshot({
provider: "zai",
connection_id: connectionId,
window_key: "session",
remaining_percentage: 93,
is_exhausted: 0,
next_reset_at: "2099-01-01T00:00:00.000Z",
window_duration_ms: null,
raw_data: null,
});
quotaSnapshotsDb.saveQuotaSnapshot({
provider: "zai",
connection_id: connectionId,
window_key: "mcp_monthly",
remaining_percentage: 0,
is_exhausted: 1,
next_reset_at: "2099-02-01T00:00:00.000Z",
window_duration_ms: null,
raw_data: null,
});
assert.equal(
quotaCache.isQuotaExhaustedForRequest(connectionId, "zai", "glm-5.2"),
false,
"an exhausted tools window must not block chat while the session window has quota"
);
});