mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
80 lines
3.4 KiB
TypeScript
80 lines
3.4 KiB
TypeScript
/**
|
|
* tests/unit/quota-combo-cli-providers.test.ts
|
|
*
|
|
* Regression: qtSd/ combos were generated from PROVIDER_MODELS, which is
|
|
* EMPTY for CLI/OAuth providers (codex, kimi, claude, …). A pool built from those
|
|
* providers produced ZERO combos → the quota key saw no models. The fix reads the
|
|
* provider REGISTRY (same source /v1/models uses), which has those providers.
|
|
*
|
|
* This test creates a "codex" pool and asserts syncQuotaCombos produces combos
|
|
* (it would have produced none before the fix).
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-quota-combo-cli-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const poolsDb = await import("../../src/lib/db/quotaPools.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const { syncQuotaCombos } = await import("../../src/lib/quota/quotaCombos.ts");
|
|
const { quotaModelName } = await import("../../src/lib/quota/quotaModelNaming.ts");
|
|
const combosDb = await import("../../src/lib/db/combos.ts");
|
|
const { REGISTRY } = await import("../../open-sse/config/providerRegistry.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
if (fs.existsSync(TEST_DATA_DIR))
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
const CLI_PROVIDER = "codex"; // absent from PROVIDER_MODELS, present in REGISTRY
|
|
|
|
test("syncQuotaCombos generates qtSd/ combos for a CLI provider (codex) via REGISTRY", async () => {
|
|
// Sanity: codex must be a REGISTRY provider with models (the fix's premise).
|
|
const regModels = (REGISTRY as Record<string, { models?: Array<{ id?: string }> }>)[CLI_PROVIDER]
|
|
?.models;
|
|
assert.ok(Array.isArray(regModels) && regModels.length > 0, "codex must have REGISTRY models");
|
|
const firstModelId = regModels.find((m) => typeof m.id === "string")?.id as string;
|
|
assert.ok(firstModelId, "codex must have at least one model id");
|
|
|
|
const conn = await providersDb.createProviderConnection({
|
|
provider: CLI_PROVIDER,
|
|
authType: "apikey",
|
|
name: "codex-cli",
|
|
apiKey: "sk-codex",
|
|
});
|
|
const connId = (conn as Record<string, unknown>).id as string;
|
|
const pool = poolsDb.createPool({ connectionId: connId, name: "Codex Quota" });
|
|
|
|
await syncQuotaCombos(pool.id);
|
|
|
|
// Before the fix this was 0. Now there must be one combo per codex model.
|
|
const all = await combosDb.getCombos();
|
|
const { QUOTA_MODEL_PREFIX: PREFIX } = await import("../../src/lib/quota/quotaModelNaming.ts");
|
|
const quotaCombos = all.filter(
|
|
(c) => typeof c.name === "string" && (c.name as string).startsWith(PREFIX)
|
|
);
|
|
assert.ok(quotaCombos.length > 0, "codex pool must produce qtSd/ combos (was 0 before fix)");
|
|
|
|
// B4: combos are named with the GROUP name ("GroupDemo" for default group), not pool name.
|
|
const expectedName = quotaModelName("GroupDemo", CLI_PROVIDER, firstModelId);
|
|
const combo = await combosDb.getComboByName(expectedName);
|
|
assert.ok(combo, `combo "${expectedName}" must exist for the codex pool`);
|
|
});
|