mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 06:12:17 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
178 lines
5.4 KiB
TypeScript
178 lines
5.4 KiB
TypeScript
/**
|
|
* tests/unit/quota-pool-single-provider.test.ts
|
|
*
|
|
* Task 3 — One provider per pool (block mixed-type).
|
|
*
|
|
* Coverage:
|
|
* - createPool with two DIFFERENT-provider connections → throws /single provider/i.
|
|
* - createPool with two SAME-provider connections → succeeds, connectionIds.length === 2.
|
|
* - updatePool replacing connectionIds with mixed-provider set → throws /single provider/i.
|
|
* - updatePool replacing connectionIds with same-provider set → succeeds.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// ── DB harness (same pattern as quota-pool-connections.test.ts) ─────────────
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-pool-single-prov-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const poolsDb = await import("../../src/lib/db/quotaPools.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
for (let attempt = 0; attempt < 10; attempt++) {
|
|
try {
|
|
if (fs.existsSync(TEST_DATA_DIR)) {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
break;
|
|
} catch (err: any) {
|
|
if ((err?.code === "EBUSY" || err?.code === "EPERM") && attempt < 9) {
|
|
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
|
|
} else {
|
|
throw err;
|
|
}
|
|
}
|
|
}
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
// ── T3.1: createPool with mixed providers → throws ──────────────────────────
|
|
|
|
test("createPool with two different-provider connections throws /single provider/i", async () => {
|
|
const a = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "a",
|
|
apiKey: "sk-a",
|
|
});
|
|
const b = await providersDb.createProviderConnection({
|
|
provider: "anthropic",
|
|
authType: "apikey",
|
|
name: "b",
|
|
apiKey: "sk-b",
|
|
});
|
|
|
|
const idA = (a as any).id as string;
|
|
const idB = (b as any).id as string;
|
|
|
|
assert.throws(
|
|
() =>
|
|
poolsDb.createPool({
|
|
connectionId: idA,
|
|
connectionIds: [idA, idB],
|
|
name: "Mixed",
|
|
}),
|
|
/same provider|single provider/i
|
|
);
|
|
});
|
|
|
|
// ── T3.2: createPool with same-provider connections → succeeds ──────────────
|
|
|
|
test("createPool with two same-provider connections succeeds with connectionIds.length === 2", async () => {
|
|
const a = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "a",
|
|
apiKey: "sk-a",
|
|
});
|
|
const c = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "c",
|
|
apiKey: "sk-c",
|
|
});
|
|
|
|
const idA = (a as any).id as string;
|
|
const idC = (c as any).id as string;
|
|
|
|
const pool = poolsDb.createPool({
|
|
connectionId: idA,
|
|
connectionIds: [idA, idC],
|
|
name: "SameType",
|
|
});
|
|
|
|
assert.equal(pool.connectionIds.length, 2, "same-provider pool should have 2 connectionIds");
|
|
assert.ok(pool.connectionIds.includes(idA), "pool should include idA");
|
|
assert.ok(pool.connectionIds.includes(idC), "pool should include idC");
|
|
});
|
|
|
|
// ── T3.3: updatePool with mixed-provider connectionIds → throws ──────────────
|
|
|
|
test("updatePool replacing connectionIds with mixed providers throws /single provider/i", async () => {
|
|
const a = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "a",
|
|
apiKey: "sk-a",
|
|
});
|
|
const b = await providersDb.createProviderConnection({
|
|
provider: "anthropic",
|
|
authType: "apikey",
|
|
name: "b",
|
|
apiKey: "sk-b",
|
|
});
|
|
|
|
const idA = (a as any).id as string;
|
|
const idB = (b as any).id as string;
|
|
|
|
// Create a valid single-connection pool first.
|
|
const pool = poolsDb.createPool({
|
|
connectionId: idA,
|
|
name: "StartSingle",
|
|
});
|
|
|
|
// Try updating to mixed-provider set → should throw.
|
|
assert.throws(
|
|
() => poolsDb.updatePool(pool.id, { connectionIds: [idA, idB] }),
|
|
/same provider|single provider/i
|
|
);
|
|
});
|
|
|
|
// ── T3.4: updatePool with same-provider connectionIds → succeeds ─────────────
|
|
|
|
test("updatePool replacing connectionIds with same-provider connections succeeds", async () => {
|
|
const a = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "a",
|
|
apiKey: "sk-a",
|
|
});
|
|
const c = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "c",
|
|
apiKey: "sk-c",
|
|
});
|
|
|
|
const idA = (a as any).id as string;
|
|
const idC = (c as any).id as string;
|
|
|
|
const pool = poolsDb.createPool({
|
|
connectionId: idA,
|
|
name: "StartSingle",
|
|
});
|
|
|
|
const updated = poolsDb.updatePool(pool.id, { connectionIds: [idA, idC] });
|
|
|
|
assert.ok(updated, "updatePool should return updated pool");
|
|
assert.equal(updated!.connectionIds.length, 2, "should have 2 connectionIds after update");
|
|
assert.ok(updated!.connectionIds.includes(idA));
|
|
assert.ok(updated!.connectionIds.includes(idC));
|
|
});
|