Files
OmniRoute/tests/unit/quota-store-pool-total.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

120 lines
4.6 KiB
TypeScript

/**
* tests/unit/quota-store-pool-total.test.ts
*
* Coverage for QuotaStore.poolConsumedTotal():
* - Two keys in same pool → sum equals individual contributions.
* - Different pool or different dim → 0 (isolation).
* - peek() for a single key still returns only that key's own value (no regression).
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-pool-total-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
async function resetStorage() {
core.resetDbInstance();
for (let attempt = 0; attempt < 10; attempt++) {
try {
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
break;
} catch (err: unknown) {
const e = err as { code?: string };
if ((e?.code === "EBUSY" || e?.code === "EPERM") && attempt < 9) {
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
} else {
throw err;
}
}
}
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});
// ─── Main scenario: two keys in same pool ────────────────────────────────────
test("poolConsumedTotal: keyA(3) + keyB(2) in same pool → total === 5", async () => {
const { SqliteQuotaStore } = await import("../../src/lib/quota/sqliteQuotaStore.ts");
const store = new SqliteQuotaStore();
const dim = { poolId: "p1", unit: "requests" as const, window: "5h" as const };
await store.consume("keyA", dim, 3);
await store.consume("keyB", dim, 2);
const total = await store.poolConsumedTotal("p1", dim);
// Both consumes happen in the same bucket (milliseconds apart) so
// prev=0, elapsed≈0 → total ≈ 5. Allow small delta for timing.
assert.ok(total > 4.9, `Expected >4.9, got ${total}`);
assert.ok(total <= 5, `Expected <=5, got ${total}`);
});
// ─── Isolation: different pool ───────────────────────────────────────────────
test("poolConsumedTotal: different poolId → returns 0 (isolation)", async () => {
const { SqliteQuotaStore } = await import("../../src/lib/quota/sqliteQuotaStore.ts");
const store = new SqliteQuotaStore();
const dimP1 = { poolId: "p1", unit: "requests" as const, window: "5h" as const };
const dimP2 = { poolId: "p2", unit: "requests" as const, window: "5h" as const };
await store.consume("keyA", dimP1, 10);
// Pool p2 has no consumption → should be 0
const total = await store.poolConsumedTotal("p2", dimP2);
assert.equal(total, 0, `Expected 0 for different pool, got ${total}`);
});
// ─── Isolation: different dimension (unit) ───────────────────────────────────
test("poolConsumedTotal: different unit dim → returns 0 (isolation)", async () => {
const { SqliteQuotaStore } = await import("../../src/lib/quota/sqliteQuotaStore.ts");
const store = new SqliteQuotaStore();
const dimRequests = { poolId: "p1", unit: "requests" as const, window: "5h" as const };
const dimTokens = { poolId: "p1", unit: "tokens" as const, window: "5h" as const };
await store.consume("keyA", dimRequests, 7);
// tokens dim has no consumption → should be 0
const total = await store.poolConsumedTotal("p1", dimTokens);
assert.equal(total, 0, `Expected 0 for different unit, got ${total}`);
});
// ─── No regression: peek still returns per-key value ─────────────────────────
test("poolConsumedTotal: peek(keyA) still returns only keyA's own consumption", async () => {
const { SqliteQuotaStore } = await import("../../src/lib/quota/sqliteQuotaStore.ts");
const store = new SqliteQuotaStore();
const dim = { poolId: "p1", unit: "requests" as const, window: "5h" as const };
await store.consume("keyA", dim, 3);
await store.consume("keyB", dim, 2);
const peekA = await store.peek("keyA", dim);
// keyA's own peek should be ≈3, not 5
assert.ok(peekA > 2.9, `Expected >2.9, got ${peekA}`);
assert.ok(peekA <= 3, `Expected <=3, got ${peekA}`);
});