Files
OmniRoute/tests/unit/radar-local-state-route.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

181 lines
6.2 KiB
TypeScript

/** API contract for persisted Radar local overrides and tombstones. */
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { SignJWT } from "jose";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-radar-state-api-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.JWT_SECRET = "test-jwt-secret-for-radar-local-state";
process.env.INITIAL_PASSWORD = "test-bootstrap-password-for-radar-local-state";
const core = await import("../../src/lib/db/core.ts");
const route = await import("../../src/app/api/radar/local-model-state/route.ts");
async function authHeaders(): Promise<Record<string, string>> {
const secret = new TextEncoder().encode(process.env.JWT_SECRET);
const token = await new SignJWT({ authenticated: true })
.setProtectedHeader({ alg: "HS256" })
.setIssuedAt()
.setExpirationTime("1h")
.sign(secret);
return { Cookie: `auth_token=${token}` };
}
function request(method: string, body?: unknown, headers: Record<string, string> = {}): Request {
return new Request("http://localhost:20128/api/radar/local-model-state", {
method,
headers: { "Content-Type": "application/json", ...headers },
body: body === undefined ? undefined : JSON.stringify(body),
});
}
async function resetStorage(): Promise<void> {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(resetStorage);
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
delete process.env.DATA_DIR;
delete process.env.RADAR_ENABLED;
delete process.env.JWT_SECRET;
delete process.env.INITIAL_PASSWORD;
});
test("flag-off gate runs before authentication", async () => {
delete process.env.RADAR_ENABLED;
const response = await route.GET(request("GET"));
const text = await response.text();
assert.equal(response.status, 404);
assert.ok(!text.includes("at /"));
});
test("all local-state mutations require authentication when Radar is enabled", async () => {
process.env.RADAR_ENABLED = "true";
const calls = [
route.GET(request("GET")),
route.PATCH(request("PATCH", { provider: "groq", modelId: "model", enabled: false })),
route.PUT(request("PUT", { provider: "groq", modelId: "model", tombstoned: true })),
route.DELETE(request("DELETE")),
];
for (const response of await Promise.all(calls)) {
assert.equal(response.status, 401);
assert.ok(!(await response.text()).includes("at /"));
}
});
test("authenticated CRUD persists overrides and tombstones without conflating them", async () => {
process.env.RADAR_ENABLED = "true";
const headers = await authHeaders();
const patch = await route.PATCH(
request(
"PATCH",
{
provider: "groq",
modelId: "llama-3.3-70b-versatile",
displayName: "My local Groq",
enabled: false,
},
headers
)
);
assert.equal(patch.status, 200);
const patched = await patch.json();
assert.equal(patched.states[0].displayName, "My local Groq");
assert.equal(patched.states[0].enabled, false);
assert.equal(patched.states[0].tombstoned, false);
const hide = await route.PUT(
request(
"PUT",
{ provider: "groq", modelId: "llama-3.3-70b-versatile", tombstoned: true },
headers
)
);
assert.equal(hide.status, 200);
assert.equal((await hide.json()).states[0].tombstoned, true);
const removeOverrideUrl = new URL("http://localhost:20128/api/radar/local-model-state");
removeOverrideUrl.searchParams.set("provider", "groq");
removeOverrideUrl.searchParams.set("modelId", "llama-3.3-70b-versatile");
const remove = await route.DELETE(new Request(removeOverrideUrl, { method: "DELETE", headers }));
assert.equal(remove.status, 200);
const removed = await remove.json();
assert.equal(removed.states[0].displayName, null);
assert.equal(removed.states[0].enabled, null);
assert.equal(removed.states[0].tombstoned, true, "clearing overrides must not restore a model");
const restore = await route.PUT(
request(
"PUT",
{ provider: "groq", modelId: "llama-3.3-70b-versatile", tombstoned: false },
headers
)
);
assert.equal(restore.status, 200);
assert.deepEqual((await restore.json()).states, []);
});
test("strict schemas reject arbitrary fields, empty patches, and control characters", async () => {
process.env.RADAR_ENABLED = "true";
const headers = await authHeaders();
const invalidBodies = [
{ provider: "groq", modelId: "model" },
{ provider: "groq", modelId: "model", enabled: true, origin: "local" },
{ provider: "groq", modelId: "bad\nmodel", enabled: true },
{ provider: "groq", modelId: "model", displayName: " " },
];
for (const body of invalidBodies) {
const response = await route.PATCH(request("PATCH", body, headers));
const text = await response.text();
assert.equal(response.status, 400);
assert.ok(!text.includes("at /"));
assert.ok(!text.includes(".ts:"));
}
});
test("PATCH e PUT rejeitam o corpo pelo byte real antes de materializar JSON excessivo", async () => {
process.env.RADAR_ENABLED = "true";
const headers = await authHeaders();
const oversizedBody = JSON.stringify({
provider: "groq",
modelId: "model",
enabled: true,
padding: "x".repeat(16 * 1024),
});
for (const [method, handler] of [
["PATCH", route.PATCH],
["PUT", route.PUT],
] as const) {
const response = await handler(
new Request("http://localhost:20128/api/radar/local-model-state", {
method,
headers: { "Content-Type": "application/json", ...headers },
body: oversizedBody,
})
);
assert.equal(response.status, 413, method);
}
});
test("GET returns no-store local state for restore controls", async () => {
process.env.RADAR_ENABLED = "true";
const response = await route.GET(request("GET", undefined, await authHeaders()));
assert.equal(response.status, 200);
assert.equal(response.headers.get("cache-control"), "no-store");
assert.deepEqual(await response.json(), { states: [] });
});