mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
55 lines
2.1 KiB
TypeScript
55 lines
2.1 KiB
TypeScript
/**
|
|
* Issue #2357 - Redis is optional. When `REDIS_URL` is unset, the rate
|
|
* limiter must use the in-memory store instead of probing localhost.
|
|
*
|
|
* `ioredis` has a packaging quirk (`@ioredis/commands/built/commands.json`
|
|
* is actually JS, not JSON) that prevents `node:test` from importing it
|
|
* cleanly, so we verify the contract at the source level instead.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
const __dirname = path.dirname(fileURLToPath(import.meta.url));
|
|
const RATE_LIMITER_SRC = path.resolve(__dirname, "../../src/shared/utils/rateLimiter.ts");
|
|
const src = fs.readFileSync(RATE_LIMITER_SRC, "utf8");
|
|
|
|
test("#2357 REDIS_URL no longer falls back to localhost:6379 silently", () => {
|
|
assert.ok(
|
|
!src.includes('process.env.REDIS_URL || "redis://localhost:6379"'),
|
|
"rateLimiter must not default REDIS_URL to localhost"
|
|
);
|
|
assert.ok(
|
|
src.includes('const REDIS_URL = process.env.REDIS_URL?.trim() || "";'),
|
|
"rateLimiter must only use Redis when REDIS_URL is explicitly configured"
|
|
);
|
|
});
|
|
|
|
test("#2357 getRedisClient is strict when REDIS_URL is not set", () => {
|
|
assert.ok(
|
|
src.includes('throw new Error("Redis is not configured");'),
|
|
"getRedisClient must throw when Redis is not configured"
|
|
);
|
|
});
|
|
|
|
test("#2357 checkRateLimit falls back when REDIS_URL is unset", () => {
|
|
assert.ok(
|
|
src.includes("if (!isRedisConfigured())") &&
|
|
src.includes("return checkInMemoryRateLimit(FALLBACK_MEMORY_STORE, keyId, rules);"),
|
|
"checkRateLimit must route to the in-memory fallback when Redis is disabled"
|
|
);
|
|
});
|
|
|
|
test("redis namespace prefix: rate limiter + auth cache keys are namespaced", () => {
|
|
assert.ok(
|
|
src.includes('process.env.REDIS_KEY_PREFIX?.trim() || "omniroute:"'),
|
|
"rateLimiter must read REDIS_KEY_PREFIX with an omniroute: default"
|
|
);
|
|
assert.ok(
|
|
src.includes("keyPrefix: REDIS_KEY_PREFIX"),
|
|
"rateLimiter must pass the prefix as the ioredis keyPrefix so all keys are namespaced"
|
|
);
|
|
});
|