mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 22:32:22 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
66 lines
2.9 KiB
TypeScript
66 lines
2.9 KiB
TypeScript
/**
|
|
* tests/unit/reasoning-placeholder-strip.test.ts
|
|
*
|
|
* Live incident: streamed assistant text was losing the spaces BETWEEN words
|
|
* (e.g. "Bilden är en riktig JPEG nu" -> "Bildenärenriktig JPEG nu") on the
|
|
* Responses-API / Claude streaming paths. Root cause: stripInternalReasoning
|
|
* Placeholder() (open-sse/utils/reasoningPlaceholder.ts, added by #8081/#8162)
|
|
* is called on every individual `delta.content` chunk, and it unconditionally
|
|
* called .trim() even when the placeholder sentinel was never present in that
|
|
* chunk. Tokenizers commonly emit sub-word tokens with a LEADING space as
|
|
* part of the token (e.g. " en", " riktig") — each such chunk got its only
|
|
* whitespace character (the inter-word space) silently trimmed away before
|
|
* being appended to the accumulated message, while the words themselves
|
|
* stayed intact. Punctuation-only chunks were largely unaffected, matching
|
|
* what was observed live.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import {
|
|
NON_ANTHROPIC_THINKING_PLACEHOLDER,
|
|
stripInternalReasoningPlaceholder,
|
|
} from "../../open-sse/utils/reasoningPlaceholder.ts";
|
|
|
|
test("a plain word-token chunk with a leading space is NOT trimmed (no placeholder present)", () => {
|
|
assert.equal(stripInternalReasoningPlaceholder(" en"), " en");
|
|
assert.equal(stripInternalReasoningPlaceholder(" riktig"), " riktig");
|
|
});
|
|
|
|
test("a plain word-token chunk with a trailing space is NOT trimmed (no placeholder present)", () => {
|
|
assert.equal(stripInternalReasoningPlaceholder("Bilden "), "Bilden ");
|
|
});
|
|
|
|
test("reassembling word-token chunks preserves inter-word spaces", () => {
|
|
const chunks = ["Bilden", " är", " en", " riktig", " JPEG", " nu"];
|
|
const rebuilt = chunks.map(stripInternalReasoningPlaceholder).join("");
|
|
assert.equal(rebuilt, "Bilden är en riktig JPEG nu");
|
|
});
|
|
|
|
test("a chunk that IS exactly the placeholder collapses to empty string", () => {
|
|
assert.equal(stripInternalReasoningPlaceholder(NON_ANTHROPIC_THINKING_PLACEHOLDER), "");
|
|
assert.equal(stripInternalReasoningPlaceholder(` ${NON_ANTHROPIC_THINKING_PLACEHOLDER} `), "");
|
|
});
|
|
|
|
test("a chunk with the placeholder mixed into real text strips it (trim only affects the outer ends)", () => {
|
|
// replaceAll leaves a double space where the placeholder was removed; trim()
|
|
// only strips the string's own leading/trailing whitespace, not internal gaps.
|
|
assert.equal(
|
|
stripInternalReasoningPlaceholder(`foo ${NON_ANTHROPIC_THINKING_PLACEHOLDER} bar`),
|
|
"foo bar"
|
|
);
|
|
});
|
|
|
|
test("standalone whitespace-only chunks pass through byte-for-byte when no placeholder is present", () => {
|
|
for (const chunk of [" ", "\t", "\n", "\n\n", "\r\n"]) {
|
|
assert.equal(
|
|
stripInternalReasoningPlaceholder(chunk),
|
|
chunk,
|
|
`expected ${JSON.stringify(chunk)} to remain unchanged`
|
|
);
|
|
}
|
|
});
|
|
|
|
test("an empty string stays empty", () => {
|
|
assert.equal(stripInternalReasoningPlaceholder(""), "");
|
|
});
|