mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 19:02:17 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
54 lines
2.3 KiB
TypeScript
54 lines
2.3 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { createBuiltinAutoCombo } from "@omniroute/open-sse/services/autoCombo/builtinCatalog.ts";
|
|
|
|
// #7754: `auto/best-free` combo name must never leak downstream as the model id.
|
|
// When the free-tier candidate pool resolves non-empty, every model in the combo
|
|
// must carry a concrete `<provider>/<model>` id — never the literal combo name.
|
|
|
|
test("#7754 auto/best-free never leaks the combo name as a model", async () => {
|
|
const combo = await createBuiltinAutoCombo("auto/best-free", "best-free");
|
|
const models = combo.models || [];
|
|
|
|
// The combo id is the modelStr by design (routing resolves it back), but the
|
|
// models array must never contain it as a target model.
|
|
const leak = models.filter(
|
|
(model) =>
|
|
model.id === "auto/best-free" ||
|
|
model.model === "auto/best-free" ||
|
|
("modelStr" in model && model.modelStr === "auto/best-free")
|
|
);
|
|
assert.equal(leak.length, 0, `combo name leaked as a target model: ${JSON.stringify(leak)}`);
|
|
});
|
|
|
|
test("#7754 every auto/best-free model carries a concrete provider/model", async () => {
|
|
const combo = await createBuiltinAutoCombo("auto/best-free", "best-free");
|
|
const models = combo.models || [];
|
|
for (const model of models) {
|
|
assert.ok(
|
|
model.model && model.model !== "auto/best-free",
|
|
`model missing concrete id: ${JSON.stringify(model)}`
|
|
);
|
|
assert.ok(
|
|
model.providerId && model.providerId !== "auto",
|
|
`model missing concrete provider: ${JSON.stringify(model)}`
|
|
);
|
|
}
|
|
});
|
|
|
|
test("#7754 empty free-tier pool degrades with a clear 503, not a name leak", async () => {
|
|
// When NO free-tier candidate exists, createBuiltinAutoCombo must either
|
|
// return an empty models[] (which the #6458 route check converts to a clear
|
|
// 503) or throw — never synthesize a target whose model is the combo name.
|
|
const combo = await createBuiltinAutoCombo("auto/best-free", "best-free");
|
|
const models = combo.models || [];
|
|
if (models.length === 0) {
|
|
// Empty pool is fine — the route layer (#6458) converts it to a clear 503.
|
|
assert.equal(combo.candidatePool?.length || 0, 0);
|
|
} else {
|
|
// Non-empty pool must not leak.
|
|
const leak = models.filter((model) => model.model === "auto/best-free");
|
|
assert.equal(leak.length, 0);
|
|
}
|
|
});
|