mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
71 lines
2.8 KiB
TypeScript
71 lines
2.8 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { syncStandaloneNativeAssets } from "../../scripts/build/assembleStandalone.mjs";
|
|
|
|
/**
|
|
* Repro #8847: better-sqlite3 prebuilds are not included in the standalone
|
|
* bundle, so the bundled app fails when the platform's prebuild is needed
|
|
* (e.g. under Bun, which resolves the native binary via prebuilds/ rather
|
|
* than build/Release/).
|
|
*
|
|
* The test creates a synthetic node_modules/better-sqlite3/ tree with both
|
|
* the compiled build/Release/ binary AND the prebuilds/ directory, then
|
|
* confirms that syncStandaloneNativeAssets copies both into the standalone
|
|
* output. On the unfixed code this fails because NATIVE_ASSET_ENTRIES only
|
|
* lists better-sqlite3/build/.
|
|
*/
|
|
test("repro-8847: better-sqlite3 prebuilds are bundled alongside the compiled binary", async () => {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "repro-8847-"));
|
|
const projectRoot = path.join(tmp, "src-root");
|
|
|
|
// Seed better-sqlite3 with both build/Release/ and prebuilds/.
|
|
const bsqlDir = path.join(projectRoot, "node_modules", "better-sqlite3");
|
|
fs.mkdirSync(path.join(bsqlDir, "build", "Release"), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(bsqlDir, "build", "Release", "better_sqlite3.node"),
|
|
"// native binary placeholder"
|
|
);
|
|
fs.mkdirSync(path.join(bsqlDir, "prebuilds"), { recursive: true });
|
|
for (const target of [
|
|
"darwin-arm64.node",
|
|
"darwin-x64.node",
|
|
"linux-arm64.node",
|
|
"linux-x64.node",
|
|
"linuxmusl-arm64.node",
|
|
"linuxmusl-x64.node",
|
|
"win32-arm64.node",
|
|
"win32-x64.node",
|
|
]) {
|
|
fs.writeFileSync(path.join(bsqlDir, "prebuilds", target), `// ${target}`);
|
|
}
|
|
|
|
const outDir = path.join(tmp, "standalone");
|
|
fs.mkdirSync(outDir, { recursive: true });
|
|
|
|
// Act: copy native assets into the standalone output.
|
|
await syncStandaloneNativeAssets(projectRoot, fs.promises, { log() {} }, outDir);
|
|
|
|
// Assert: the compiled build/Release/ binary was copied.
|
|
assert.ok(
|
|
fs.existsSync(
|
|
path.join(outDir, "node_modules", "better-sqlite3", "build", "Release", "better_sqlite3.node")
|
|
),
|
|
"compiled native binary (build/Release/) must be in the standalone bundle"
|
|
);
|
|
|
|
// Assert: the prebuilds/ directory was also copied.
|
|
const prebuildsDir = path.join(outDir, "node_modules", "better-sqlite3", "prebuilds");
|
|
assert.ok(fs.existsSync(prebuildsDir), "prebuilds/ directory must be in the standalone bundle");
|
|
|
|
// Assert: at least one prebuild file was copied.
|
|
assert.ok(
|
|
fs.existsSync(path.join(prebuildsDir, "linux-x64.node")),
|
|
"linux-x64 prebuild must be in the standalone bundle"
|
|
);
|
|
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|